October 2009 - Wine-bugs - list.winehq.org

[Bug 20458] New: RM2k3 Event Editor still very slow
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20458 Summary: RM2k3 Event Editor still very slow Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: miki600(a)gmail.com Switching to event editor is now faster with wine 1.1-32, but scrolling map in event editor is laggy as hell! I tried wine from openSUSE repo and I compiled it myself, but it doesn't help(I tried with clean wineprefix and with my old-all the same). I hope it will be fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 3

[Bug 20440] New: RM2k3 Event Editor works very slow.
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20440 Summary: RM2k3 Event Editor works very slow. Product: Wine Version: unspecified Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: major Priority: P1 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: rave002(a)o2.pl When I switch to Event Layer in RPG Maker 2003 it takes a several seconds to few minutes before events and event grid will show up. Probably something slowing in redraw system, because after editing an event I must wait too. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 9

[Bug 20478] New: Civilization IV hangs at exiting the game
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=20478 Summary: Civilization IV hangs at exiting the game Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: atiitto(a)luukku.com Civilization hangs after exiting the game via Main Menu > Exit. Computer must be restarted, because nothing else works. Tired with/without Virtual Desktop and it hangs every time. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 2

[Bug 3952] MapleStory needs GameGuard support
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=3952 msn(a)gaiatools.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |msn(a)gaiatools.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7592] Window problems when running Citrix ICA client ICA16 v6.20.985 (Win16)
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7592 --- Comment #12 from Christian Uceda <christianuceda(a)yahoo.com> 2009-10-26 19:25:14 --- Created an attachment (id=24382) --> (http://bugs.winehq.org/attachment.cgi?id=24382) Ica client complaining about ini settings -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7592] Window problems when running Citrix ICA client ICA16 v6.20.985 (Win16)
by wine-bugs＠winehq.org 27 Oct '09

27 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7592 --- Comment #11 from Christian Uceda <christianuceda(a)yahoo.com> 2009-10-26 19:23:42 --- Tested again on Wine version 1.1.32 the English version installs perfectly this time and the application starts. However it does complain about settings missing from the ini file and if you try to create a new connection pressing on a button or a menu the application does not do anything at all, or at least it seems not to do anything visible. When it complains about missing settings from the ini file it does it using an alert dialog on the form: Remote Application Manager The [ift] section in the c:\ICA16\APPSRV.INI does not contain a TransportDriver or DeviceName entry. The section will be ignored (ok) See new screenshot attachment. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #18 from Shachar Shemesh <shachar(a)shemesh.biz> 2009-10-26 17:27:16 --- (In reply to comment #17) > > The main problem with this order of doing things is that shaping may change the > width of the character, which affects the line breaking algorithm. > > yes but it's already broken! That's because I got it wrong in the comment. The correct order is: 1. Calculate levels 2. Shaping 3. Line break 4. Reorder http://www.lingnu.com/en/programming/57-bidi-aware-programming-introduction… got it right. > if you like can I make a version to be called on un-ordered text, but you > should grant me that your ordering function can handle shaped chars like > U+FECC ARABIC LETTER AIN MEDIAL FORM What is special about that particular one? > so if this is fine with you, please tell me and I'll send you a version of > BIDI_Shaper that takes unordered argument > and do you want it to work in line (like current one or should it work on a new > copy or should it take some buffer to work on ...etc) > just tell me what do you want. I "want" wine to implement Uniscribe ( http://msdn.microsoft.com/en-us/library/dd374091(VS.85).aspx ), and implement BiDi through it. As I don't call the shots on any of this. I just give my input. > > so please rename BIDI_Shaper into BIDI_Post_Ordering_Shaper and push it. > and we can add BIDI_Shaper which works before ordering later after you make a > room for it to be called. what do you think ? Sorry. If I had time to do that, I'd work on my itches in Wine. Shachar -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #17 from alsadi <alsadi(a)ojuba.org> 2009-10-26 16:15:46 --- > The main problem with this order of doing things is that shaping may change the width of the character, which affects the line breaking algorithm. yes but it's already broken! > Yes, I know, it's a drastic change to the algorithm. if you like can I make a version to be called on un-ordered text, but you should grant me that your ordering function can handle shaped chars like U+FECC ARABIC LETTER AIN MEDIAL FORM and I'll left calling the shaping function for you because you said: > level calculation and reordering are done in one step, and that therefor it is a little impossible to implement the steps as described, so if this is fine with you, please tell me and I'll send you a version of BIDI_Shaper that takes unordered argument and do you want it to work in line (like current one or should it work on a new copy or should it take some buffer to work on ...etc) just tell me what do you want. > Which is why I said this does not mean it cannot go in, just that it will, eventually, have to be replaced. so please rename BIDI_Shaper into BIDI_Post_Ordering_Shaper and push it. and we can add BIDI_Shaper which works before ordering later after you make a room for it to be called. what do you think ? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #16 from Shachar Shemesh <shachar(a)shemesh.biz> 2009-10-26 15:28:11 --- (In reply to comment #14) > > Shachar! why haven't you implemented your docs ? > Perhaps when I have time to even finish them.... > according to me the proper BiDi handling is :-) > - Bidi level calculations > - Line breaking > - Reodering > - Shaping > The main problem with this order of doing things is that shaping may change the width of the character, which affects the line breaking algorithm. For (an extreme) example, try writing a long sequence of U0644 (Lam), U0627 (Alef), and U0020 (space) ("No no no no no...."). The length (in pixels) of each word is dramatically different before and after shaping. As such, a line break algorithm working on the unshaped paragraph will make drastically different decisions regarding where to break the line (how many "La" fit in a single line) whether it sees the string before or after shaping. The only sane way of handling this is to perform the line breaking after the shaping, when the final width of each character is known. Yes, I know, it's a drastic change to the algorithm. > my code is very optimized, so if you just want to move things for optimization > purpose just forget it, you won't get a better performance, that would be near > impossible. I want to move things to make things more correct, not more optimized. > > why did I made it the last step of BiDi process ? > because shaping changes the characters which would interfere the Reodering > process > > for example a Reodering routine might know that U+639 is RTL but it may/may not > know that U+FECC is RTL too (many Reodering routines in many project don't > handle this case, I don't know about wine) > That is precisely why we calculate the BiDi levels first. Actual reordering takes place based on the BiDi levels. The actual character database is never consulted again. > > and since I don't want to change any other function, I made it after Reodering. Which is why I said this does not mean it cannot go in, just that it will, eventually, have to be replaced. > > the case where Shaping should be done before reodering is when the char length > of U+0639 is less that shaped U+FECC > but this is not the case in wine (UTF-16) so the positions calculated by your > reordering are granted to be valid as my function is 1-1. Like I said above, this is more about pixel width of the characters than it is about the byte length of their representation. > > the right thing to do is to use HarfBuzz which is in its way as a standalone > library. > http://fedoraproject.org/wiki/Features/Harfbuzz > > but since this is a decision to be made in winehq, this is the only thing I can > do. The right thing to do is to move the BiDi implementation to Uniscribe, and split it the way Windows does. Until we do, our implementation is going to be partial no matter what algorithm or library we use. Shachar -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 7150] Implement Arabic shaping
by wine-bugs＠winehq.org 26 Oct '09

26 Oct '09

http://bugs.winehq.org/show_bug.cgi?id=7150 --- Comment #15 from Alexander Scott-Johns <alexander.scott.johns+winebug(a)googlemail.com> 2009-10-26 14:25:54 --- (In reply to comment #13) > > Muayyad, wine developers don't grab patches from bugzilla, see > my beloved brother, as you know I send patches to several project (anaconda, > publican, gnome-xsl, packagekit, pulseaudio, fedora, ...) and they all > accept my patches through bugzilla > > could you please please continue with them if I were too busy. I think the maintainer has Emacs hooked up to the wine-patches mailing list, and doesn't want to change his workflow... > > * Please keep the spacing of your code consistent with the rest of the > > file(4 space indentation, spaces around binary operators, etc). > > my patches only add lines so put the code I added into a file then call a > indent tool over it with the right arguments winehq wants, that's not a big > deal :-) Wine is very careful about maintaining authorship info; changing other people's patches and submitting them isn't liked that much. > BTW: what are those argument (so that I would do this step if I send > patches to winehq in the future) > [snip] > > * Can you please use slightly more descriptive variable names than p, c, > > cn, ch, jx, jcn, jpc, j, i and ix? > > it's a complicated optimized algorithm, in which variables could be reused, > but since those variables are locally used within my function only they > don't worth commenting or being long (as in kernel coding style) Yes, but this isn't the kernel... Short variable names are good, but it should be obvious what they mean. > but don't worry here are the meanings [snip] > > > * Is it possible to write conformance tests for this? (If so, please > > include some, as the patch will be much more likely to get in.) > > I'm a native speaker and it works, we ship the patched version in our distro > (ojuba linux) and we had offered several patched version in parallel to all > wine updates in fedora 11 > Conformance tests are also useful as regression tests, in case someone else breaks your code later on. Also remember that Wine doesn't try to do things _correctly_, but to do them the same way Windows does. > we have not received bug reports related to this patch [snip] > shaping will be skipped. > > > * You may find it easier to manage and generate your patches with Git. > this patch only add lines that are independent of the code, I'm certain > that can be applied cleanly as-is without any extra effort. > > please try it, and inform me if it did not. I'm sure it does apply cleanly. It's just that using a CMS (like git) would make it much easier to rebase (update) from WineHQ when the maintainer applies patches. PS: I can't speak/read Arabic, nor do I have any Arabic Windows programs, so I can't really test the patch or comment on how it works (just how it looks). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0