February 2009 - Wine-bugs - list.winehq.org

[Bug 13319] New: In dlls/user32/edit. c EDIT_EM_ReplaceSel Clobbers Important Var When Buffer Overflows
by wine-bugs＠winehq.org 29 Dec '17

29 Dec '17

http://bugs.winehq.org/show_bug.cgi?id=13319 Summary: In dlls/user32/edit.c EDIT_EM_ReplaceSel Clobbers Important Var When Buffer Overflows Product: Wine Version: unspecified Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: bsmith(a)sudleyplace.com Please don't hate me, but I don't have git or anything like it installed to make a formal patch, but I have benefited greatly from your work, so I'd like to repay the effort by reporting a bug even though I realize it's not in the correct format. In a Windows app, I am using edit.c as a replacement for the EDIT control in Windows. I don't use any of the other WineHQ files. Here's a short description of the bug: The handler EDIT_EM_ReplaceSel misbehaves when an insertion triggers a buffer overflow. The code correctly calls EDIT_NOTIFY_PARENT(es, EN_MAXTEXT), but shortly thereafter clobbers an important variable (strl) by using it instead of a temporary. The relevant OLD code in EDIT_EM_ReplaceSel is as follows: -------------------------------------------------------------- if ((honor_limit) && (size > es->buffer_limit)) { EDIT_NOTIFY_PARENT(es, EN_MAXTEXT); /* Buffer limit can be smaller than the actual length of text in combobox */ if (es->buffer_limit < (tl - (e-s))) strl = 0; else strl = es->buffer_limit - (tl - (e-s)); } if (!EDIT_MakeFit(es, tl - (e - s) + strl)) return; -------------------------------------------------------------- the NEW code is as follows: -------------------------------------------------------------- if ((honor_limit) && (size > es->buffer_limit)) { EDIT_NOTIFY_PARENT(es, EN_MAXTEXT); /* Buffer limit can be smaller than the actual length of text in combobox */ if (es->buffer_limit < (tl - (e-s))) strl2 = 0; else strl2 = es->buffer_limit - (tl - (e-s)); } else strl2 = strl; if (!EDIT_MakeFit(es, tl - (e - s) + strl2)) return; -------------------------------------------------------------- The calculation inside the honor_limit bracket of the value to use with the call to EDIT_MakeFit uses strl as if it were a temp var. This variable actually holds strlenW (lpsz_replace) and is used in later code as if it still had the original value. Using a (new) variable strl2 solves that problem -- this variable is declared as a UINT in the prologue. Perhaps you would prefer a name different from strl2 to better reflect its temporary nature. If you agree with the above analysis, I would greatly appreciate it if someone would make this into a patch and take it from there. I have make the above changes in my copy of edit.c and it works just fine when the buffer overflows which is how I stumbled on this bug in the first place. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 46

[Bug 10164] New: Pool of Radiance 1. 4 intermittently shows garbage in surfaces
by wine-bugs＠winehq.org 22 Dec '17

22 Dec '17

http://bugs.winehq.org/show_bug.cgi?id=10164 Summary: Pool of Radiance 1.4 intermittently shows garbage in surfaces Product: Wine Version: 0.9.47. Platform: PC URL: http://www.fileshack.com/file.x/906/Pool+of+Radiance+Dem o OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-directx-d3d AssignedTo: wine-bugs(a)winehq.org ReportedBy: sick_soul(a)yahoo.it CC: xerox_xerox2000(a)yahoo.co.uk, stefandoesinger(a)gmx.at, 07067514(a)brookes.ac.uk (see bug #10133) After reverting d9fef10b71b9add27cfaeffa6d7e3ab42342bba7 I got Pool of Radiance 1.4 to start again. I found another regression for this application, in that some surfaces do not get displayed correctly, and some show quick intermittent garbage in them. This does not happen with older versions of wine. I did a regression test for this, which gave me: 3b822b80feba396ec017c9ef0d96d59a1733a2d8 is first bad commit commit 3b822b80feba396ec017c9ef0d96d59a1733a2d8 Author: Stefan DÃ¶singer <stefan(a)codeweavers.com> Date: Tue Aug 21 23:24:16 2007 +0200 wined3d: Reject opengl accelerated blits with system memory surfaces. :040000 040000 8ef4e54af50c3dbd862ff89bc80e1d1b00791f31 dcf76dd03a3451b4eed44796f39ccb1faee4ae6f M dlls I reverted the change in current git, and the problem went away. To summarize I could get the application to start, and show correct surfaces by reverting these two: http://source.winehq.org/git/wine.git/?a=commitdiff_plain;h=d9fef10b71b9add… http://source.winehq.org/git/wine.git/?a=commitdiff_plain;h=3b822b80feba396… I hope this information can be useful to you. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 27

[Bug 14313] New: Areena 5 help pages don't work at all
by wine-bugs＠winehq.org 19 Dec '17

19 Dec '17

http://bugs.winehq.org/show_bug.cgi?id=14313 Summary: Areena 5 help pages don't work at all Product: Wine Version: 1.1.0 Platform: All OS/Version: All Status: UNCONFIRMED Severity: trivial Priority: P4 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: ape3000(a)gmail.com In the game Areena 5, I can't use the help pages at all. They aren't very important part of the game. In fact the help pages are quite useless, but I submit a bug report, because I think this bug is blocking the Platinum rating for the game. So there is a menu called Apua -> Ohje (in English something like: Help -> Help Contents). When I click it nothing happens. So the help pages can't be used at all. There are AREHELP.HLP and AREHELP.GID files in the game folder. All the help data can be found the in somewhat packed format. This will show up every time I click the help: fixme:ole:OLEPictureImpl_Render Not quite correct implementation of rendering icons... I think that it has pretty much nothing to do with the real problem, but anyways. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 15

[Bug 14296] New: winhelp: Extraneous flashing cursor/caret
by wine-bugs＠winehq.org 08 Dec '17

08 Dec '17

http://bugs.winehq.org/show_bug.cgi?id=14296 Summary: winhelp: Extraneous flashing cursor/caret Product: Wine Version: 1.1.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: markk(a)clara.co.uk Wine winhelp shows a flashing cursor/caret symbol when you click somewhere in the text. Windows winhelp does not do that. That behaviour may be desired, e.g. it makes selecting text using the keyboard possible. However... Click in a page so the cursor is shown, then click on a link to go to another page. A flashing cursor is present at the top left, even before you click in the page. On some help pages, the flashing cursor is present at the top left even before the user clicks in the page. Also, if there is a large graphic at the top left, the flashing cursor may appear (see cwdeluxe.hlp and click on the picture). Windows 95 Winhelp does not allow images to be selected. cwdeluxe.hlp is in winehelp_bugs.tar.bz2 at http://bugs.winehq.org/attachment.cgi?id=14574 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 12

[Bug 9466] New: the api status page doesn't work
by wine-bugs＠winehq.org 04 Dec '17

04 Dec '17

http://bugs.winehq.org/show_bug.cgi?id=9466 Summary: the api status page doesn't work Product: WineHQ.com Version: unspecified Platform: Other OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: misc-web AssignedTo: wine-bugs(a)winehq.org ReportedBy: bl4ck.3yed(a)gmail.com This is what it say Warning: mysql_num_fields(): supplied argument is not a valid MySQL result resource in /home/winehq/opt/tools/winapi_stats.php on line 118 Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/winehq/opt/tools/winapi_stats.php on line 129 last modified: Fri Aug 24 9:53:14 CDT 2007 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 5

[Bug 16499] New: Adobe Photoshop CS4 crashes upon using text input tool
by wine-bugs＠winehq.org 23 Nov '17

23 Nov '17

http://bugs.winehq.org/show_bug.cgi?id=16499 Summary: Adobe Photoshop CS4 crashes upon using text input tool Product: Wine Version: 1.1.7 Platform: All OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: maevey(a)hotmail.com Created an attachment (id=17921) --> (http://bugs.winehq.org/attachment.cgi?id=17921) Terminal output log Photoshop installs and starts okay. All tools seem to work (after basic testing). Clicking on the text input tool causes application to crash. Log attached Using Ubuntu 8.10 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 63

[Bug 16948] New: tmpfile() write, seek(0) and read does not return same data
by wine-bugs＠winehq.org 20 Oct '17

20 Oct '17

http://bugs.winehq.org/show_bug.cgi?id=16948 Summary: tmpfile() write, seek(0) and read does not return same data Product: Wine Version: unspecified Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: lkcl(a)lkcl.net ok this is tested from python (import os) so it _could_ be done a little simpler - like... using c. didn't want to forget about it so am raising it here. this is the mode opening a tmpfile: fixme:msvcrt:MSVCRT__sopen : pmode 0x1464e0 ignored http://bugs.python.org/issue4956 $ ./python.exe -i Python 2.5.2 (r252:60911, Jan 15 2009, 23:28:55) [gcc] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> f = os.tmpfile() >>> f.name '<tmpfile>' >>> f.write("hello\n") >>> f.flush() >>> f <open file '<tmpfile>', mode 'w+b' at 0x001B34E8> >>> f.tell() 6L >>> f.seek(0) >>> f.tell() 0L >>> f.read() '' it's as if it's impossible to read from the tmpfile. which kinda defeats the object of having one :) c:\windows\temp exists but c:\windows\tmp does not. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 27

[Bug 11433] New: unimplemented function ole32.dll.OleGetIconOfFile
by wine-bugs＠winehq.org 20 Oct '17

20 Oct '17

http://bugs.winehq.org/show_bug.cgi?id=11433 Summary: unimplemented function ole32.dll.OleGetIconOfFile Product: Wine Version: 0.9.44. Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ole AssignedTo: wine-bugs(a)winehq.org ReportedBy: alex.doll(a)agdconsulting.ca Created an attachment (id=10561) --> (http://bugs.winehq.org/attachment.cgi?id=10561) Backtrace from the shell Using Lotus Notes, attempted to attach an external file to a document. Notes tried to determine the icon of the attached item (a PDF) and died: Unhandled exception: unimplemented function ole32.dll.OleGetIconOfFile called in 32-bit code (0x7b844852). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 12

[Bug 12799] New: Notepad++ : auto-completion window appears with a title bar which is not the case under windows
by wine-bugs＠winehq.org 10 Oct '17

10 Oct '17

http://bugs.winehq.org/show_bug.cgi?id=12799 Summary: Notepad++ : auto-completion window appears with a title bar which is not the case under windows Product: Wine Version: 0.9.60 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: leohome(a)free.fr Auto-completion feature works fine but when I use it, the window appears with the title bar which is not the case under windows. This title bar hide the text behind which prevents me to use this feature. (see attachment) This problem occurs with all wine versions I have tested: 0.9.5x up to 0.9.60. kubuntu 7.10 notepad++ version: all recent one I have tested -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 29

[Bug 17276] New: broken encoding in AppDB PM E-Mails
by wine-bugs＠winehq.org 10 Oct '17

10 Oct '17

http://bugs.winehq.org/show_bug.cgi?id=17276 Summary: broken encoding in AppDB PM E-Mails Product: WineHQ Apps Database Version: unspecified Platform: PC OS/Version: Windows 2000 Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: appdb-unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: hoehle(a)users.sourceforge.net Text entered into AppDB's personal e-mail form at http://appdb.winehq.org/contact.php?iRecipientId=NNNN is not transmitted correctly to the recipient, as e.g. Umlauts are broken somewhere in between. For instance, ö (o Umlaut) becomes "A?" This is presumably different from bug #16514, because I don't expect the text we type into the PM form to transit via a database. Even if it would, my understanding is that the redesigned AppDB site consistently uses UTF-8 and "only" broke all old content. There may be several bugs involved: 1. E-Mail contains "MIME-Version: 1.0" header, but no mention of encoding. 2. The Subject line in the header is not recoded when Umlauts are present (the RFC-headers must be all ASCII). A simple test: In the body, -äöüÄÖÜß- becomes -A$A?A1/4A"A-AoeAY- ------------------------------------------------------- The following message was sent to you from JA?rg HA?hle through the Wine AppDB contact form. To Reply, visit http://appdb.winehq.org/contact.php?iRecipientId=NNNN&sSubject=Re%3A+test+-… (The Umlauts got recoded in the URL). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

1 11