January 2022 - Wine-bugs - list.winehq.org

[Bug 39699] New: WINE Crashed during setup of 'EDT for Windows'
by wine-bugs＠winehq.org 12 Apr '22

12 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=39699 Bug ID: 39699 Summary: WINE Crashed during setup of 'EDT for Windows' Product: Wine Version: 1.6-rc2 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: D.Kurtz(a)web.de Distribution: --- Created attachment 52941 --> https://bugs.winehq.org/attachment.cgi?id=52941 Saved Crashfile During running the Setup-Programm WINE crashed. I have Linux-Mint 17.2 and Wine !:1.6.2 You can get the Programm 'EDTW = EDT für Windows' at this Link: http://opg.de/download/edtw/setupedt.exe If possible please answer in German language because my english is very bad. Thanks Dietmar -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2 14

[Bug 52037] New: MaiDenSnow Eve trial crashes upon entering load menu
by WineHQ Bugzilla 12 Apr '22

12 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=52037 Bug ID: 52037 Summary: MaiDenSnow Eve trial crashes upon entering load menu Product: Wine Version: 6.19 Hardware: x86-64 URL: https://trial.dlsite.com/doujin/RJ116000/RJ115762_tria l.zip OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: galtgendo(a)o2.pl Distribution: --- I'm reporting against 6.19, but IIRC this predates 6.0. I have no proof that the problem stems from the code in win32u/gdiobj.c, as gdb backtraces report stack being corrupted. Yet after changing the warning in handle_entry to print handle value, I can see the handle (font) being accessed after being freed by free_gdi_handle. Also, 'all,-heap' somehow sidesteps the crash, for a price of a major slowdown. The crash is 'illegal instruction', so once again, stack corruption. To reproduce: - run the trial - pick the last option (fourth) in the menu - pick 'New Game' - go with the first option in the next menu - as the game starts, access menu (press X) and save (first option) - press F12 to quickly restart the game - back at the title screen pick 'Load Game' - ...get the crash (if at any point you get a splash screen with some text and a clock image, you need to press 'up,left,up,down,right' on the keyboard) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 19841] New: Wolfenstein (2009): mouse cursor remains onscreen during FPS gameplay even after all menus are closed.
by wine-bugs＠winehq.org 12 Apr '22

12 Apr '22

http://bugs.winehq.org/show_bug.cgi?id=19841 Summary: Wolfenstein (2009): mouse cursor remains onscreen during FPS gameplay even after all menus are closed. Product: Wine Version: 1.1.28 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: ben.r.xiao(a)gmail.com In Wolfenstein (2009), browsing the intelligence reports or upgrading weapons sometimes causes the mouse cursor to remain on screen even when the in-game menus are closed. In other words, during FPS gameplay, the cursor sits right where the crosshairs should be and does not disappear. Needless to say this is quite distracting. This cursor bug seems to appear randomly, but always after browsing an intelligence report or upgrading weapons. The only way to get rid of the cursor is to restart the game. I'll post an attachment showing this bug the next time I see it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

2 8

[Bug 46936] New: cannot upgrade to wine-devel 4.5~bionic ( libfaudio0 dependency missing)
by wine-bugs＠winehq.org 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=46936 Bug ID: 46936 Summary: cannot upgrade to wine-devel 4.5~bionic (libfaudio0 dependency missing) Product: Packaging Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: critical Priority: P2 Component: wine-packages Assignee: wine-bugs(a)winehq.org Reporter: a34ypool3voiz(a)t-online.de CC: michael(a)fds-team.de, sebastian(a)fds-team.de Distribution: --- Created attachment 64049 --> https://bugs.winehq.org/attachment.cgi?id=64049 log showing missing libfaudio0 deps I have installed winehq-devel 4.4 on Ubuntu 18.04 amd64. Currently version 4.5 is available, but installation fails. Trying the usual "apt-get update && apt-get upgrade && apt-get dist-upgrade" lists winehq-devel as package that has been kept back. Then I tried the following: sudo apt-get install winehq-devel wine-devel wine-devel-amd64 wine-devel-i386 -f Now two unmet dependencies are listed, which cause the failure: libfaudio0 and libfaudio0:i386. Those packages do not exist in the repository. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2 39

[Bug 50251] New: Wrong public key from the repo prevents installation.
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=50251 Bug ID: 50251 Summary: Wrong public key from the repo prevents installation. Product: Packaging Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: critical Priority: P2 Component: wine-packages Assignee: wine-bugs(a)winehq.org Reporter: kristijan.zic(a)gmail.com CC: dimesio(a)earthlink.net Distribution: --- Distro: Ubuntu 20.04 Followed instructions for Focal Fossa here: https://wiki.winehq.org/Ubuntu Got this error: Err:10 https://dl.winehq.org/wine-builds/ubuntu focal InRelease The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 76F1A20FF987672F Reading package lists... Done W: GPG error: https://dl.winehq.org/wine-builds/ubuntu focal InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 76F1A20FF987672F E: The repository 'https://dl.winehq.org/wine-builds/ubuntu focal InRelease' is not signed. N: Updating from such a repository can't be done securely, and is therefore disabled by default. N: See apt-secure(8) manpage for repository creation and user configuration details. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 51920] New: Official package for Arch Linux
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=51920 Bug ID: 51920 Summary: Official package for Arch Linux Product: Packaging Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: wine-packages Assignee: wine-bugs(a)winehq.org Reporter: joseskvolpe(a)gmail.com CC: dimesio(a)earthlink.net Distribution: ArchLinux Wine has packages on the Arch Linux multilib and community repository, they're currently maintained by Felix Yan (Wine) and Daniel Bermond (Wine-gecko & Wine-mono) Problem is... Sometimes there's a huge delay on these packages when they get an update. This is not a issue only with Wine, it occurs with many other packages that are maintained in these repositories. Wine has just released version 6.20, but these repositories are still in 6.16... If we had a official WineHQ repository for Arch Linux distributions like we got in Ubuntu and Debian, we could get updates for Wine much quicker. Additionally, having git versions on the official repository would also be neat to get nightly builds of Wine. ^w^ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 51933] New: 404 Not Found with sudo apt update
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=51933 Bug ID: 51933 Summary: 404 Not Found with sudo apt update Product: Wine-staging Version: 6.20 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: osaka.niconico(a)gmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- I get the error 404 Not Found with `sudo apt update` and can't install wine. please take a look LANG=en sudo apt update Get:1 https://dl.winehq.org/wine-builds/ubuntu impish InRelease [8043 B] Get:2 https://dl.winehq.org/wine-builds/ubuntu impish/main i386 Packages [6952 B] Get:3 https://dl.winehq.org/wine-builds/ubuntu impish/main amd64 Packages [6936 B] Hit:4 http://security.ubuntu.com/ubuntu impish-security InRelease Err:5 https://dl.winehq.org/wine-builds/ubuntu impish/main all Packages 404 Not Found [IP: 151.101.74.217 443] Err:5 https://dl.winehq.org/wine-builds/ubuntu impish/main all Packages 404 Not Found [IP: 151.101.74.217 443] https://gist.github.com/GitHub30/84364cd3d749b0a1da151e845383729e lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 21.10 Release: 21.10 Codename: impish uname -a Linux impish 5.13.0-20-generic #20-Ubuntu SMP Fri Oct 15 14:21:35 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux 151.101.230.217(cache-hnd18751-HND) on Fastly is not working host -v dl.winehq.org Trying "dl.winehq.org" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 59687 ;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;dl.winehq.org. IN A ;; ANSWER SECTION: dl.winehq.org. 111 IN CNAME osff.map.fastly.net. osff.map.fastly.net. 1 IN A 151.101.230.217 Received 80 bytes from 127.0.0.53#53 in 8 ms Trying "osff.map.fastly.net" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 57706 ;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;osff.map.fastly.net. IN AAAA Received 37 bytes from 127.0.0.53#53 in 20 ms Trying "osff.map.fastly.net" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 63933 ;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;osff.map.fastly.net. IN MX Received 37 bytes from 127.0.0.53#53 in 20 ms LANG=en wget -d https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa… DEBUG output created by Wget 1.21 on linux-gnu. Reading HSTS entries from /home/indri/.wget-hsts URI encoding = 'ANSI_X3.4-1968' converted 'https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa…' (ANSI_X3.4-1968) -> 'https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa…' (UTF-8) Converted file name 'Packages' (UTF-8) -> 'Packages' (ANSI_X3.4-1968) --2021-10-27 10:34:21-- https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa… Resolving dl.winehq.org (dl.winehq.org) 151.101.230.217 Caching dl.winehq.org => 151.101.230.217 Connecting to dl.winehq.org (dl.winehq.org)|151.101.230.217|:443... connected. Created socket 3. Releasing 0x000055bbc1fc6ac0 (new refcount 1). Initiating SSL handshake. Handshake successful; connected socket 3 to SSL handle 0x000055bbc1fc78a0 certificate: subject: CN=*.winehq.org issuer: CN=GlobalSign Atlas R3 DV TLS CA 2020,O=GlobalSign nv-sa,C=BE X509 certificate successfully verified and matches host dl.winehq.org ---request begin--- GET /wine-builds/ubuntu/dists/impish/main/binary-all/Packages HTTP/1.1 User-Agent: Wget/1.21 Accept: */* Accept-Encoding: identity Host: dl.winehq.org Connection: Keep-Alive ---request end--- HTTP request sent, awaiting response... ---response begin--- HTTP/1.1 404 Not Found Connection: keep-alive Content-Length: 196 Server: Apache Strict-Transport-Security: max-age=31536000 Cache-Control: max-age=604800 Content-Type: text/html; charset=iso-8859-1 Via: 1.1 varnish, 1.1 varnish Fastly-Debug-Digest: 71bd9e11bef6b16fa199d390a7364dfd70068eba5cc79f273515095069aaf4ec Accept-Ranges: bytes Date: Wed, 27 Oct 2021 01:34:22 GMT Age: 1076405 X-Served-By: cache-ord1730-ORD, cache-hnd18738-HND X-Cache: MISS, HIT X-Cache-Hits: 0, 6 X-Timer: S1635298462.347604,VS0,VE0 Vary: Accept-Encoding ---response end--- 404 Not Found Registered socket 3 for persistent reuse. Parsed Strict-Transport-Security max-age = 31536000, includeSubDomains = false Updated HSTS host: dl.winehq.org:443 (max-age: 31536000, includeSubdomains: false) URI content encoding = 'iso-8859-1' Skipping 196 bytes of body: [<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>404 Not Found</title> </head><body> <h1>Not Found</h1> <p>The requested URL was not found on this server.</p> </body></html> ] done. 2021-10-27 10:34:21 ERROR 404: Not Found. Saving HSTS entries to /home/indri/.wget-hsts But 151.101.110.217(cache-tyo11944-TYO) or 151.101.74.217(cache-nrt18337-NRT) on Fastly is working host -v dl.winehq.org Trying "dl.winehq.org" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 18470 ;; flags: qr rd ra; QUERY: 1, ANSWER: 2, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;dl.winehq.org. IN A ;; ANSWER SECTION: dl.winehq.org. 110 IN CNAME osff.map.fastly.net. osff.map.fastly.net. 30 IN A 151.101.110.217 Received 80 bytes from 127.0.0.53#53 in 24 ms Trying "osff.map.fastly.net" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 52478 ;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;osff.map.fastly.net. IN AAAA Received 37 bytes from 127.0.0.53#53 in 20 ms Trying "osff.map.fastly.net" ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 9249 ;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 ;; QUESTION SECTION: ;osff.map.fastly.net. IN MX Received 37 bytes from 127.0.0.53#53 in 20 ms LANG=en wget -d https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa… DEBUG output created by Wget 1.21 on linux-gnu. Reading HSTS entries from /home/indri/.wget-hsts URI encoding = 'ANSI_X3.4-1968' converted 'https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa…' (ANSI_X3.4-1968) -> 'https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa…' (UTF-8) Converted file name 'Packages' (UTF-8) -> 'Packages' (ANSI_X3.4-1968) --2021-10-27 10:33:04-- https://dl.winehq.org/wine-builds/ubuntu/dists/impish/main/binary-all/Packa… Resolving dl.winehq.org (dl.winehq.org) 151.101.74.217 Caching dl.winehq.org => 151.101.74.217 Connecting to dl.winehq.org (dl.winehq.org)|151.101.74.217|:443... connected. Created socket 3. Releasing 0x00005562fd608aa0 (new refcount 1). Initiating SSL handshake. Handshake successful; connected socket 3 to SSL handle 0x00005562fd609880 certificate: subject: CN=*.winehq.org issuer: CN=GlobalSign Atlas R3 DV TLS CA 2020,O=GlobalSign nv-sa,C=BE X509 certificate successfully verified and matches host dl.winehq.org ---request begin--- GET /wine-builds/ubuntu/dists/impish/main/binary-all/Packages HTTP/1.1 User-Agent: Wget/1.21 Accept: */* Accept-Encoding: identity Host: dl.winehq.org Connection: Keep-Alive ---request end--- HTTP request sent, awaiting response... ---response begin--- HTTP/1.1 200 OK Connection: keep-alive Content-Length: 1758 Server: Apache Strict-Transport-Security: max-age=31536000 Cache-Control: max-age=604800 Last-Modified: Mon, 25 Oct 2021 12:12:48 GMT ETag: "6de-5cf2c477b5c33" Access-Control-Allow-Origin: * Via: 1.1 varnish, 1.1 varnish Fastly-Debug-Digest: 71bd9e11bef6b16fa199d390a7364dfd70068eba5cc79f273515095069aaf4ec Accept-Ranges: bytes Date: Wed, 27 Oct 2021 01:33:05 GMT Age: 132197 X-Served-By: cache-ord1731-ORD, cache-nrt18338-NRT X-Cache: HIT, HIT X-Cache-Hits: 2, 1 X-Timer: S1635298386.670273,VS0,VE0 ---response end--- 200 OK Registered socket 3 for persistent reuse. Parsed Strict-Transport-Security max-age = 31536000, includeSubDomains = false Updated HSTS host: dl.winehq.org:443 (max-age: 31536000, includeSubdomains: false) Length: 1758 (1.7K) Saving to: 'Packages' Packages 100%[================================================================================================================>] 1.72K --.-KB/s in 0s 2021-10-27 10:33:04 (31.8 MB/s) - 'Packages' saved [1758/1758] Saving HSTS entries to /home/indri/.wget-hsts -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 51849] New: Debian packaging: When building debian packages, HARDENING flags will be passed to cross-compiler
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=51849 Bug ID: 51849 Summary: Debian packaging: When building debian packages, HARDENING flags will be passed to cross-compiler Product: Packaging Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: wine-packages Assignee: wine-bugs(a)winehq.org Reporter: cybermax(a)dexter.no CC: dimesio(a)earthlink.net Distribution: --- When packages are built on debian, the default "hardening" flags will be passed to wine/configure. The result from this is that wine/configure tries to do checks for cross-compiler (mingw-w64) with flags meant to be used for ELF binaries. The flags are -Wl,-z,relro This causes configure to fail several checks for cross-compiler. The logs from WineHQ official OBS builds here for Debian 11: https://build.opensuse.org/public/build/Emulators:Wine:Debian/Debian_11/x86… Failing these checks will cause mingw-w64 to create loads of warnings like: [ 1042s] In file included from dlls/cabinet/fdi.c:72: [ 1042s] dlls/cabinet/fdi.c: In function 'FDI_read_string': [ 1042s] dlls/cabinet/fdi.c:485:9: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'INT_PTR' {aka 'long long int'} [-Wformat=] [ 1042s] 485 | TRACE("(fdi == %p, hf == %ld, cabsize == %ld)\n", fdi, hf, cabsize); [ 1042s] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~ [ 1042s] | | [ 1042s] | INT_PTR {aka long long int} If you however build without passing -Wl,-z,relro to mingw-w64, configure will pass a lot more tests, and the compile is quite a lot less noisy: https://build.opensuse.org/build/home:SveSop/Debian_11/x86_64/wine-devel/_l… Is there a possibility to avoid passing this flag to the cross-compiler in wine/configure? From what i gather, the -Wl,-z,relro flag is meant for ELF binaries, but afaik wine mostly (if not only) uses mingw-w64 to build PE libs, and thus these flags fail. You can add export DEB_LDFLAGS_MAINT_STRIP = -Wl,-z,relro to debian/rules, but that ofc means the ELF binaries built by gcc will not get these hardening flags. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 50891] New: Fedora 33 repository missing wine-*-common x86_64 packages
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=50891 Bug ID: 50891 Summary: Fedora 33 repository missing wine-*-common x86_64 packages Product: Packaging Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: critical Priority: P2 Component: wine-packages Assignee: wine-bugs(a)winehq.org Reporter: blacknova(a)tut.by CC: dimesio(a)earthlink.net Distribution: --- After recent update of Fedora repository, all x64_64 versions of wine-*-common packages are missing. DNF upgrade command complain on broken dependencies: Problem 1: cannot install the best update candidate for package wine-staging64-1:6.4-1.1.x86_64 - nothing provides wine-staging-common = 1:6.5-1.2 needed by wine-staging64-1:6.5-1.2.x86_64 Problem 2: package winehq-staging-1:6.5-1.2.x86_64 requires wine-staging64 = 1:6.5-1.2, but none of the providers can be installed - cannot install the best update candidate for package winehq-staging-1:6.4-1.1.x86_64 - nothing provides wine-staging-common = 1:6.5-1.2 needed by wine-staging64-1:6.5-1.2.x86_64 Problem 3: problem with installed package wine-staging64-1:6.4-1.1.x86_64 - package wine-staging64-1:6.4-1.1.x86_64 requires wine-staging-common = 1:6.4-1.1, but none of the providers can be installed - cannot install both wine-staging-common-1:6.5-2.1.i686 and wine-staging-common-1:6.4-1.1.i686 - cannot install the best update candidate for package wine-staging-common-1:6.4-1.1.i686 - nothing provides wine-staging-common = 1:6.5-1.2 needed by wine-staging64-1:6.5-1.2.x86_64 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 51354] New: WRC 7 needs ID3DUserDefinedAnnotation interface
by WineHQ Bugzilla 10 Apr '22

10 Apr '22

https://bugs.winehq.org/show_bug.cgi?id=51354 Bug ID: 51354 Summary: WRC 7 needs ID3DUserDefinedAnnotation interface Product: Wine Version: 6.11 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: andrey.goosev(a)gmail.com Distribution: --- Shows WRC 7 window and immediately closes. 0110:trace:d3d11:d3d11_device_context_QueryInterface iface 00000000001E31E8, iid {b2daad8b-03d4-4dbf-95eb-32ab4b63d0ab}, out 00000000026DA770. 0110:warn:d3d11:d3d11_device_context_QueryInterface {b2daad8b-03d4-4dbf-95eb-32ab4b63d0ab} not implemented, returning E_NOINTERFACE. wine-6.11-158-g542175ab104 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 7