August 2022 - Wine-bugs - list.winehq.org

[Bug 47922] New: Speech synthesis does not start in Logos Bible Software
by WineHQ Bugzilla 22 Aug '22

22 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=47922 Bug ID: 47922 Summary: Speech synthesis does not start in Logos Bible Software Product: Wine Version: 4.17 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: sapi Assignee: wine-bugs(a)winehq.org Reporter: johnpgoodman(a)gmail.com Distribution: --- Logos Bible Software will read audio using sapi from almost any of the books except those published by Zondervan. Using wine starting speech causes a crash. Installing sapi there is no long a crash but there is no audio. 0040:fixme:path:parse_url failed to parse L"System.Speech" 0040:fixme:wtsapi:WTSUnRegisterSessionNotification Stub 00030084 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 32

[Bug 53584] New: Multiple Defold games do not start
by WineHQ Bugzilla 22 Aug '22

22 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=53584 Bug ID: 53584 Summary: Multiple Defold games do not start Product: Wine Version: 7.15 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: cweiske(a)cweiske.de Distribution: --- Created attachment 72967 --> https://bugs.winehq.org/attachment.cgi?id=72967 log for Craftomation 101 Games built with the Defold game engine (https://defold.com/) do not start. They give an exit code 1. Known freely downloadable games that do not run: - Exolon: REDUX - https://benjames171.itch.io/exolon-redux - Craftomation 101 - https://ludenio.itch.io/craftomation101 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 29614] New: WinRAR viewer crashes on a particular file
by wine-bugs＠winehq.org 22 Aug '22

22 Aug '22

http://bugs.winehq.org/show_bug.cgi?id=29614 Bug #: 29614 Summary: WinRAR viewer crashes on a particular file Product: Wine Version: 1.3.37 Platform: x86 URL: http://www.rarlabs.com/rar/wrar401.exe OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: richedit AssignedTo: wine-bugs(a)winehq.org ReportedBy: t.artem(a)mailcity.com Classification: Unclassified Created attachment 38365 --> http://bugs.winehq.org/attachment.cgi?id=38365 Test file When trying to view the attached file, WinRAR crashes. Steps to reproduce, download the file, install and run WinRAR, click Commands -> View File (Alt + V). (Viewer settings: view as Windows text, word wrap enabled). caret.c:208: ME_GetCursorCoordinates: Assertion `~para->member.para.nFlags & 0x01' failed. wine: Assertion failed at address 0xb776f424 (thread 0046), starting debugger... Unhandled exception: assertion failed in 32-bit code (0xb776f424). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:b776f424 ESP:00322904 EBP:0032291c EFLAGS:00000202( - -- I - - - ) EAX:00000000 EBX:00006589 ECX:00006589 EDX:00000006 ESI:b758b74a EDI:b75c7ff4 Stack dump: 0x00322904: 0032291c 00000006 00006589 b746d2f1 0x00322914: b75c7ff4 00322a3c 00322a44 b746ed5e 0x00322924: 00000006 003229bc 00000000 b75c7ff4 0x00322934: 00000060 00000001 00322a54 00322980 0x00322944: 00000000 00000068 0000005c b75c93a0 0x00322954: b75c7ff4 0000005c 0000005b 00322a2c Backtrace: =>0 0xb776f424 __kernel_vsyscall+0x10() in [vdso].so (0x0032291c) 1 0xb746d2f1 gsignal+0x50() in libc.so.6 (0x0032291c) 2 0xb746ed5e abort+0x17d() in libc.so.6 (0x00322a44) 3 0xb7465c08 __assert_fail+0xf7() in libc.so.6 (0x00322a8c) 4 0x7dbc5657 ME_MoveCaret+0x496() in riched20 (0x00322b5c) 5 0x7dbd79c2 ME_PaintContent+0xc1() in riched20 (0x00322c0c) 6 0x7dbd399d RichEditWndProc_common+0x3bc() in riched20 (0x00322ccc) 7 0x7dbd3ccc RichEditWndProcW+0x2b() in riched20 (0x00322cfc) 8 0x7ec2b4ea WINPROC_wrapper+0x19() in user32 (0x00322d2c) 9 0x7ec2bc3c call_window_proc+0x5b() in user32 (0x00322d7c) 10 0x7ec2e10d WINPROC_call_window+0x10c() in user32 (0x00322dcc) 11 0x7ebf0b0e DispatchMessageW+0x9d() in user32 (0x00322ebc) 12 0x0049aa76 in winrar (+0x9aa75) (0x00328308) 13 0x7dbcf53b ME_HandleMessage+0xcba() in riched20 (0x00328c48) 14 0x7dbd3764 RichEditWndProc_common+0x183() in riched20 (0x00328d08) 15 0x7dbd3ccc RichEditWndProcW+0x2b() in riched20 (0x00328d38) 16 0x7ec2b4ea WINPROC_wrapper+0x19() in user32 (0x00328d68) 17 0x7ec2bc3c call_window_proc+0x5b() in user32 (0x00328db8) 18 0x7ec2e10d WINPROC_call_window+0x10c() in user32 (0x00328e08) 19 0x7ebeec61 call_window_proc+0x90() in user32 (0x00328e78) 20 0x7ebf5456 send_message+0x205() in user32 (0x00328ef8) 21 0x7ebf58cc SendMessageW+0x4b() in user32 (0x00328f48) 22 0x0049dbf5 in winrar (+0x9dbf4) (0x7ebf5880) 23 0x458b48ec (0x83e58955) 0xb776f424 __kernel_vsyscall+0x10 in [vdso].so: popl %ebp Modules: ... Backtrace: =>0 0xb776f424 __kernel_vsyscall+0x10() in [vdso].so (0x0032291c) 1 0xb746d2f1 gsignal+0x50() in libc.so.6 (0x0032291c) 2 0xb746ed5e abort+0x17d() in libc.so.6 (0x00322a44) 3 0xb7465c08 __assert_fail+0xf7() in libc.so.6 (0x00322a8c) 4 0x7dbc5657 ME_MoveCaret+0x496() in riched20 (0x00322b5c) 5 0x7dbd79c2 ME_PaintContent+0xc1() in riched20 (0x00322c0c) 6 0x7dbd399d RichEditWndProc_common+0x3bc() in riched20 (0x00322ccc) 7 0x7dbd3ccc RichEditWndProcW+0x2b() in riched20 (0x00322cfc) 8 0x7ec2b4ea WINPROC_wrapper+0x19() in user32 (0x00322d2c) 9 0x7ec2bc3c call_window_proc+0x5b() in user32 (0x00322d7c) 10 0x7ec2e10d WINPROC_call_window+0x10c() in user32 (0x00322dcc) 11 0x7ebf0b0e DispatchMessageW+0x9d() in user32 (0x00322ebc) 12 0x0049aa76 in winrar (+0x9aa75) (0x00328308) 13 0x7dbcf53b ME_HandleMessage+0xcba() in riched20 (0x00328c48) 14 0x7dbd3764 RichEditWndProc_common+0x183() in riched20 (0x00328d08) 15 0x7dbd3ccc RichEditWndProcW+0x2b() in riched20 (0x00328d38) 16 0x7ec2b4ea WINPROC_wrapper+0x19() in user32 (0x00328d68) 17 0x7ec2bc3c call_window_proc+0x5b() in user32 (0x00328db8) 18 0x7ec2e10d WINPROC_call_window+0x10c() in user32 (0x00328e08) 19 0x7ebeec61 call_window_proc+0x90() in user32 (0x00328e78) 20 0x7ebf5456 send_message+0x205() in user32 (0x00328ef8) 21 0x7ebf58cc SendMessageW+0x4b() in user32 (0x00328f48) 22 0x0049dbf5 in winrar (+0x9dbf4) (0x7ebf5880) 23 0x458b48ec (0x83e58955) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

2 32

[Bug 37873] New: Pokemon TCGO version 4.5.5 crashes during startup
by wine-bugs＠winehq.org 21 Aug '22

21 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=37873 Bug ID: 37873 Summary: Pokemon TCGO version 4.5.5 crashes during startup Product: Wine Version: 1.7.3 Hardware: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: lppoulin(a)gmail.com Distribution: --- Pokemon TCGO version 4.X.X used to work perfectly. In December 2014, after an auto-update to version 4.5.5 it started to crash at startup. Has anyone been able to make it work? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2 13

[Bug 47837] New: Intrusive graphics glitches .NET app - Logos Bible Software
by WineHQ Bugzilla 21 Aug '22

21 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=47837 Bug ID: 47837 Summary: Intrusive graphics glitches .NET app - Logos Bible Software Product: Wine Version: 4.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: johnpgoodman(a)gmail.com Distribution: --- It appears as if parts of the graphics buffer that are no longer needed get drawn back onto the screen quite a lot. You start viewing a different book. Suddenly you are looking at the previous one. Then it comes back. WINEPREFIX=/home/john/wine-logos64/ WINEDEBUG=+wgl wine64 c\:'/users/john/Local Settings/Application Data/Logos/Logos.exe' LC_ALL=C &>wine.log Attached is a log file after running with the above command. I wonder if it is to do with graphics drivers and config? Perhaps someone knowledgable can suggest a workaround or config that will fix this? It makes the app very hard to use. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 53576] New: Tony Hawk's Pro Skater 1+2 : Graphics too dark
by WineHQ Bugzilla 20 Aug '22

20 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=53576 Bug ID: 53576 Summary: Tony Hawk's Pro Skater 1+2 : Graphics too dark Product: Wine Version: 7.15 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: blue-t(a)web.de Distribution: --- When i try to play this game without additional graphic translation layers, you can barely see anything in the game. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 53196] New: foobar2000: Crashes randomly when opening items in menu bar while playing audio
by WineHQ Bugzilla 20 Aug '22

20 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=53196 Bug ID: 53196 Summary: foobar2000: Crashes randomly when opening items in menu bar while playing audio Product: Wine Version: 7.11 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: plaindonkeys14(a)gmail.com Distribution: --- Created attachment 72630 --> https://bugs.winehq.org/attachment.cgi?id=72630 Terminal output from start to crash While I am playing audio, foobar2000 can randomly and frequently crash if I try to use items in the menu bar by using the mouse. I have tested MP3s and MIDIs. When it crashes, the desktop freezes for a bit and then an error with ntdll shows up in the terminal output. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 48988] New: Riot Vanguard (Riot Games) 'vgk.sys' needs KSHARED_USER_DATA access instruction emulation for 'CMP r/m16/32/64, r16/32/64'
by WineHQ Bugzilla 20 Aug '22

20 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=48988 Bug ID: 48988 Summary: Riot Vanguard (Riot Games) 'vgk.sys' needs KSHARED_USER_DATA access instruction emulation for 'CMP r/m16/32/64, r16/32/64' Product: Wine Version: 5.6 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ntoskrnl Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, as it says. Wine's instruction emulation for KSHARED_USER_DATA handles most of the 'MOV' (copy) instruction flavours but no 'CMP r/m16/32/64, r16/32/64' cases. --- snip --- ... 002f:Call ntdll.NtFlushBuffersFile(00000044,00d4f2e0) ret=7bca1f9f 002f: flush( async={handle=0044,event=0000,iosb=00d4f2e0,user=00728c00,apc=00000000,apc_context=00000000} ) 002f: flush() = 0 { event=0048 } 002f: select( flags=2, cookie=00d4e5cc, timeout=infinite, size=8, prev_apc=0000, result={}, data={WAIT_ALL,handles={0048}}, context={} ) 002f: select() = 0 { call={APC_NONE}, apc_handle=0000, context={} } 002f:Ret ntdll.NtFlushBuffersFile() retval=00000000 ret=7bca1f9f 002f:Ret ntoskrnl.exe.ZwFlushBuffersFile() retval=00000000 ret=0115f5ac 002f:Call ntoskrnl.exe.ExFreePoolWithTag(008a0bc0,656e6f4e) ret=0115fd31 002f:trace:ntoskrnl:ExFreePoolWithTag 00000000008A0BC0 002f:Call KERNEL32.HeapFree(008a0000,00000000,008a0bc0) ret=7bca1f9f 002f:Ret KERNEL32.HeapFree() retval=00000001 ret=7bca1f9f 002f:Ret ntoskrnl.exe.ExFreePoolWithTag() retval=00000001 ret=0115fd31 002f:Call ntoskrnl.exe.ExFreePoolWithTag(008a0b40,656e6f4e) ret=00e73ad4 002f:trace:ntoskrnl:ExFreePoolWithTag 00000000008A0B40 002f:Call KERNEL32.HeapFree(008a0000,00000000,008a0b40) ret=7bca1f9f 002f:Ret KERNEL32.HeapFree() retval=00000001 ret=7bca1f9f 002f:Ret ntoskrnl.exe.ExFreePoolWithTag() retval=00000001 ret=00e73ad4 002f:Call ntoskrnl.exe.ExFreePoolWithTag(008a0330,656e6f4e) ret=00e73ad4 002f:trace:ntoskrnl:ExFreePoolWithTag 00000000008A0330 002f:Call KERNEL32.HeapFree(008a0000,00000000,008a0330) ret=7bca1f9f 002f:Ret KERNEL32.HeapFree() retval=00000001 ret=7bca1f9f 002f:Ret ntoskrnl.exe.ExFreePoolWithTag() retval=00000001 ret=00e73ad4 002f:trace:seh:raise_exception code=c0000005 flags=0 addr=0x115cbbd ip=115cbbd tid=002f 002f:trace:seh:raise_exception info[0]=0000000000000000 002f:trace:seh:raise_exception info[1]=fffff7800000026c 002f:trace:seh:raise_exception rax=0000000001000001 rbx=0000000000728bb8 rcx=0000000000000000 rdx=0000000000000048 002f:trace:seh:raise_exception rsi=0000000000d4f7bc rdi=0000000000728bb8 rbp=0000000000727788 rsp=0000000000d4f6a0 002f:trace:seh:raise_exception r8=0000000000000000 r9=0000000000d4ec12 r10=0000000000000000 r11=0000000000000000 002f:trace:seh:raise_exception r12=0000000000728a50 r13=00007fffffea4000 r14=0000000000728bb8 r15=0000000000000000 002f:trace:seh:call_vectored_handlers calling handler at 0x18000b9c0 code=c0000005 flags=0 002f:Call KERNEL32.GetTickCount64() ret=18000bccc 002f:Ret KERNEL32.GetTickCount64() retval=01920417 ret=18000bccc 002f:Call msvcrt.memcpy(00d4f108,7ffe026c,00000004) ret=18000bcf8 002f:Ret msvcrt.memcpy() retval=00d4f108 ret=18000bcf8 002f:trace:seh:call_vectored_handlers handler at 0x18000b9c0 returned ffffffff 002f:trace:seh:raise_exception code=c0000005 flags=0 addr=0x115cbff ip=115cbff tid=002f 002f:trace:seh:raise_exception info[0]=0000000000000000 002f:trace:seh:raise_exception info[1]=fffff78000000270 002f:trace:seh:raise_exception rax=0000000000000001 rbx=0000000000728bb8 rcx=0000000000000006 rdx=fffff78000000270 002f:trace:seh:raise_exception rsi=0000000000d4f7bc rdi=0000000000728bb8 rbp=0000000000727788 rsp=0000000000d4f6a0 002f:trace:seh:raise_exception r8=0000000000000000 r9=0000000000d4ec12 r10=0000000000000000 r11=0000000000000000 002f:trace:seh:raise_exception r12=0000000000728a50 r13=00007fffffea4000 r14=0000000000728bb8 r15=0000000000000000 002f:trace:seh:call_vectored_handlers calling handler at 0x18000b9c0 code=c0000005 flags=0 002f:trace:seh:call_vectored_handlers handler at 0x18000b9c0 returned 0 --- snip --- The driver code is obfuscated but that doesn't prevent analysis/debugging ;-) Relevant part of driver disassembly: --- snip --- ... 01402ECBAF | 8D82 5A4A900F | lea eax,qword ptr ds:[rdx+F904A5A] 01402ECBB5 | C0ED D2 | shr ch,D2 01402ECBB8 | ED | in eax,dx 01402ECBB9 | 44:0FABF0 | bts eax,r14d 01402ECBBD | A1 6C02000080F7FFFF | mov eax,dword ptr ds:[FFFFF7800000026C] 01402ECBC6 | 40:22CF | and cl,dil 01402ECBC9 | 66:D3F9 | sar cx,cl 01402ECBCC | 8BC8 | mov ecx,eax 01402ECBCE | 66:C1E0 26 | shl ax,26 01402ECBD2 | 66:0FC1C0 | xadd ax,ax 01402ECBD6 | B8 01000000 | mov eax,1 01402ECBDB | 45:84D2 | test r10b,r10b 01402ECBDE | 66:81FF 905B | cmp di,5B90 01402ECBE3 | 83F9 06 | cmp ecx,6 01402ECBE6 | E9 00000000 | jmp vgk.1402ECBEB 01402ECBEB | 0F82 1B000000 | jb vgk.1402ECC0C 01402ECBF1 | 48:BA 7002000080F7FFFF | mov rdx,FFFFF78000000270 01402ECBFB | 80FB 2E | cmp bl,2E 01402ECBFE | F5 | cmc 01402ECBFF | 3902 | cmp dword ptr ds:[rdx],eax ; problem 01402ECC01 | E9 00000000 | jmp vgk.1402ECC06 01402ECC06 | 0F83 17000000 | jae vgk.1402ECC23 01402ECC0C | 83F9 0A | cmp ecx,A 01402ECC0F | E9 00000000 | jmp vgk.1402ECC14 01402ECC14 | 0F83 09000000 | jae vgk.1402ECC23 01402ECC1A | 2AC0 | sub al,al 01402ECC1C | 45:3AE3 | cmp r12b,r11b 01402ECC1F | 41:80F9 65 | cmp r9b,65 01402ECC23 | 48:83C4 28 | add rsp,28 01402ECC27 | E9 00000000 | jmp vgk.1402ECC2C 01402ECC2C | C3 | ret ... --- snip --- 'cmp dword ptr ds:[rdx],eax' -> 0x39,0x02 The driver checks 'KSHARED_USER_DATA' 'NtMajorVersion' and 'NtMinorVersion' fields if the OS is supported. (http://www.geoffchappell.com/studies/windows/km/ntoskrnl/structs/kuser_shar…) In case it encounters something below 'Windows 7', the driver entry point will return code 0xC000A004 which translates to 'STATUS_INVALID_KERNEL_INFO_VERSION'. Wine source: https://source.winehq.org/git/wine.git/blob/f31a29b8d1ea478af28f14cdaf3db15… $ sha1sum setup.exe 08deca4c0b46a3481e706926c0217d1c944d22a3 setup.exe $ du -sh setup.exe 15M setup.exe $ wine --version wine-5.6-258-gf31a29b8d1 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 53572] New: Misbehaving system tray icons on Wayland session
by WineHQ Bugzilla 18 Aug '22

18 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=53572 Bug ID: 53572 Summary: Misbehaving system tray icons on Wayland session Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: ryu.ketsueki(a)outlook.com Distribution: --- This is a bit more complex to explain, as this happens more specifically if you are on a Wayland session desktop. May be a duplicate of 48550 but I decided to drop more of what I could find out. Previously this was reported on KDE's Bugzilla as well and currently there may not be an easy fix on Plasma's side for a number of reasons. First, it may be using a deprecated proxy, XEmbedSNIProxy, which may be supported in X11 in a "very hacky way" as described in the bug report and it is completely unsupported in Wayland. Other apps also have this issue, like Anydesk, but Wine may be used for a lot more so it is more common to see those around. What happens is that, while the icon may appear on the tray, the "interactible" part of the icon is usually on the top left corner of the screen. And if there are many tray icons, only one can be interacted with. The icon itself on the tray is completely static and cannot be interacted with. Gnome does not have a system tray by default, requiring the user to install one through extensions. Every other desktop environment, however, does have a native system tray. Currently, KDE Plasma in the Wayland session is where this issue can be replicated, although I imagine other Wayland implementations such as Sway may also work. There is a known workaround but it is not perfect. Essentially involves terminating the XEmbedSNIProxy process and bringing the tray icons from there into a window with the wmsystemtray command. It is very hacky and far from ideal. If something can be done on Wine's side to try sorting this out, it would greatly improve its usability on Wayland, even without a native Wayland driver. Perhaps a new proxy that works both on X11 and Wayland can replace this old one? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 51098] New: Native Access fails to download files since Wine 6.6
by WineHQ Bugzilla 18 Aug '22

18 Aug '22

https://bugs.winehq.org/show_bug.cgi?id=51098 Bug ID: 51098 Summary: Native Access fails to download files since Wine 6.6 Product: Wine Version: 6.6 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: mail(a)robbertvanderhelm.nl Distribution: --- Created attachment 69961 --> https://bugs.winehq.org/attachment.cgi?id=69961 Wine output on Wine 6.6 Starting at Wine 6.6, Native Instrument's Native Access software downloader (https://www.native-instruments.com/en/specials/native-access/) fails to download any files. When starting a download, the progress bar will immediately jump from 0% to failed. In Wine 6.5 and below the file gets downloaded to the Downloads directory successfully (actually installing the files doesn't work as per bug 50226, but you used to be able to at least manually mount and install the downloaded .iso files). I've attached logs for Wine 6.5 (where the download goes through successfully) and Wine 6.6 (where it does now), but without changing WINEDEBUG there doesn't seem to be anything interesting in there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 5