January 2023 - Wine-bugs - list.winehq.org

[Bug 43040] New: steam version of Left 4 Dead 2 v2.1.4.7 prevents connection to server with a 'client timed out' error
by wine-bugs＠winehq.org 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=43040 Bug ID: 43040 Summary: steam version of Left 4 Dead 2 v2.1.4.7 prevents connection to server with a 'client timed out' error Product: Wine Version: 2.7 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: manoa(a)manoa.flnet.org Distribution: --- the bug occurs usually on the second attempt to connect to a server in addition, once the error occurs it will persist, even after steam is restarted if not trying to connect to a server for a couple of minutes it may allow connection, but if that connection fails, the next connection will have the error -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2 3

[Bug 37158] New: Left 4 Dead pressing tab crashes the game
by wine-bugs＠winehq.org 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=37158 Bug ID: 37158 Summary: Left 4 Dead pressing tab crashes the game Product: Wine Version: 1.6.2 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: nothingmuchheretosay(a)gmail.com Pressing tab in a game, whether in Single or Multiplayer mode, the game will crash. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

2 11

[Bug 23832] New: Mass Effect 2 stutter on initial rotation after awakening
by wine-bugs＠winehq.org 20 Apr '23

20 Apr '23

http://bugs.winehq.org/show_bug.cgi?id=23832 Summary: Mass Effect 2 stutter on initial rotation after awakening Product: Wine Version: 1.2 Platform: x86 URL: http://masseffect.bioware.com/cdn/A/ME2_DEMO/MassEffec t2DemoEN.exe OS/Version: Linux Status: NEW Keywords: download Severity: normal Priority: P2 Component: directx-d3dx9 AssignedTo: wine-bugs(a)winehq.org ReportedBy: dank(a)kegel.com CC: wine-bugs(a)winehq.org Using the saved game from bug 23684, restart the mission; when you start waking up, press escape twice to skip the movies. Now sweep the mouse to rotate yourself to look around. On Windows, this is very smooth. On Wine, there is a noticeable amount of stuttering. The problem stops as soon as you've looked at enough of the room to have it in cache, or something like that. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

2 12

[Bug 53441] New: Origin Mass Effect Legendary Edition crashes with errors
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=53441 Bug ID: 53441 Summary: Origin Mass Effect Legendary Edition crashes with errors Product: Wine Version: 7.13 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: major Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: xraphael75(a)protonmail.com Distribution: --- Created attachment 72818 --> https://bugs.winehq.org/attachment.cgi?id=72818 debug backtrace generated by wine I installed EA Origin through Lutris. When I open Origin, I see all my games. I installed Mass Effect Legendary Edition. But when I click the button to start it, I get a bunch of errors. I have attached the debug info file that wine created. I'm not sure what these errors mean or what to do. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 53713] New: Persona 4 Golden crashes on video playback in decodebin_parser_create+0x3f
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=53713 Bug ID: 53713 Summary: Persona 4 Golden crashes on video playback in decodebin_parser_create+0x3f Product: Wine Version: 7.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winegstreamer Assignee: wine-bugs(a)winehq.org Reporter: hibbsncc1701(a)gmail.com Distribution: --- Created attachment 73142 --> https://bugs.winehq.org/attachment.cgi?id=73142 Backtrace of crash. Persona 4 Golden now crashes on startup attempting to play the opening FMV, whereas it worked fine in wine-7.13. Backtrace attached. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 49465] New: I cannot install Windows Media Player
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=49465 Bug ID: 49465 Summary: I cannot install Windows Media Player Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: winnipuh00(a)gmail.com Distribution: --- Created attachment 67571 --> https://bugs.winehq.org/attachment.cgi?id=67571 error log FOr some reason i cannot install windows media player. pls help. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 50390] New: Resident Evil 5 Gradually fades to black if csmt is disabled.
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=50390 Bug ID: 50390 Summary: Resident Evil 5 Gradually fades to black if csmt is disabled. Product: Wine Version: 6.0-rc3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: BOBBLOG(a)protonmail.com Distribution: --- Created attachment 69002 --> https://bugs.winehq.org/attachment.cgi?id=69002 RE5-Gradual-Blackout.jpg Resident Evil 5 Gradually fades to black if csmt is disabled in chapter 4-1 just after open door to the ancient city. This was tested in a wine prefix with only wmp11 install by winetricks because the game will not boot without wmp11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 53072] New: After installing WMP11, mfplat is suddenly unavailable
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=53072 Bug ID: 53072 Summary: After installing WMP11, mfplat is suddenly unavailable Product: Wine Version: 7.9 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: gab.pulcio(a)gmail.com Distribution: --- Steps to reproduce: -winetricks wmp11 -open something that requires mfplat -the program fails to load the dlls "dll not found" -winetricks mf -still "dll not found" Steps to fix: -winecfg -library -> delete all WMP and MF custom rules -wineboot -u -WMP is still installed and everything now will work This is a paradox in my opinion -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 51794] New: Implement wineclang - a wrapper around clang to build software with winelib
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=51794 Bug ID: 51794 Summary: Implement wineclang - a wrapper around clang to build software with winelib Product: Wine Version: 6.17 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winelib Assignee: wine-bugs(a)winehq.org Reporter: kolan_n(a)mail.ru Distribution: --- A user should be able to configure which stock clang (i.e. one default in the distro, or the latest one from the official repos) and which MinGW target and which sysroot to use. I.e. if I have a CMake toolchain file for cross-compilation for Windows 64-bit with clang-14 using MinGW-w64 stdlib installed from Ubuntu packages, then I should be able to just slightly modify it in order to get native compilation via wine-gcc the following way: 1. replace clang compilers with wineclang 2. provide wineclang with arguments pointing to real clang binaries I want to use. Probably it should be unified with winegcc/wineg++ and renamed into winecompiler, which should be symlinked to winegcc/wineg++/wineclang/wineclang++. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 49254] New: Firefox 76.0 for win64-aarch64 crashes on startup (unwinding for "set thread name" MSVC exception 0x406D1388 fails)
by WineHQ Bugzilla 20 Apr '23

20 Apr '23

https://bugs.winehq.org/show_bug.cgi?id=49254 Bug ID: 49254 Summary: Firefox 76.0 for win64-aarch64 crashes on startup (unwinding for "set thread name" MSVC exception 0x406D1388 fails) Product: Wine Version: 5.9 Hardware: aarch64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: focht(a)gmx.net Distribution: --- Hello folks, as it says. Download: https://web.archive.org/web/20200526201306/https://archive.mozilla.org/pub/… --- snip --- $ WINEDEBUG=+seh,+relay,+ntdll,+module wine64 ./firefox.exe >>log.txt 2>&1 ... 00f8:Starting thread proc 0x4c6ceb0 (arg=0x12e1d100) 00f8:Call ntdll.RtlAcquireSRWLockExclusive(12e1d110) ret=04c6ced4 00f8:Ret ntdll.RtlAcquireSRWLockExclusive() retval=12e1d110 ret=04c6ced4 00f8:Call ntdll.RtlReleaseSRWLockExclusive(12e1d110) ret=04c6cee4 00f8:Ret ntdll.RtlReleaseSRWLockExclusive() retval=12e1d110 ret=04c6cee4 00f8:Call ntdll.NtCurrentTeb() ret=7fbe306220 00f8:Ret ntdll.NtCurrentTeb() retval=7ff9c000 ret=7fbe306220 00f8:Call KERNEL32.RaiseException(406d1388,00000000,00000003,14ebfe08) ret=04bb70f4 00f8:Call kernelbase.RaiseException(406d1388,00000000,00000003,14ebfe08) ret=7fbea40780 00f8:Call ntdll.memcpy(14ebfc38,14ebfe08,00000018) ret=7fbe21bc40 00f8:Ret ntdll.memcpy() retval=14ebfc38 ret=7fbe21bc40 00f8:trace:seh:raise_exception code=406d1388 flags=0 addr=0x7fbea55ff8 pc=7fbea55ff8 tid=00f8 00f8:trace:seh:raise_exception info[0]=0000000000001000 00f8:trace:seh:raise_exception info[1]=0000000007011630 00f8:trace:seh:raise_exception info[2]=00000000000000f8 00f8:trace:seh:raise_exception x0=ffffff80ffffffc8 x1=0000000000000002 x2=0000000000000000 x3=0000000000000000 00f8:trace:seh:raise_exception x4=0000000014edf2e8 x5=0000000014edf0e0 x6=0000000014edf0e0 x7=70636d656d2e6c6c 00f8:trace:seh:raise_exception x8=0000000000000000 x9=0000007fbea55fdc x10=3d6c617674657220 x11=3833636662653431 00f8:trace:seh:raise_exception x12=6266373d74657220 x13=0a30346362313265 x14=0000000000000032 x15=0000000000000000 00f8:trace:seh:raise_exception x16=0000007fbeaed0f0 x17=0000007fbec7f978 x18=000000007ff9c000 x19=0000000014ebfc18 00f8:trace:seh:raise_exception x20=0000000014ebfd40 x21=0000000000220367 x22=0000007fbe2a92c0 x23=0000000000000000 00f8:trace:seh:raise_exception x24=0000000000000000 x25=0000000000000000 x26=0000000000000000 x27=0000000000000000 00f8:trace:seh:raise_exception x28=0000000000000000 fp=0000000014ebfc00 lr=0000007fbea55ff8 sp=0000000014ebfc10 00f8:trace:seh:call_vectored_handlers calling handler at 0x59c24e0 code=406d1388 flags=0 00f8:trace:seh:call_vectored_handlers handler at 0x59c24e0 returned 0 00f8:trace:seh:libunwind_virtual_unwind ip 0x7fbea55ff8 function 0x7fbea55fdc-0x7fbea56024 personality 0 lsda 0 fde 0 00f8:trace:seh:libunwind_virtual_unwind next function pc=0000007fbe21bc50 00f8:trace:seh:libunwind_virtual_unwind x0=ffffff80ffffffc8 x1=0000000000000002 x2=0000000000000000 x3=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x4=0000000014edf2e8 x5=0000000014edf0e0 x6=0000000014edf0e0 x7=70636d656d2e6c6c 00f8:trace:seh:libunwind_virtual_unwind x8=0000000000000000 x9=0000007fbea55fdc x10=3d6c617674657220 x11=3833636662653431 00f8:trace:seh:libunwind_virtual_unwind x12=6266373d74657220 x13=0a30346362313265 x14=0000000000000032 x15=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x16=0000007fbeaed0f0 x17=0000007fbec7f978 x18=000000007ff9c000 x19=0000000014ebfd40 00f8:trace:seh:libunwind_virtual_unwind x20=0000000014ebfd40 x21=0000000000220367 x22=0000007fbe2a92c0 x23=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x24=0000000000000000 x25=0000000000000000 x26=0000000000000000 x27=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x28=0000000000000000 fp=0000000014ebfcb0 lr=0000007fbe21bc50 sp=0000000014ebfc10 00f8:trace:seh:libunwind_virtual_unwind ip 0x7fbe21bc50 function 0x7fbe21bbf4-0x7fbe21bc5c personality 0 lsda 0 fde 0 00f8:trace:seh:libunwind_virtual_unwind next function pc=0000007fbea40780 00f8:trace:seh:libunwind_virtual_unwind x0=ffffff80ffffffc8 x1=0000000000000002 x2=0000000000000000 x3=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x4=0000000014edf2e8 x5=0000000014edf0e0 x6=0000000014edf0e0 x7=70636d656d2e6c6c 00f8:trace:seh:libunwind_virtual_unwind x8=0000000000000000 x9=0000007fbea55fdc x10=3d6c617674657220 x11=3833636662653431 00f8:trace:seh:libunwind_virtual_unwind x12=6266373d74657220 x13=0a30346362313265 x14=0000000000000032 x15=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x16=0000007fbeaed0f0 x17=0000007fbec7f978 x18=000000007ff9c000 x19=0000000014ebfd40 00f8:trace:seh:libunwind_virtual_unwind x20=0000000014ebfd40 x21=0000000000220367 x22=0000007fbe2a92c0 x23=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x24=0000000000000000 x25=0000000000000000 x26=0000000000000000 x27=0000000000000000 00f8:trace:seh:libunwind_virtual_unwind x28=0000000000000000 fp=0000000014ebfcc0 lr=0000007fbea40780 sp=0000000014ebfcc0 00f8:trace:seh:libunwind_virtual_unwind no info found for 7fbea40780 ip 7fbe21bbf4-7fbe21bc5c, assuming leaf function 00f8:trace:seh:libunwind_virtual_unwind no info found for 7fbea40780 ip 7fbe21bbf4-7fbe21bc5c, assuming leaf function ... 00f8:trace:seh:libunwind_virtual_unwind no info found for 7fbea40780 ip 7fbe21bbf4-7fbe21bc5c, assuming leaf function 00f8:trace:seh:call_function_handlers found wine frame 0x14ebfee0 rsp 14ebfee8 handler 0x7fbea70e40 00f8:trace:seh:call_teb_handler calling TEB handler 0x7fbea70e40 (rec=0x14ebfc18, frame=0x14ebfee0 context=0x14ebec40, dispatch=0x14ebeb00) 00f8:Call kernelbase.UnhandledExceptionFilter(14ebeac0) ret=7fbea13d78 00f8:Call ntdll.NtCurrentTeb() ret=7fbe21c04c 00f8:Ret ntdll.NtCurrentTeb() retval=7ff9c000 ret=7fbe21c04c 00f8:Call ntdll.RtlEnterCriticalSection(0766b490) ret=04a4a9e4 00f8:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=04a4a9e4 00f8:Call KERNEL32.SetUnhandledExceptionFilter(14003ec30) ret=04a3f89c 00f8:Call kernelbase.SetUnhandledExceptionFilter(14003ec30) ret=7fbea40780 00f8:Ret kernelbase.SetUnhandledExceptionFilter() retval=04a4a1b0 ret=7fbea40780 00f8:Ret KERNEL32.SetUnhandledExceptionFilter() retval=04a4a1b0 ret=04a3f89c 00f8:Call ucrtbase._set_invalid_parameter_handler(00000000) ret=04a4aa40 00f8:Ret ucrtbase._set_invalid_parameter_handler() retval=04a4a2e0 ret=04a4aa40 00f8:Call ucrtbase._set_purecall_handler(00000000) ret=04a4aa4c 00f8:Ret ucrtbase._set_purecall_handler() retval=04a4a490 ret=04a4aa4c --- snip --- The Firefox executable contains PE exception/unwind information. The problem seems rather with libunwind and builtins. Didn't look further yet tho. Wine was built with Clang C/C++ cross compiler, integrated with a custom/self-built Yocto/Poky distro for HiKey960 platform, producing traditional ELF executables (no llvm-mingw/PE). --- snip --- $ $CLANGCC -v clang version 7.0.0 (https://github.com/llvm-mirror/clang.git 0513b409d5e34b2d2a28ae21b6d620cc52de0e57) (https://github.com/llvm-mirror/llvm.git 65ce2e56889af84e8be8e311f484a4dfe4b62d7a) Target: aarch64-poky-linux Thread model: posix InstalledDir: /home/focht/projects/poky/sdk-install/sysroots/x86_64-pokysdk-linux/usr/bin/aarch64-poky-linux Found candidate GCC installation: /home/focht/projects/poky/sdk-install/sysroots/aarch64-poky-linux/usr/lib64//aarch64-poky-linux/8.2.0 Found candidate GCC installation: /home/focht/projects/poky/sdk-install/sysroots/aarch64-poky-linux/usr/lib64/gcc/aarch64-poky-linux/8.2.0 Selected GCC installation: /home/focht/projects/poky/sdk-install/sysroots/aarch64-poky-linux/usr/lib64//aarch64-poky-linux/8.2.0 Candidate multilib: .;@m64 Candidate multilib: 32;@m32 Selected multilib: .;@m64 --- snip --- Note: The "bootstrapper" installer from the website is win64-aarch64. When run on target hw, it unwraps another installer which is x86 and tries to start it. This obviously can't work on aarch64 Linux / Wine. You can just unpack the bootstrapper and run win64-aarch64 Firefox directly, bypassing the intermediate x86 installer. --- snip --- $ 7z l Firefox\ Setup\ 76.0.exe Scanning the drive for archives: 1 file, 77689880 bytes (75 MiB) Listing archive: Firefox Setup 76.0.exe -- Path = Firefox Setup 76.0.exe Type = PE Physical Size = 77689880 CPU = 0xAA64 64-bit = + Characteristics = Executable LargeAddress Created = 2019-09-23 20:08:10 Headers Size = 1024 Checksum = 77712930 Name = 7zSD.sfx Image Size = 360448 Section Alignment = 4096 File Alignment = 512 Code Size = 181760 Initialized Data Size = 166912 Uninitialized Data Size = 0 Linker Version = 14.22 OS Version = 6.2 Image Version = 0.0 Subsystem Version = 6.2 Subsystem = Windows GUI DLL Characteristics = Relocated NX-Compatible TerminalServerAware 0x20 Stack Reserve = 1048576 Stack Commit = 4096 Heap Reserve = 1048576 Heap Commit = 4096 Image Base = 5368709120 Comment = FileVersion: 18.5.0.0 FileVersion: 18.05 ProductVersion: 18.5.0.0 ProductVersion: 18.05 CompanyName: Mozilla FileDescription: Firefox InternalName: 7zSD.sfx LegalCopyright: Mozilla OriginalFilename: 7zSD.sfx ProductName: Firefox ---- Path = [0] Size = 77345104 Packed Size = 77345104 Virtual Size = 77345104 Offset = 335872 -- Path = [0] Type = 7z Offset = 81 Physical Size = 77345022 Tail Size = 1 Headers Size = 1387 Method = LZMA:25 BCJ2 Solid = + Blocks = 1 Date Time Attr Size Compressed Name ------------------- ----- ------------ ------------ ------------------------ 2020-04-29 22:42:06 ....A 2312 77343635 core/precomplete 2020-04-29 22:42:07 ....A 16 core/removed-files 2020-04-29 22:42:06 ....A 23037 core/browser/VisualElements/VisualElements_150.png 2020-04-29 22:42:06 ....A 8763 core/browser/VisualElements/VisualElements_70.png 2020-04-29 22:42:06 ....A 58010 core/browser/features/doh-rollout(a)mozilla.org.xpi 2020-04-29 22:42:06 ....A 639608 core/browser/features/formautofill(a)mozilla.org.xpi 2020-04-29 22:42:06 ....A 340280 core/browser/features/screenshots(a)mozilla.org.xpi 2020-04-29 22:42:06 ....A 26397 core/browser/features/webcompat-reporter(a)mozilla.org.xpi 2020-04-29 22:42:06 ....A 110202 core/browser/features/webcompat(a)mozilla.org.xpi 2020-04-29 22:42:07 ....A 557 core/firefox.VisualElementsManifest.xml 2020-04-29 22:42:06 ....A 429 core/defaults/pref/channel-prefs.js 2020-04-29 22:42:07 ....A 887 core/application.ini 2020-04-29 22:42:06 ....A 787 core/browser/crashreporter-override.ini 2020-04-29 22:42:06 ....A 4003 core/crashreporter.ini 2020-04-29 22:42:07 ....A 164 core/platform.ini 2020-04-29 22:42:07 ....A 132 core/update-settings.ini 2020-04-29 22:42:06 ....A 1245 core/updater.ini 2020-04-29 22:42:06 ....A 1244336 core/fonts/TwemojiMozilla.ttf 2020-04-29 22:42:06 ....A 239816 core/crashreporter.exe 2020-04-29 22:42:06 ....A 120008 core/default-browser-agent.exe 2020-04-29 22:42:06 ....A 547016 core/firefox.exe 2020-04-29 22:42:07 ....A 957640 core/uninstall/helper.exe 2020-04-29 22:42:07 ....A 234696 core/maintenanceservice.exe 2020-04-29 22:42:06 ....A 162536 core/maintenanceservice_installer.exe 2020-04-29 22:42:06 ....A 698568 core/minidump-analyzer.exe 2020-04-29 22:42:06 ....A 74440 core/pingsender.exe ... 2020-04-29 22:42:06 D.... 0 0 core/browser/VisualElements 2020-04-29 22:42:06 D.... 0 0 core/browser/features 2020-04-29 22:42:06 D.... 0 0 core/browser 2020-04-29 22:42:07 D.... 0 0 core ------------------- ----- ------------ ------------ ------------------------ 2020-04-29 22:42:07 289972447 77343635 69 files, 13 folders --- snip --- $ sha1sum Firefox\ Setup\ 76.0.exe 27c4abd83cf6bd20e0fe1982709c3a35902cad1a Firefox Setup 76.0.exe $ du -sh Firefox\ Setup\ 76.0.exe 75M Firefox Setup 76.0.exe $ wine --version wine-5.9 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

1 4