https://bugs.winehq.org/show_bug.cgi?id=46996 --- Comment #5 from Andrew Eikum <aeikum(a)codeweavers.com> --- Thanks, those look fine. Just a couple of nit-picks: You have a couple of lines that end with whitespace or are entirely whitespace. Please remove the unnecessary whitespace (see the dots in these examples, there are more in your patches): + break; +···· + case 7: /* back right */ + value *= 1.0f;· You are also adding some tabs into a file that is indented with spaces: + case 3: + /* LFE is totally ignored in dsound when downmixing to 2 channels */ +»······»·······»·······»·······break; + } Once you've fixed those, feel free to send them to wine-devel for inclusion. Again, please review the Submitting Patches page I linked above. Specifically remember to include your sign-off on the patches. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.