https://bugs.winehq.org/show_bug.cgi?id=34573 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leslie_alistair(a)hotmail.com --- Comment #11 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Hi Yan, (In reply to Yann Leretaille from comment #10)
Steve, thanks for testing the patch and confirming that it works! I really don't think this patch is in a such a state that it would pass the submission criteria, though. Does anybody know how to get a dev who is familiar with this dll to look at it?
The code overall looks good, but the things that stand out are 1. Mixing of Spaces and Tabs, look at the struct's for examples (use spaces). 2. Split the patch into two, one for CancelMibChangeNotify2, and the other for NotifyIpInterfaceChange. 3. The functions lines are a little too long, split the parameters over multiple lines. Alistair -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.