http://bugs.winehq.com/show_bug.cgi?id=1147 ------- Additional Comments From winebug(a)flonet.net 2003-28-06 09:57 ------- Bug comments restored from Gmane.org: To make this dll compile with -DSTRICT do the following: - remove -DWINE_NO_STRICT from the dll's Makefile.in and regenerate the Makefile - do a make clean in that dll - do a make and fix all warnings, even the "int format, HANDLE arg" warnings. To fix wrong handle conversions, use the tips given in bug 90. ------- Additional Comments From jdahlin(a)async.com.br 2002-11-18 06:45 ------- Created an attachment (id=337) --> (http://bugs.winehq.com/attachment.cgi?id=337&action=view) Make shell32 compile without WINE_NO_STRICT ------- Additional Comments From jdahlin(a)async.com.br 2002-11-18 06:47 ------- Since this is my first try to STRICT:ify a dll in wine i'm attaching it here for review before sending to wine-patches. If it's okay i'll continue and help with the other few dlls that's left. One thing that worries me is if i should do: if ((int)hInstance < 32) or if (hInstance < (HINSTANCE)32) Except from that should the fact that it's compiling without warnings be enough, shouldn't it? ------- Additional Comments From tony_lambregts(a)telusplanet.net 2002-11-18 10:48 ------- At this point in time you should send the patch to wine-patches(a)winehq.com . You will get far more review of it there. Please include a link to this bug report in your patch submission. You should include a link here (in the Additional Comments:) to the patch in in the wine-patches archive http://www.winehq.com/hypermail/wine-patches/ (this is nice to do as it provides a good cross reference.). ------- Additional Comments From dpaun(a)rogers.com 2002-11-21 18:14 ------- Patch submitted ------- Additional Comments From dpaun(a)rogers.com 2002-11-21 18:14 ------- Patch committed: http://cvs.winehq.com/patch.py?id=6364 -- Configure bugmail: http://bugs.winehq.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.