http://bugs.winehq.org/show_bug.cgi?id=14717 Krzysztof Nikiel <zzdz2(a)yahoo.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzdz2(a)yahoo.pl --- Comment #16 from Krzysztof Nikiel <zzdz2(a)yahoo.pl> 2010-11-24 05:17:25 CST ---
Questions:
1) Why is the sinc Kaiser-windowed? There are simpler windows that don't require calculation of modified Bessel functions.
Kaiser seems a good compromise, good filter transition and simple to calculate, much simplier than equiripple.
2) Why are the start of the stopband and the transition width chosen this way? As far as I understand, this will lead to attenuation near the Nyquist frequency of worse than -6 dB (not checked, but guessed by the fact that the transition width is more than the distance between the start of the stopband and the Nyquist frequency).
Well, lowering stopband would reduce the passband. Shorting transition would increase the necessary impulse width. It's a trade-off. Longer impulse has worse time domain properties and requires more processing power.
3) Did you test your patch for security bugs like buffer overflows for certain stupid requests like "resample this from a 100 Hz buffer to a 192 kHz output buffer"?
I did some basic tests and it seems ok. I did the coding, now you are welcome to find bugs ;) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.