http://bugs.winehq.org/show_bug.cgi?id=28723 --- Comment #77 from Andrew Eikum <aeikum(a)codeweavers.com> 2011-12-08 15:03:49 CST ---
Jörg Höhle changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.4.0 |---
Did you do this intentionally, Jörg? I think it's critical that we get this fixed before the code freeze for 1.4. I looked at your GetPosition patch. It makes sense to me, and passes all tests. I ran a few different applications against it without issue as well. A couple of tiny comments: This seems strange to me: + if(!This->started || alsa_state > SND_PCM_STATE_RUNNING) I think it can be made more explicit by spelling out which states are wanted here. Perhaps s/5/EIO/ here: + /* Pulse bug: err -5 shortly after starting: nothing played */ As you say, moving the final TRACE out of the critical section is a good idea. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.