https://bugs.winehq.org/show_bug.cgi?id=47899 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- This is mostly done. What remains is the SetWinLocale part and renaming past snapshot names. * Not allowing dashes in VM names is fixed by this commit: commit 77c97d74279b208bf05d2da7453d4defbe2464fb testbot: Fix the VM Missions validation. $Item->Xxx("foo") does not go through PutColValue()! Instead AUTOLOAD sets the specified property directly, maybe fori performance reasons, and PutColValue() is only used by DBIBackend.pm. WineTestBot::VMs was overriding PutColValue() to only revalidate a VM's missions field if either the VM Type of Missions field were modified. But instead ValidateMissions was always true after loading a VM from the database (because of the PutColValue() calls), and not when creating a new VM (in which case all the properties are set through AUTOLOAD). So take a snapshot of the initial Type and Missions values when the database code resets the IsModified field by calling ResetModified(); and then revalidate them whenever they have changed. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> * A VM::UntaintName() method has been added in this commit. commit 4bb065f0b60710ae3c91d3444bf1df1febd39023 Author: Francois Gouget <fgouget(a)codeweavers.com> AuthorDate: Mon Dec 2 13:55:07 2019 +0100 testbot: Validate VM names and add UntaintName(). This prevents discrepencies between the VM creation interface and LibvirtTool's validation of VM names. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.