http://bugs.winehq.org/show_bug.cgi?id=17195 --- Comment #125 from Daniel Jelinski <djelinski1(a)gmail.com> 2013-01-03 15:13:35 CST --- (In reply to comment #123)
(In reply to comment #119)
You can (and should) split it some more. Changing flush deserves its separate patch, and so does changing ioctl.
You mean split patch 5 more?
Yes. If some app breaks after your commits, you'll get a regression test pointing to one of them. The smaller that patch is, the better for you. Apps tend to break on good commits too, so even if you're sure everything is OK, splitting is always a good idea. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.