[Bug 46655] New: Adobe Photoshop CC 2015.5: Tabs show completely black
https://bugs.winehq.org/show_bug.cgi?id=46655 Bug ID: 46655 Summary: Adobe Photoshop CC 2015.5: Tabs show completely black Product: Wine Version: 4.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: gdi32 Assignee: wine-bugs(a)winehq.org Reporter: winepala(a)tradermail.info Distribution: --- Created attachment 63587 --> https://bugs.winehq.org/attachment.cgi?id=63587 screenshot This is a regression since wine-3.0 where I last saw it working. Photoshop panels render to pitch black but can still be interacted with. Confirmed broken in wine/stable (4.0) and wine/master (currently tag:wine-4.2) I did a git bisect from wine-3.0 (good) to wine-3.10 (bad) and landed on these two commits. The last one I could not tag as it causes Photoshop to crash. commit 99b64f74320ba11b282a33aad2edc28551501875 (refs/bisect/bad) Date: Wed Apr 4 15:12:55 2018 +0200 gdi32: Build the region object directly instead of making a copy in CreatePolyPolygonRgn. commit 97f996744eafc4ad640ca3b9d97016625443c8cd (HEAD) (crashes) Date: Wed Apr 4 12:38:29 2018 +0200 gdi32: Pre-allocate the points array in CreatePolyPolygonRgn. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #1 from winepala(a)tradermail.info --- Created attachment 63588 --> https://bugs.winehq.org/attachment.cgi?id=63588 wine output My System Information: Debian/unstable wine-stable (4.0) binary packages from winehq Attached wine output -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 winepala(a)tradermail.info changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Regression SHA1| |99b64f74320ba11b282a33aad2e | |dc28551501875 CC| |julliard(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #2 from winepala(a)tradermail.info --- Created attachment 64484 --> https://bugs.winehq.org/attachment.cgi?id=64484 Photoshop CC 2015.5 WINEDEBUG=region trace I attached a trace of the "region" debug channel. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #3 from winepala(a)tradermail.info --- Since getting a copy of Photoshop may prove difficult I have attached a trace of the "region" channel. I should also add that Photoshop CC 2019 64-bits also suffers from this problem. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #4 from Fabian Maurer <dark.shadow4(a)web.de> --- I tried the CC 2019 trial, and I don't have this issue. How do I reproduce the issue? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Okay, after reverting the last 4 commits to gdi32/region.c I see the issue. It's just that for me it's not black, but grey, making it look different. Probably due to different graphics drivers and undefined behavior. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #6 from winepala(a)tradermail.info --- Created attachment 64498 --> https://bugs.winehq.org/attachment.cgi?id=64498 Photoshop CC 2019 Problem Screenshot -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #7 from winepala(a)tradermail.info --- Created attachment 64499 --> https://bugs.winehq.org/attachment.cgi?id=64499 Photoshop CC 2019 Problem Screenshot (after minimize) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #8 from Fabian Maurer <dark.shadow4(a)web.de> --- Okay, I figured this one out. The problem is the edge case where all points are on one point. Old implementation returns an empty region, new implementation returns NULL. Will make tests and a patch tomorrow. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #9 from winepala(a)tradermail.info --- Thank you for confirming it. Could you also confirm what dll overrides you need CC 2019 to run? I need vcrun2015 or CRClient.dll fails to initialize. If possible, please backport the patch to the stable branch, too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 64500 --> https://bugs.winehq.org/attachment.cgi?id=64500 Patch Here a patch you can test, it should apply on top of the stable branch as well. Can you confirm it works for you as well? Since I installed Photoshop with the installer which needs a lot of overrides, I have a bunch - but for running AFAIK I only needed vcrun2015. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #11 from winepala(a)tradermail.info --- (In reply to Fabian Maurer from comment #10)
Here a patch you can test, it should apply on top of the stable branch as well. Can you confirm it works for you as well? Confirmed it works on stable and master Since I installed Photoshop with the installer which needs a lot of overrides, I have a bunch - but for running AFAIK I only needed vcrun2015. Thank you
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 --- Comment #12 from Fabian Maurer <dark.shadow4(a)web.de> --- Submitted a patch: https://source.winehq.org/patches/data/165030 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |9bc6f004ceccf3963584a4f7f46 | |81b5c0578c214 --- Comment #13 from Fabian Maurer <dark.shadow4(a)web.de> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=9bc6f004ceccf3963584a4f7f... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #14 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 4.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=46655 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #15 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla