[Bug 17601] New: winhlp32: links ceased working
http://bugs.winehq.org/show_bug.cgi?id=17601 Summary: winhlp32: links ceased working Product: Wine Version: 1.1.16 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: hoehle(a)users.sourceforge.net Somewhere between 1.1.11 and 1.1.16, the (document internal) links in .hlp files ceased working. The link is still shown in green letters, but the mouse does not change when over it, nor is it clickable. Git regression testing will follow ASAP. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 --- Comment #1 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2009-03-04 01:02:45 --- http://wiki.winehq.org/RegressionTesting -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith(a)gmail.com Component|programs |richedit --- Comment #2 from Jörg Höhle <hoehle(a)users.sourceforge.net> 2009-03-05 14:56:13 --- This is offending commit, between wine-1.1.13 and 1.1.14: commit 05c788ac6f464b75c2a55c847a91d3a79261ca8e Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Tue Jan 20 01:41:32 2009 -0500 richedit: Used ITextHost methods to avoid using window handle directly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |ASSIGNED Ever Confirmed|0 |1 --- Comment #3 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-05 16:10:14 --- Thanks for reporting this regression. The problem was that ITextHost_TxNotify was being with the EN_MSGFILTER notification, but this was not implemented in the windowed implementation of the ITextHost interface the documentation said that TxNotify was not supposed to be called with this notification. Thus I changed ME_FilterEvent to use SendMessage directly again. I created a patch to fix the bug and submitted it to wine-patches: richedit: Avoid calling ITextHost_TxNotify with EN_MSGFILTER. http://www.winehq.org/pipermail/wine-patches/2009-March/070319.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17627 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 --- Comment #4 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-06 11:27:33 --- (In reply to comment #3)
I created a patch to fix the bug and submitted it to wine-patches: richedit: Avoid calling ITextHost_TxNotify with EN_MSGFILTER. http://www.winehq.org/pipermail/wine-patches/2009-March/070319.html
That patch is now in git as commit bcd8dc93a2c5052a1185fe1b462fc0d95a5adb59. Let me know if it works for you. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Jörg Höhle <hoehle(a)users.sourceforge.net> 2009-03-07 11:40:48 --- I applied your patch to 1.1.16 and it fixed the issue. Thanks! Marking fixed as you say it's now in git. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17601 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2009-03-13 11:15:48 --- Closing bugs fixed in 1.1.17. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org