[Bug 13740] New: winebrowser gets wrong URL, problem with unicode
http://bugs.winehq.org/show_bug.cgi?id=13740 Summary: winebrowser gets wrong URL, problem with unicode Product: Wine Version: CVS/GIT Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: patrol(a)sinus.cz Created an attachment (id=13773) --> (http://bugs.winehq.org/attachment.cgi?id=13773) trace with +winebrowser The following commit commit e547cf7043e36fecfe5e23d1d6f93a9c5ba89c46 Author: Hans Leidekker <hans(a)it.vu.nl> Date: Sun Apr 6 14:44:31 2008 +0200 winebrowser: Convert to Unicode. caused a regression in wine, causing that winebrowser gets wrong URL and cannot load the requested page. The URL is displayed as a series of question marks. The operating system normally uses a czech locale (cs_CZ.ISO-8859-2). The URLs which are attempted to access don't contain any special characters, which would require unicode to be used. To reproduce, download the following freely available program http://www.3amsystems.com/products/CPT-Master.exe , run it in wine and select "Buy now" from the welcome screen. The browser will open, but its URL will be wrong. The same happens when trying to buy a game from Steam. Trying to use LC_ALL=cs_CZ.UTF-8 and running the program causes that there are chinese characters in the URL, which is also totally wrong :-). It used to work perfectly in wine 0.9.57 (both cases mentioned). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #1 from Hans Leidekker <hans(a)it.vu.nl> 2008-06-07 09:16:50 --- Created an attachment (id=13779) --> (http://bugs.winehq.org/attachment.cgi?id=13779) winebrowser: Convert DDE data to Unicode. Thank you for the bug report Pavel. Here's a patch that should fix the regression, can you try it? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Hans Leidekker <hans(a)it.vu.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans(a)it.vu.nl Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #2 from Pavel Troller <patrol(a)sinus.cz> 2008-06-07 09:24:31 --- Yes, it does. Verified on the CPT-Master, URL is now correct. Many thanks to you, Hans, for so quick response! -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Hans Leidekker <hans(a)it.vu.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.3amsystems.com/pr | |oducts/CPT-Master.exe Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Keywords| |patch --- Comment #3 from Hans Leidekker <hans(a)it.vu.nl> 2008-06-07 09:46:49 --- OK, I'll submit the patch but it may not make it in at this stage of the code freeze. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #4 from Pavel Troller <patrol(a)sinus.cz> 2008-06-07 10:36:24 --- Why ? It does not add any new functionality, but fixes a serious bug! I hope it will be included in 1.0... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dank(a)kegel.com Target Milestone|--- |1.0.0 --- Comment #5 from Dan Kegel <dank(a)kegel.com> 2008-06-07 10:53:52 --- Regression in core feature, well understood, patch -> nominate for 1.0 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Hans Leidekker <hans(a)it.vu.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Hans Leidekker <hans(a)it.vu.nl> 2008-06-09 07:56:15 --- Fixed by 3dcf22e03fb4473db112bcd47671b37a037cbfc6 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000(a)yahoo.co.uk Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #7 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-06-10 15:17:44 --- I think i run into the same bug here trying Garena, so i'm reopening this bug The output is: trace:winebrowser:ddeCb dde_cb: 1062, 0000, (nil), 0xc001, 0xc000, (nil), 0033f7bc, 00000000 trace:winebrowser:ddeCb dde_cb: 8072, 0000, 0x120858, 0xc001, 0xc000, (nil), 0033f7bc, 00000000 trace:winebrowser:ddeCb dde_cb: 4050, 0000, 0x120858, 0xc001, (nil), 0x1208e2, 00000000, 00000000 err:winebrowser:get_url_from_dde Unabled to retrieve URL from string L"\"" err:winebrowser:wmain Usage: winebrowser URL -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Dan Kegel <dank(a)kegel.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.0.0 |1.0.1 --- Comment #8 from Dan Kegel <dank(a)kegel.com> 2008-06-11 16:29:43 --- 1.0 is breathing down our necks. Deferring to 1.0.1 (and possibly later). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-13 07:02:10 --- (In reply to comment #7)
I think i run into the same bug here trying Garena, so i'm reopening this bug
Does it really work if you revert e547cf7043e36fecfe5e23d1d6f93a9c5ba89c46? Otherwise it's a different bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #10 from Hans Leidekker <hans(a)it.vu.nl> 2008-06-13 09:31:37 --- Reverting the patch will fix Garena and break CPT-Master again. To fix this properly we somehow need to find out wether the URL retrieved is an ANSI or Unicode string. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #11 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-13 09:54:37 --- My point is that if Garena is sending Unicode then it wouldn't have worked when winebrowser was ASCII, so it's not the same regression, and it should have a different bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #12 from Hans Leidekker <hans(a)it.vu.nl> 2008-06-13 11:27:01 --- Right, e547cf7043e36fecfe5e23d1d6f93a9c5ba89c46 caused the regression for Pavel which is what this bug is about. 3dcf22e03fb4473db112bcd47671b37a037cbfc6 fixed the regression for Pavel and caused the regression for Louis so that's strictly a different bug, even though the underlying problem is the same. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED Target Milestone|1.0.1 |1.0.0 --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-13 12:03:30 --- Moving back to FIXED then. Louis, please file a new bug for the Garena issue. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 --- Comment #14 from Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> 2008-06-13 17:10:14 ---
Moving back to FIXED then. Louis, please file a new bug for the Garena issue. It looks like Lei already filed a bug for this issue: http://www.winehq.org/pipermail/wine-bugs/2008-June/119497.html
-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #15 from Alexandre Julliard <julliard(a)winehq.org> 2008-06-17 09:26:16 --- Closing bugs fixed in 1.0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=13740 Germain Barret <sandburg(a)netcourrier.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandburg(a)netcourrier.com --- Comment #16 from Germain Barret <sandburg(a)netcourrier.com> 2009-01-15 16:11:11 --- It is not fixed in Wine 1.1.12 in the game VirtualSkipper5 : wine Vsk5Launcher.exe fixme:win:EnumDisplayDevicesW ((null),0,0x32f608,0x00000000), stub! err:winebrowser:get_url_from_dde Unabled to retrieve URL from string L"\"" err:winebrowser:wmain Usage: winebrowser URL Sorry -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org