[Bug 51706] New: Msi HANDLE_CustomType1 fails to load dll [patch]
https://bugs.winehq.org/show_bug.cgi?id=51706 Bug ID: 51706 Summary: Msi HANDLE_CustomType1 fails to load dll [patch] Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msi Assignee: wine-bugs(a)winehq.org Reporter: ake.rehnman(a)gmail.com Distribution: --- Created attachment 70581 --> https://bugs.winehq.org/attachment.cgi?id=70581 Patch for correctly determine the bitness for CustomAction dll do_msidbCustomActionTypeDll incorrectly assume dlls have the same "bitness" as the calling application. The Windows GetBinaryTypeW function used actually always fails for dll-types. From the documentation: "If the file is a DLL, the last error code is ERROR_BAD_EXE_FORMAT." If GetBinaryTypeW fails the fall back is incorrectly using the same bitness as the application it self. As far as I know there is no windows api to determine the bitness of DLLs. In my attached patch I have written a new function to determine the DLL type. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51706 Hans Leidekker <hans(a)meelstraat.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |4aa858c9badfb35bcc3cdd38abf | |d40dc5b06c696 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Hans Leidekker <hans(a)meelstraat.net> --- Fixed by 4aa858c9badfb35bcc3cdd38abfd40dc5b06c696. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51706 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #2 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla