[Bug 31769] New: windowsx.h macro HANDLE_WM_DISPLAYCHANGE is incorrect
http://bugs.winehq.org/show_bug.cgi?id=31769 Bug #: 31769 Summary: windowsx.h macro HANDLE_WM_DISPLAYCHANGE is incorrect Product: Wine Version: 1.4.1 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: jc.gervais(a)videotron.ca Classification: Unclassified windowsx.h macro HANDLE_WM_DISPLAYCHANGE is erroneous: The CY parameter is not cracked correctly for the function pointer argument. This is because of a simple typo - the macro is defined thus: #define HANDLE_WM_DISPLAYCHANGE(hwnd, wParam, lParam, fn) ((fn)((hwnd), (UINT)(wParam), (UINT)LOWORD(lParam), (UINT)HIWORD(wParam)), 0L) but should be defined this way: #define HANDLE_WM_DISPLAYCHANGE(hwnd, wParam, lParam, fn) ((fn)((hwnd), (UINT)(wParam), (UINT)LOWORD(lParam), (UINT)HIWORD(lParam)), 0L) HIWORD( wParam ) is incorrectly used for the CY value when in fact it is encoded in HIWORD( lParam ) That is all. Thank you for your hard work, great persistence and attention to detail. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2012-09-24 18:57:46 CDT --- Please send a patch to wine-patches(a)winehq.org -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 Carlo Bramini <carlo.bramix(a)libero.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carlo.bramix(a)libero.it --- Comment #2 from Carlo Bramini <carlo.bramix(a)libero.it> 2013-02-18 14:20:45 CST --- This bug should be closed by the patch committed here: http://source.winehq.org/git/wine.git/commit/8fa295ed879b08ee42945b65abb8cee... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8fa295ed879b08ee42945b65abb | |8cee25def6af4 Status|UNCONFIRMED |RESOLVED Resolution| |FIXED --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> 2013-02-18 14:23:48 CST --- Fixed with 8fa295ed879b08ee42945b65abb8cee25def6af4. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 J <jc.gervais(a)videotron.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from J <jc.gervais(a)videotron.ca> 2013-02-18 14:36:08 CST --- Thanks guys! J -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |RESOLVED -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2013-03-01 14:50:44 CST --- Closing bugs fixed in 1.5.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=31769 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> 2013-03-01 15:10:01 CST --- Really closing bugs fixed in 1.5.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org