[Bug 19289] New: Gimp: License text is missing new lines (appinstall)
http://bugs.winehq.org/show_bug.cgi?id=19289 Summary: Gimp: License text is missing new lines (appinstall) Product: Wine Version: 1.1.25 Platform: PC URL: http://gimp-win.sourceforge.net/stable.html OS/Version: Linux Status: NEW Keywords: download, source Severity: trivial Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com See screenshot. Native riched20 doesn't help. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-07-11 20:04:20 --- Created an attachment (id=22333) --> (http://bugs.winehq.org/attachment.cgi?id=22333) screenshot Didn't attach earlier... -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de --- Comment #2 from André H. <nerv(a)dawncrow.de> 2009-07-30 15:18:54 --- confiriming in wine 1.1.26 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2011-09-08 23:34:04 CDT --- http://sourceforge.net/projects/gimp-win/files/GIMP%20%2B%20GTK%2B%20%28stab... Still in wine-1.3.27-416-g0032de5 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexhenrie24(a)gmail.com --- Comment #4 from Alex Henrie <alexhenrie24(a)gmail.com> 2011-12-09 14:24:28 CST --- Still in wine-1.3.34-40-gf04061a. When I copy and paste the license text, the line breaks come back. My guess is that the bug is in how the text is rendered in the textbox: \n\n is displayed as \n. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #5 from Austin English <austinenglish(a)gmail.com> --- Still in wine-1.7.16-117-ge3383d1 terminal shows a lot of: fixme:uniscribe:GSUB_apply_ChainContextSubst TODO: subtype 2 (Class-based Chaining Context Glyph Substitution) fixme:uniscribe:GSUB_apply_ChainContextSubst TODO: subtype 2 (Class-based Chaining Context Glyph Substitution) fixme:uniscribe:GSUB_apply_ChainContextSubst TODO: subtype 2 (Class-based Chaining Context Glyph Substitution) fixme:uniscribe:GSUB_apply_ChainContextSubst TODO: subtype 2 (Class-based Chaining Context Glyph Substitution) looks like it may be using uniscribe for text. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- It's unlikely it's using it directly. It's probably Edit or Richedit control that uses uniscribe. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #7 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 48307 --> http://bugs.winehq.org/attachment.cgi?id=48307 Registry workaround There's something wrong with the MS Shell Dlg font, as can be seen from GIMP's error output: (gimp-2.8.exe:34): Pango-WARNING **: couldn't load font "MS Shell Dlg Not-Rotated 8", falling back to "Sans Not-Rotated 8", expect ugly output. I believe MS Shell Dlg MUST be a TrueType (vector) font. Wine uses MS Sans Serif, which is a raster font. Windows uses Microsoft Sans Serif, which is TrueType but I don't think we're allowed to distribute it. If MS Shell Dlg is overridden with DejaVu Sans, GIMP works perfectly and the Pango warning disappears. But if MS Shell Dlg is overridden with Fixedsys (another raster font) the same problem occurs. So the solution is: Wine needs to pick a TrueType font to use for MS Shell Dlg. We should probably also provide a default replacement for Microsoft Sans Serif. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |fonts Version|1.1.25 |1.7.17 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #8 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alex Henrie from comment #7)
I believe MS Shell Dlg MUST be a TrueType (vector) font. Wine uses MS Sans Serif, which is a raster font.
Wine should use Tahoma as a MS Shell Dlg mapping.
Windows uses Microsoft Sans Serif, which is TrueType but I don't think we're allowed to distribute it.
Windows also used Tahoma for MS Shell Dlg, but at some point switched to Microsoft Sans Serif. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry(a)baikal.ru --- Comment #9 from Alex Henrie <alexhenrie24(a)gmail.com> --- Dimitry, do you know how to write a patch to fix this? If you can do it yourself that would be awesome, but if you can explain it to me I'll try writing it myself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #10 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alex Henrie from comment #9)
Dimitry, do you know how to write a patch to fix this? If you can do it yourself that would be awesome, but if you can explain it to me I'll try writing it myself.
First thing to do (as usually) is figure out what is going on exactly, what gimp is doing and what it expects, then to write a test case or a simple app that replicates the problem. Only then try to find a solution on Wine side. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Qian Hong <fracting(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fracting(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48307|0 |1 is obsolete| | --- Comment #11 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 48330 --> http://bugs.winehq.org/attachment.cgi?id=48330 Registry workaround You're right, HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\Current Version\FontSubstitutes\MS Shell Dlg is correctly set to Tahoma and MS Shell Dlg maps to Tahoma correctly for most applications. But for some reason, it's not working in GIMP. I'm attaching a slightly better registry workaround for GIMP that tells Wine to override MS Shell Dlg with Tahoma (instead of DejaVu Sans); maybe it will help someone else figure out what's going on here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|fonts |-unknown --- Comment #12 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Please attach a +font log. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48330|text/x-ms-regedit |text/plain mime type| | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #13 from Alex Henrie <alexhenrie24(a)gmail.com> --- Created attachment 48332 --> http://bugs.winehq.org/attachment.cgi?id=48332 WINEDEBUG=+font The Pango warning is on line 23,560. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48332|text/plain |application/x-xz-compressed mime type| |-tar -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #14 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alex Henrie from comment #13)
Created attachment 48332 [details] WINEDEBUG=+font
The Pango warning is on line 23,560.
I don't see anything wrong in this log, does the registry hack really fix the new lines in the license text? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #15 from Alex Henrie <alexhenrie24(a)gmail.com> --- Yes, try it yourself. It's baffling. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 Alex Henrie <alexhenrie24(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|http://gimp-win.sourceforge |http://www.gimp.org/downloa |.net/stable.html |ds/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #16 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- It looks like Pango depends on a substituted font being listed by EnumFontFamilies, otherwise it thinks that the font is not available. Registry key makes MS Shell Dlg appear in the EnumFontFamilies callback, otherwise it's not enumerated. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.7.17 |1.1.25 --- Comment #17 from André H. <nerv(a)dawncrow.de> --- please don't update the Wine Version info, keep it set to the first known occurrence -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #18 from Alex Henrie <alexhenrie24(a)gmail.com> --- For the record, tests related to this bug (which are currently marked todo) were added in http://source.winehq.org/git/wine.git/commitdiff/0fb88f8d01fd69e3d026fba069a... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #19 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- (In reply to Alex Henrie from comment #18)
For the record, tests related to this bug (which are currently marked todo) were added in http://source.winehq.org/git/wine.git/commitdiff/ 0fb88f8d01fd69e3d026fba069a66aa05413d48a
Also just for a reference here is a quote from my mail in wine-devel https://www.winehq.org/pipermail/wine-devel/2014-May/104250.html "Please add the tests for other font enumeration APIs (the may behave differently), and the tests with NULL face name (according to my tests in that case MS Shell Dlg won't be enumerated). Since that would clutter existing tests I'd suggest to move the new one into separate body and name it appropriately." -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #20 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 49845 --> https://bugs.winehq.org/attachment.cgi?id=49845 patch Does the attached patch help? In case there are future changes in the tests which lead to apply failures they could be safely ignored. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #21 from Alex Henrie <alexhenrie24(a)gmail.com> --- (In reply to Dmitry Timoshkov from comment #20)
Created attachment 49845 [details] patch
Does the attached patch help?
No, it does not fix this bug :( -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Dmitry Timoshkov <dmitry(a)baikal.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49845|0 |1 is obsolete| | --- Comment #22 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Created attachment 49858 --> https://bugs.winehq.org/attachment.cgi?id=49858 patch It appears that there is another bug that prevents gtk+/pango based applications use wrong font. These applications depend on SystemParametersInfo/ SPI_GETNONCLIENTMETRICS returning actual and not substituted font names. If pango can't find font name in the font list enumerated using NULL font name mask then it uses some ugly font replacement. Attached patch includes a fix for SystemParametersInfo as well. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #23 from Alex Henrie <alexhenrie24(a)gmail.com> --- (In reply to Dmitry Timoshkov from comment #22)
Created attachment 49858 [details] patch
Attached patch includes a fix for SystemParametersInfo as well.
This patch works! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grendal74.geo(a)yahoo.com --- Comment #24 from Anastasius Focht <focht(a)gmx.net> --- *** Bug 38819 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Summary|Gimp: License text is |Gtk+/Pango based |missing new lines |applications have ugly font |(appinstall) |rendering or crash on | |startup Severity|trivial |normal --- Comment #25 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, refining summary to collect more duplicates here. Also raising severity since Gtk+/Pango based apps are non-functional (either ulgy/garbage font rendering or crash). $ wine --version wine-1.7.46 Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #26 from Alex Henrie <alexhenrie24(a)gmail.com> --- Does attachment 48330 work around those bugs too? If not, I prefer to keep them separate. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #27 from Dmitry Timoshkov <dmitry(a)baikal.ru> --- Last patch in the series that is supposed to fix this bug is 268cdbbfb627dd64e527bb8603d9f8d8d788f0ae, please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |268cdbbfb627dd64e527bb8603d | |9f8d8d788f0ae Status|NEW |RESOLVED Resolution|--- |FIXED Distribution|--- |Fedora --- Comment #28 from Austin English <austinenglish(a)gmail.com> --- (In reply to Dmitry Timoshkov from comment #27)
Last patch in the series that is supposed to fix this bug is 268cdbbfb627dd64e527bb8603d9f8d8d788f0ae, please retest.
Using: http://download.gimp.org/pub/gimp/v2.6/windows/gimp-2.6.6-i686-setup.exe [austin(a)localhost ~]$ sha1sum gimp-2.6.6-i686-setup.exe 5a563111638433bc535510b95b1e2ae65a2ef31c gimp-2.6.6-i686-setup.exe [austin(a)localhost ~]$ du -h gimp-2.6.6-i686-setup.exe 16M gimp-2.6.6-i686-setup.exe [austin(a)localhost ~]$ wine --version wine-1.7.47-118-ga90592c License text has proper line breaks and looks really nice :). Thanks Dmitry. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 --- Comment #29 from Austin English <austinenglish(a)gmail.com> --- Created attachment 51876 --> https://bugs.winehq.org/attachment.cgi?id=51876 fixed screenshot -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #30 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.48. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=19289 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla