[Bug 23986] New: datetime control SetRange() has no effect, enter big year will cause CTime assert failed
http://bugs.winehq.org/show_bug.cgi?id=23986 Summary: datetime control SetRange() has no effect, enter big year will cause CTime assert failed Product: Wine Version: 1.2 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: drangon.mail(a)gmail.com When use datetime control, call SetRange() to limit time, then modified the year value to out of range, the modification can success, so SetRange() has no effect. In Windows, the same application, the same SetRange() call, then modified the year value to out of range, the datetime control will refuse the modification, and return to old value. I think there should be some check in DATETIME_Char() function in file "dlls/comctl32/datetime.c" , after change the datetime, call something like MONTHCAL_IsDateInValidRange() to validate the value. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-08-13 04:21:08 --- You mean DTM_SETRANGE and later editing displayed date with keyboard input? Attach a small test program please, with a source. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 --- Comment #2 from drangon <drangon.mail(a)gmail.com> 2010-08-15 21:32:51 --- Created an attachment (id=30173) --> (http://bugs.winehq.org/attachment.cgi?id=30173) datetime ctrl test exe -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 --- Comment #3 from drangon <drangon.mail(a)gmail.com> 2010-08-15 21:34:05 --- Created an attachment (id=30174) --> (http://bugs.winehq.org/attachment.cgi?id=30174) datetime ctrl test source code ( see test_datectlDlg.cpp ) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, testcase -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-08-21 10:38:30 --- Yeah, I can see a problem. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Owen Rudge <owen(a)owenrudge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |owen(a)owenrudge.net --- Comment #5 from Owen Rudge <owen(a)owenrudge.net> 2012-02-13 12:39:40 CST --- I have a fix for this I'll submit shortly. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |9de240bd0ea38c1c23803c01c42 | |5cc0c57fe5cd8 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> 2013-02-17 01:42:47 CST --- This is actually fixed with 9de240bd0ea38c1c23803c01c425cc0c57fe5cd8, I just tested with and without this patch and range limit is checked with keyboard input. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> 2013-02-17 01:52:48 CST --- Actually another commit related to that is c8c3c4be914481d95a9c2790716b9d973e697b37. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> 2013-03-01 14:50:07 CST --- Closing bugs fixed in 1.5.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=23986 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> 2013-03-01 15:09:43 CST --- Really closing bugs fixed in 1.5.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org