[Bug 38256] New: Myst Online Uru Live: too dark/missing textures
https://bugs.winehq.org/show_bug.cgi?id=38256 Bug ID: 38256 Summary: Myst Online Uru Live: too dark/missing textures Product: Wine Version: 1.7.39 Hardware: x86 URL: http://account.mystonline.com/download/MOULInstaller.e xe OS: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: gyebro69(a)gmail.com CC: matteo.mystral(a)gmail.com Regression SHA1: 9811d85141610f903d6c8de3b00be6c853ece182 Distribution: --- Created attachment 51071 --> https://bugs.winehq.org/attachment.cgi?id=51071 screenshot (comparison) Some of the textures are too dark, other textures are completely black in Myst Online: URU Live. Terminal output doesn't show anything. The problem doesn't exist if I disable GLSL. Regression introduced by 9811d85141610f903d6c8de3b00be6c853ece182 is the first bad commit commit 9811d85141610f903d6c8de3b00be6c853ece182 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Mar 18 21:07:38 2015 +0100 wined3d: Don't use the builtin FFP uniform for the modelview matrix. The game is free to play but you have to create an account. The link in the URL is pointing to the downloader. It will download approx. 1.5 GB data when you install the game. Fedora 21 Nvidia GeForce 250 / driver 340.76 MOULInstaller.exe sha1: 4768ab04881c4e378046b93d0c44e03b6148033a -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 --- Comment #1 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Some more testing revealed that this bug affects URU: Ages Beyond Myst too. It's less troublesome to reproduce the problem in this demo: http://www.fileplanet.com/133011/130000/fileinfo/Uru:-Ages-Beyond-MYST-Demo When you get to the character generation screen in the demo you should see that the character is almost completely black. urudemo.exe sha1: 68e713bf8a4d78aaca0b1344e07a6aa8da26398d -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 --- Comment #2 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Béla Gyebrószki from comment #1)
Some more testing revealed that this bug affects URU: Ages Beyond Myst too. It's less troublesome to reproduce the problem in this demo: http://www.fileplanet.com/133011/130000/fileinfo/Uru:-Ages-Beyond-MYST-Demo
When you get to the character generation screen in the demo you should see that the character is almost completely black.
urudemo.exe sha1: 68e713bf8a4d78aaca0b1344e07a6aa8da26398d
Cool, thanks. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 --- Comment #3 from Matteo Bruni <matteo.mystral(a)gmail.com> --- Eh, this was pretty obvious in hindsight. I'm not setting the builtin modelview matrix anymore so gl_NormalMatrix is now "garbage". One fix is to apply the patch I just sent to wine-patches (which requires my previous 5-patches series, or manual tweaking, to avoid conflicts). Another possibility is to add a "transform_world(context, state, state_id);" line to glsl_vertex_pipe_world() and glsl_vertex_pipe_view(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 --- Comment #4 from Sebastian Lackner <sebastian(a)fds-team.de> --- Thanks for the quick solution. I can confirm that it fixes the issue. A version of the patch rebased against 1.7.39 is available here: https://github.com/wine-compholio/wine-staging/tree/master/patches/wined3d-N... Would it make sense to add any error checking for invert_matrix_3d_general, or how did native behave before in such odd situations? ^^ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 --- Comment #5 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to Sebastian Lackner from comment #4)
Would it make sense to add any error checking for invert_matrix_3d_general, or how did native behave before in such odd situations? ^^
Yes, there should be a check there or the BOOL return value from the function removed. Specifically Mesa uses an identity matrix when the source matrix is singular. I should write a test and check what happens on Windows in that case (as unlikely / broken that is). Actually https://msdn.microsoft.com/en-us/library/windows/desktop/bb172390%28v=vs.85%... uses a slightly different definition for the normal matrix. Not sure MSDN is correct, I should test that too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 Luke Bratch <luke(a)bratch.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |luke(a)bratch.co.uk -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |7a8ac888de232578dd36f799cf2 | |03e5a59fe5b70 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Béla Gyebrószki <gyebro69(a)gmail.com> --- Fixed by http://source.winehq.org/git/wine.git/commitdiff/7a8ac888de232578dd36f799cf2... Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38256 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.40. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org