[Bug 14366] New: co-operate with valgrind when switching stacks
http://bugs.winehq.org/show_bug.cgi?id=14366 Summary: co-operate with valgrind when switching stacks Product: Wine Version: 1.0.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: jreiser(a)BitWagon.com Created an attachment (id=14663) --> (http://bugs.winehq.org/attachment.cgi?id=14663) tell valgrind when switching stacks When wine knows it is switching stacks, then wine should tell valgrind. This reduces valgrind complaints, and increases the ability of memcheck to detect errors. Patch is attached, and will be sent to wine-patches(a)winehq.org. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14366 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #1 from Austin English <austinenglish(a)gmail.com> 2009-01-05 11:12:55 --- Is this still an issue in current (1.1.12 or newer) wine? Would you mind resubmitting the patch and asking for comments? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14366 --- Comment #2 from Austin English <austinenglish(a)gmail.com> 2009-07-16 13:11:02 --- This area has changed a lot recently, might be worth taking another look/re-valgrinding. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14366 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |austinenglish(a)gmail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14366 --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2012-03-19 14:02:41 CDT --- Still present. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14366 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14366 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de --- Comment #4 from Sebastian Lackner <sebastian(a)fds-team.de> --- This bug report should probably be closed as ABANDONED. The attached patch seems to rely on the VG_USERREQ__STACK_SWITCH (0x1504) user request, which was proposed in https://sourceforge.net/p/valgrind/mailman/message/16342675/. However, when checking the current Valgrind source, it looks like it was never actually merged. The last code is VG_USERREQ__STACK_CHANGE (0x1503). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14366 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ABANDONED Status|UNCONFIRMED |RESOLVED --- Comment #5 from Austin English <austinenglish(a)gmail.com> --- (In reply to Sebastian Lackner from comment #4)
This bug report should probably be closed as ABANDONED.
The attached patch seems to rely on the VG_USERREQ__STACK_SWITCH (0x1504) user request, which was proposed in https://sourceforge.net/p/valgrind/mailman/message/16342675/.
However, when checking the current Valgrind source, it looks like it was never actually merged. The last code is VG_USERREQ__STACK_CHANGE (0x1503).
Agreed. I've mentioned this patch (and John's others) to the valgrind team on a few occasions. I take their silence to mean that the patches (at least in their current form, I can't speak in general) aren't mergeable. Abandoned. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=14366 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Austin English <austinenglish(a)gmail.com> --- Closing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org