[Bug 51137] New: Construction Set for TES4 Oblivion missing or broken text in some places
https://bugs.winehq.org/show_bug.cgi?id=51137 Bug ID: 51137 Summary: Construction Set for TES4 Oblivion missing or broken text in some places Product: Wine Version: 6.8 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: lorenzofer(a)live.it Distribution: ArchLinux As the tile say, the Construction Set (the editor) for TES4 OBlivion is showing some missing text (the plugin file picker list for example, the entries are selectable but the text indicating the file name isn't empty), or missing/garbled (as in the Object Window). This started after 6.7 and both 6.8 release and current master are affected. wine 6.7 do works fully instead showing the proper text. I'm currently doing a regression test. Will write the results of the test later. The log is empty except for a bunch of: 00e4:fixme:seh:virtual_unwind calling personality routine in system library not supported yet 00e4:fixme:seh:execute_cfa_instructions 7fc4918d91e3: unknown CFA opcode 2e 00e4:fixme:seh:valid_reg unsupported reg 6c -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Lorenzo Ferrillo <lorenzofer(a)live.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |277daa7ea7e8a953a2f726ce935 | |4af82ab4635da --- Comment #1 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- 277daa7ea7e8a953a2f726ce9354af82ab4635da is the first bad commit commit 277daa7ea7e8a953a2f726ce9354af82ab4635da Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Tue Apr 27 11:35:08 2021 +0800 comctl32/theming: Register themed dialog and scrollbar even when theming is not active. So that we can turn on theming in runtime. Otherwise, themed dialog and scrollbar are not enabled even if a theme is made active in winecfg if theming is disabled at start. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44511 Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> dlls/comctl32/tests/misc.c | 2 +- dlls/comctl32/theming.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Lorenzo Ferrillo <lorenzofer(a)live.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #2 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- Ok I thinkered a bit around comctl32 The component is the dialogClass sublass. If I prevent the function override in THEMING_Initialize all works, even if I let the class re-register. (The othe class WC_SCROLLBARW, doens't seem to be used at all in my use case so I can't test). However the same existance of the class.lpfnWndProc override cause issues, even if all what it's done in the overrider function (THEMING_DialogSubclassProc) is to return THEMING_CallOriginalClass (hWnd, msg, wParam, lParam); The code that set the override is this. originalProcs[i] = class.lpfnWndProc; class.lpfnWndProc = subclassProcs[i]; -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Lorenzo Ferrillo <lorenzofer(a)live.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression URL| |https://cdn.bethsoft.com/el | |derscrolls/oblivion/other/t | |es_construction_set_1.2.404 | |.exe -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #3 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- Added official link for the application. While the editor itself is free, if I recall correctly it need the base game to install. Gog and Steam release include it. An unofficial mirror, uploaded with Bethesda permission, is on nexus -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com --- Comment #4 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- I can not run ~/.wine/drive_c/Program\ Files/Bethesda\ Softworks/Oblivion/TESConstructionSet.exe, it shows a "wine: Unhandled page fault on read access to 65737341 at address 0089983A (thread 0024)" message. Did you install any native DLLs or use workarounds? Anyway, this problem seems to be from dialog subclassing. I have some patches that change subclassing to hooking instead. So they should fix this bug. I will send the patches around next week. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #5 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- No, the test was made with a clean prefix and no workaround. CS do crash if a d3d9 wrapper (like ENB or reshade) is present in the folder. Can you attach the pathes here so I can try if they fix the issue for good if they are mostly ready? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #6 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- (In reply to Lorenzo Ferrillo from comment #5)
No, the test was made with a clean prefix and no workaround. CS do crash if a d3d9 wrapper (like ENB or reshade) is present in the folder. Can you attach the pathes here so I can try if they fix the issue for good if they are mostly ready?
Could you try https://github.com/zzhiyi/wine/commits/dev then? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #7 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- Your fork works, and can also use the theme from winecfg -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 winebugs(a)63bit.net changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugs(a)63bit.net --- Comment #8 from winebugs(a)63bit.net --- Confirming this also affects every other version of the creation set/kit, including Skyrim, Fallout and Skyrim SE. Reverting 277daa7ea7e8a953a2f726ce9354af82ab4635da alone does not fix the regression. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #9 from winebugs(a)63bit.net --- Previous statement was wrong, reverting 277daa7ea7e8a953a2f726ce9354af82ab4635da does fix this issue (and some others like it) for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #10 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- Considering how much they share their codebases it doesn't surprise me of at all. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 --- Comment #11 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- @Zhiyi Zhang Confirming the this patch series fix this bug. (pulled into my the tkg build as userpatches) [PATCH 5/5] uxtheme: Support scroll bar state tracking in non-client areas. [PATCH 4/5] uxtheme: Support pressed state for themed scroll bars. [PATCH 3/5] uxtheme: Support drawing themed standard scroll bars. [PATCH 2/5] uxtheme: Move themed dialog to uxtheme. [PATCH 1/5] uxtheme: Move themed scroll bar to uxtheme. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gyebro69(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Lorenzo Ferrillo <lorenzofer(a)live.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |b0e51ead0d1c2ba305ba22c77a6 | |a84671c096e40 --- Comment #12 from Lorenzo Ferrillo <lorenzofer(a)live.it> --- the patches were committed. b0e51ead0d1c2ba305ba22c77a6a84671c096e40 commit include the relevant patch in the set Tested and confirm fixed. Thanks -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51137 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 6.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla