[Bug 38479] New: tab control: TAB_SetCurFocus ignores result TCN_SELCHANGING.
https://bugs.winehq.org/show_bug.cgi?id=38479 Bug ID: 38479 Summary: tab control: TAB_SetCurFocus ignores result TCN_SELCHANGING. Product: Wine Version: 1.7.39 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: ktmizugaki+wine(a)gmail.com Distribution: --- Created attachment 51321 --> https://bugs.winehq.org/attachment.cgi?id=51321 patch to take care of TCN_SELCHANGING result. depends on patch at https://bugs.winehq.org/show_bug.cgi?id=38363#c2 TAB_SetCurFocus -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38479 --- Comment #1 from teru <ktmizugaki+wine(a)gmail.com> --- im sorry, failed to input comment correctly...let me try again. TAB_SetCurFocus function in dlls/comctl32/tab.c ignores the result of TCN_SELCHANGING and change selection and focus unconditionally. it doesn't look correct to me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38479 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #2 from super_man(a)post.com --- You should send your effort into patches mailing list. Patches aren't picked from bugzilla into mainline. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38479 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, teru. A test you attached fails for me on every windows release from XP to 10. In fact for some reason I'm unable to make it notify a parent at all. What version did you use for testing? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38479 teru <ktmizugaki+wine(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51321|0 |1 is obsolete| | --- Comment #4 from teru <ktmizugaki+wine(a)gmail.com> --- Created attachment 54583 --> https://bugs.winehq.org/attachment.cgi?id=54583 use WS_CHILD when creating tab controller in test_TCN_SELCHANGING thank you for feedback. i confirmed that test fails on Windows. i did some trial and error and noticed that GetParent(hTab) returns NULL (because test_TCS_OWNERDRAWFIXED checks it...). WS_CHILD seems to be needed when creating tab control to make it notify parent window. attached new patch tested on Windows 7 Home Premium. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38479 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- Test was committed, https://source.winehq.org/git/wine.git/commit/413b2a031b8741c2c66c115374ef95.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org