[Bug 42657] New: ACDSee Pro 9 needs msvcr120.dll.? Alloc@Concurrency@@YAPEAX_K@Z
https://bugs.winehq.org/show_bug.cgi?id=42657 Bug ID: 42657 Summary: ACDSee Pro 9 needs msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z Product: Wine Version: 2.3 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: msvcrt Assignee: wine-bugs(a)winehq.org Reporter: spleefer90(a)gmail.com Distribution: --- Using very recent version of wine-git wine: Call from 0x7b44f8a7 to unimplemented function msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z, aborting -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Gijs Vermeulen <acescopezz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acescopezz(a)gmail.com --- Comment #1 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #0)
Using very recent version of wine-git
wine: Call from 0x7b44f8a7 to unimplemented function msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z, aborting
This is actually the same function (but the 64bit variant) as https://bugs.winehq.org/show_bug.cgi?id=42658 stub -arch=win32 ?Alloc(a)Concurrency@@YAPAXI(a)Z stub -arch=win64 ?Alloc(a)Concurrency@@YAPEAX_K(a)Z
From what I have seen, Piotr likes to only have 1 bug for the same function. So my advice would be to resolve this bug as a duplicate of https://bugs.winehq.org/show_bug.cgi?id=42658
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #2 from C0rn3j <spleefer90(a)gmail.com> ---
This is actually the same function (but the 64bit variant)
How can I check for that in the future?
So my advice would be to resolve this bug as a duplicate of 42658
Not that I really care, close whichever you want, but I actually submitted this bug before the one you mention, this bug ID is 42657 ^^ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #3 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #2)
This is actually the same function (but the 64bit variant)
How can I check for that in the future?
So my advice would be to resolve this bug as a duplicate of 42658
Not that I really care, close whichever you want, but I actually submitted this bug before the one you mention, this bug ID is 42657 ^^
You can grep the function the wine source and you can see it there :) And I don't really mind either, but we'll see what Piotr prefers :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #4 from Gijs Vermeulen <acescopezz(a)gmail.com> --- Created attachment 57593 --> https://bugs.winehq.org/attachment.cgi?id=57593 stub test (In reply to C0rn3j from comment #2)
This is actually the same function (but the 64bit variant)
How can I check for that in the future?
So my advice would be to resolve this bug as a duplicate of 42658
Not that I really care, close whichever you want, but I actually submitted this bug before the one you mention, this bug ID is 42657 ^^
You can grep the function the wine source and you can see it there :) And I don't really mind either, but we'll see what Piotr prefers :) Could you try this patch? (it's my first one, so if it doesn't work, please forgive me) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Gijs Vermeulen <acescopezz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57593|0 |1 is obsolete| | --- Comment #5 from Gijs Vermeulen <acescopezz(a)gmail.com> --- Created attachment 57596 --> https://bugs.winehq.org/attachment.cgi?id=57596 stub test v2 Other patch was wrong, please test this one. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #6 from C0rn3j <spleefer90(a)gmail.com> --- Now it's complaining about unimplemented msvcr120.dll.?Free(a)Concurrency@@YAXPEAX(a)Z instead of msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #7 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #6)
Now it's complaining about unimplemented
msvcr120.dll.?Free(a)Concurrency@@YAXPEAX(a)Z
instead of
msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z
That function is unimplemented as well. That -should- mean that my patch works :) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr.caban(a)gmail.com --- Comment #8 from Piotr Caban <piotr.caban(a)gmail.com> --- (In reply to Gijs Vermeulen from comment #1)
From what I have seen, Piotr likes to only have 1 bug for the same function. So my advice would be to resolve this bug as a duplicate of https://bugs.winehq.org/show_bug.cgi?id=42658 I don't really mind. I'm ok with having bugs for multiple runtime version and 32/64-bit variants. I've resolved the bug you're mentioning as duplicate by mistake (but I thought that it's not useful to reopen it). Sorry for that.
-- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Gijs Vermeulen <acescopezz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57596|0 |1 is obsolete| | --- Comment #9 from Gijs Vermeulen <acescopezz(a)gmail.com> --- Created attachment 57598 --> https://bugs.winehq.org/attachment.cgi?id=57598 stub test v3 (In reply to Piotr Caban from comment #8)
I don't really mind. I'm ok with having bugs for multiple runtime version and 32/64-bit variants. I've resolved the bug you're mentioning as duplicate by mistake (but I thought that it's not useful to reopen it). Sorry for that.
Okay :) I'm attaching the latest version of my patch here too. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #10 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #6)
Now it's complaining about unimplemented
msvcr120.dll.?Free(a)Concurrency@@YAXPEAX(a)Z
instead of
msvcr120.dll.?Alloc(a)Concurrency@@YAPEAX_K(a)Z
Could you try this patch and see if it works? https://source.winehq.org/patches/data/131509 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #11 from C0rn3j <spleefer90(a)gmail.com> --- c0rn3j(a)c0rn3jDesktop ~/wine master git apply s.patch s.patch:86: trailing whitespace. FIXME("(%ld, %p) stub\n", _NumBytes, p); s.patch:87: trailing whitespace. return p; warning: 2 lines add whitespace errors. It's building now, watch out for those whitespaces next time ^^ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #12 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #11)
c0rn3j(a)c0rn3jDesktop ~/wine master git apply s.patch
s.patch:86: trailing whitespace. FIXME("(%ld, %p) stub\n", _NumBytes, p); s.patch:87: trailing whitespace. return p; warning: 2 lines add whitespace errors.
It's building now, watch out for those whitespaces next time ^^
Thanks for the tips, I'll resend/reattach a fixed patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #13 from C0rn3j <spleefer90(a)gmail.com> --- It never ends! Looks like your patch is working for both functions though! wine: Call from 0x7b44cd6c to unimplemented function msvcr120.dll.?_NewCollection(a)_AsyncTaskCollection@details(a)Concurrency@@SAPEAV123(a)PEAV_CancellationTokenState@23@@Z, aborting On another note, how would I apply a new patch to my cloned git repo? It seems to screw up everything, I've no idea how to start with a clean slate except for wiping everything and redownloading it again -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #14 from Gijs Vermeulen <acescopezz(a)gmail.com> --- (In reply to C0rn3j from comment #13)
It never ends! Looks like your patch is working for both functions though!
wine: Call from 0x7b44cd6c to unimplemented function msvcr120.dll. ?_NewCollection(a)_AsyncTaskCollection@details(a)Concurrency@@SAPEAV123(a)PEAV_Canc ellationTokenState(a)23@@Z, aborting
On another note, how would I apply a new patch to my cloned git repo? It seems to screw up everything, I've no idea how to start with a clean slate except for wiping everything and redownloading it again
Copy the patch to your repo root. Then run "patch -p1 < nameofpatch.patch". And if you want to revert the patch run "patch -R -p1 < nameofpatch.patch". I've sent updated patches btw. patch 1 v2: https://source.winehq.org/patches/data/131512 patch 2 v2: https://source.winehq.org/patches/data/131513 The whitespace stuff should be fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #15 from Gijs Vermeulen <acescopezz(a)gmail.com> --- This bug should be fixed by: https://source.winehq.org/git/wine.git/commit/32a4bec9099676ce1ade3fbd287119... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Piotr Caban <piotr.caban(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |32a4bec9099676ce1ade3fbd287 | |1195f9596686c --- Comment #16 from Piotr Caban <piotr.caban(a)gmail.com> --- The Concurrency::Alloc function is implemented. Marking as fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #17 from C0rn3j <spleefer90(a)gmail.com> --- Confirming, it still crashes on wine: Call from 0x7b44cd6c to unimplemented function msvcr120.dll.?_NewCollection(a)_AsyncTaskCollection@details(a)Concurrency@@SAPEAV123(a)PEAV_CancellationTokenState@23@@Z, aborting Gonna make a new bug report. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 --- Comment #18 from Matteo Bruni <matteo.mystral(a)gmail.com> --- Sorry for the spam... (In reply to Gijs Vermeulen from comment #14)
(In reply to C0rn3j from comment #13)
On another note, how would I apply a new patch to my cloned git repo? It seems to screw up everything, I've no idea how to start with a clean slate except for wiping everything and redownloading it again
That seems suboptimal :) You can take a look at https://wiki.winehq.org/Git_Wine_Tutorial although that probably doesn't quite cover your needs. It depends on how you want to manage your git tree but e.g. you could do inside your git working directory: git reset --hard origin/master #restore your working directory to upstream, discard all local changes git pull #update your git tree with new commits from upstream
Copy the patch to your repo root. Then run "patch -p1 < nameofpatch.patch". And if you want to revert the patch run "patch -R -p1 < nameofpatch.patch".
You never want to use plain patch in a git tree. If the patch is in the mbox format (which is the case e.g. for the patches on https://source.winehq.org/patches/) you probably want to do "git am filename.patch". Otherwise just "git apply filename.patch". -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #19 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42657 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.0.x |--- --- Comment #20 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 2.0.x milestone from bugs included in 2.0.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org