[Bug 49583] New: Assassin's Creed Odyssey displays black bars on top and bottom.
https://bugs.winehq.org/show_bug.cgi?id=49583 Bug ID: 49583 Summary: Assassin's Creed Odyssey displays black bars on top and bottom. Product: Wine Version: 5.13 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: GloriousEggroll(a)gmail.com Distribution: --- Created attachment 67739 --> https://bugs.winehq.org/attachment.cgi?id=67739 AC Odyssey black bar fix It's been a long known issue that AC: Odyssey renders with black bars on the top and bottom of the screen (see screenshot 1). Derek Lesho came up with a stub patch that both fixed this -and- allowed STEEP to run (it would not display previously). That patch can be found here: https://github.com/GloriousEggroll/proton-ge-custom/blob/5.12-GE-1/patches/g... Recently, the relevant function QueryDisplayConfig was implemented, however it did not contain some of the changes Derek's patch adds. This allowed steep to work, however AC: Odyssey still retained the black bar issue. I modified Derek's patch by adding the relevant parts to QueryDisplayConfig, and removing the relevant flag checks (Derek's patch did this previously), and this allowed AC: Odyssey to render properly without the black bars. (see screenshot 2). The patch is hacky but may provide more information towards fixing this properly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 --- Comment #1 from GloriousEggroll(a)gmail.com --- Created attachment 67740 --> https://bugs.winehq.org/attachment.cgi?id=67740 ac odyssey with black bars -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 --- Comment #2 from GloriousEggroll(a)gmail.com --- Created attachment 67741 --> https://bugs.winehq.org/attachment.cgi?id=67741 ac odyssey with bars fixed -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-sta | |ging/winae-staging/tree/mas | |ter/patches/user32-QueryDis | |playConfig CC| |leslie_alistair(a)hotmail.com Status|UNCONFIRMED |STAGED Ever confirmed|0 |1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 Brendan Shanks <bshanks(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bshanks(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Staged patchset|https://github.com/wine-sta |https://github.com/wine-sta |ging/winae-staging/tree/mas |ging/wine-staging/tree/mast |ter/patches/user32-QueryDis |er/patches/user32-QueryDisp |playConfig |layConfig -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 --- Comment #3 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Is this still an issue? I tested wine-staging 5.16 and it seems fine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #4 from Zebediah Figura <z.figura12(a)gmail.com> --- (In reply to Zhiyi Zhang from comment #3)
Is this still an issue? I tested wine-staging 5.16 and it seems fine.
There's a wine-staging patch for this, so I'd expect it to work. Does this work with upstream wine? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=49583 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |fgouget(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=49583 Giacomo Orlandi <gia_@inwind.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gia_@inwind.it --- Comment #5 from Giacomo Orlandi <gia_@inwind.it> --- The staged patchset linked here was removed in the following commit: https://gitlab.winehq.org/wine/wine-staging/-/commit/117d2b210700c747799b229... It appears this removal was not due to the patchset being fully implemented upstream, but rather because QueryDisplayConfig was moved from user32 to win32u, probably causing the patch to no longer apply cleanly: https://gitlab.winehq.org/wine/wine/-/commit/c2c9112bf8896d49a6af1ca1f73e563... The commit log shows that additional changes and improvements to QueryDisplayConfig were made over time. However, it’s unclear whether those changes fully incorporate the fix originally provided by the staged patchset. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
WineHQ Bugzilla -
WineHQ Bugzilla