[Bug 38796] New: dwrite analyzer test crashes on my system
https://bugs.winehq.org/show_bug.cgi?id=38796 Bug ID: 38796 Summary: dwrite analyzer test crashes on my system Product: Wine Version: 1.7.45 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: dwrite Assignee: wine-bugs(a)winehq.org Reporter: bernhardu(a)vr-web.de Distribution: Debian Created attachment 51724 --> https://bugs.winehq.org/attachment.cgi?id=51724 stdout of the test run See attached file. For some reason gdiinterop_CreateFontFromLOGFONT seems to fail. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 --- Comment #1 from Bernhard Übelacker <bernhardu(a)vr-web.de> --- In this test the call to create_fontface comes down to systemfontfileenumerator_GetCurrentFontFile. There it calls RegEnumValueW to enumerate the fonts in HKLM\Software\Microsoft\Windows NT\CurrentVersion\Fonts. With two calls, one for getting the required buffer length, one to retrieve the content. In my case the font "Tahoma Bold" has value which is 109 characters long. (I probably have too many subdirectories and the value is generated from drive Z:) Unfortunately the first call to RegEnumValueW calls NtEnumerateValueKey just with an fixed buffer and returns with a too low needed buffer size. Then the second call to RegEnumValueW also fails with the too small buffer. Attached patch changes RegEnumValueW to retrieve the correct needed buffer size. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 --- Comment #2 from Bernhard Übelacker <bernhardu(a)vr-web.de> --- Created attachment 51725 --> https://bugs.winehq.org/attachment.cgi?id=51725 advapi32: Fix RegEnumValueW when enumerating long values. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 --- Comment #3 from Bernhard Übelacker <bernhardu(a)vr-web.de> --- Sent to wine-patches http://source.winehq.org/patches/data/112210 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|dwrite |advapi32 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 --- Comment #4 from Bernhard Übelacker <bernhardu(a)vr-web.de> --- Even while sent patch fixes the Wine implementation, the tests do not succeed on Windows. So Windows does not to support RegEnumValue being called with value or val_count as NULL. Currently RegEnumValue is also used that way in Wine itself, so fixing it right now would lead to more problems. Therefore trying to get something in to have these RegEnumValue covered by tests. Then changing these RegEnumValue uses and as last change RegEnumValue itself. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 Bernhard Übelacker <bernhardu(a)vr-web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51725|0 |1 is obsolete| | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 Bernhard Übelacker <bernhardu(a)vr-web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Bernhard Übelacker <bernhardu(a)vr-web.de> --- A patch fixing this issue got accepted: http://source.winehq.org/git/wine.git/commit/119501fee8bffcab6ced16282ed12ca... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |119501fee8bffcab6ced16282ed | |12ca7d0f564ec --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Thanks for fixing this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38796 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.47. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org