[Bug 42538] New: wined3d checks for a wrong GL_VENDOR in wined3d_guess_gl_vendor
https://bugs.winehq.org/show_bug.cgi?id=42538 Bug ID: 42538 Summary: wined3d checks for a wrong GL_VENDOR in wined3d_guess_gl_vendor Product: Wine Version: 2.2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: kamil.hornicek(a)reactos.org Distribution: --- The check >if (strstr(gl_vendor_string, "Mesa")< in wined3d/directx.c:1729 is wrong. Mesa presents itself with GL_VENDOR = "Brian Paul" and GL_RENDERER = "Mesa" as can be seen here: https://cgit.freedesktop.org/mesa/mesa/tree/src/mesa/main/getstring.c#n115 Even though the code works because it later checks for GL_RENDERER == "Mesa" it still should be fixed. This was also previously fixed in wined3d_guess_card_vendor. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42538 --- Comment #1 from Henri Verbeet <hverbeet(a)gmail.com> --- Is this causing an actual issue, or is this theoretical? It's true that the default implementation returns "Brian Paul"/"Mesa", but specific drivers can and do return their own strings for this. These strings have also changed between versions. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42538 Kamil Hornicek <kamil.hornicek(a)reactos.org> changed: What |Removed |Added ---------------------------------------------------------------------------- OS|Linux |other --- Comment #2 from Kamil Hornicek <kamil.hornicek(a)reactos.org> --- At first let me apologize for forgetting to set the right OS. It should read ReactOS. In our case it's not theoretical. Second - GL_VENDOR is set to "Brian Paul" since at least 2005 as you can see here https://cgit.freedesktop.org/mesa/mesa/commit/src/mesa/main/getstring.c?id=1... and you are already checking for the correct vendor in wined3d_guess_card_vendor. Would it be possible to add yet another check for GL_VENDOR == Brian Paul as was done in wined3d_guess_card_vendor a while ago? I realize that it doesn't really fix or improve anyting for you, but at least your code would be consistent. If not, thanks for your time anyway. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42538 --- Comment #3 from Henri Verbeet <hverbeet(a)gmail.com> --- (In reply to Kamil Hornicek from comment #2)
Would it be possible to add yet another check for GL_VENDOR == Brian Paul as was done in wined3d_guess_card_vendor a while ago? I realize that it doesn't really fix or improve anyting for you, but at least your code would be consistent. If not, thanks for your time anyway.
Sure, adding an explicit check for GL_VENDOR "Brian Paul" is fine. I initially read the bug report as asking for the removal of the GL_VENDOR "Mesa" check, which I think would be more problematic. I'm still curious what set of GL_VENDOR and GL_RENDERER strings causes an issue here though. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42538 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de Status|UNCONFIRMED |STAGED Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wined3d-wined3 | |d_guess_gl_vendor Ever confirmed|0 |1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42538 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv(a)dawncrow.de Staged patchset|https://github.com/wine-com |https://github.com/wine-sta |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast |ster/patches/wined3d-wined3 |er/patches/wined3d-wined3d_ |d_guess_gl_vendor |guess_gl_vendor -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42538 Giacomo Orlandi <gia_@inwind.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gia_@inwind.it --- Comment #4 from Giacomo Orlandi <gia_@inwind.it> --- This is not staged anymore since this commit: https://gitlab.winehq.org/wine/wine-staging/-/commit/391e9e4f31e6ed6e06315ad... Based on the commit message, it seems the original change was ReactOS-specific and is no longer relevant. Given that, perhaps this bug should be marked as abandoned? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42538 André Z. <nerv@dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|STAGED |RESOLVED Resolution|--- |ABANDONED -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42538 Giacomo Orlandi <gia_@inwind.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|gia_@inwind.it | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42538 Gijs Vermeulen <gijsvrm@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Gijs Vermeulen <gijsvrm@gmail.com> --- Closing ABANDONED. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla