[Bug 51589] New: Buttons have no icons when using the Light Blue theme
https://bugs.winehq.org/show_bug.cgi?id=51589 Bug ID: 51589 Summary: Buttons have no icons when using the Light Blue theme Product: Wine-staging Version: 6.14 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: oguilherme(a)protonmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- I noticed that buttons on the SUMo Update app have no icons on them after setting the Wine theme to Light Blue in winecfg. Steps to reproduce: 1. Set Wine theme to Light Blue using winecfg. 2. Download SUMo Update portable: https://www.kcsoftwares.com/files/sumo.zip 3. Run SUMo.exe 4. Notice the buttons have no icons -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 --- Comment #1 from Guilherme S. <oguilherme(a)protonmail.com> --- Created attachment 70437 --> https://bugs.winehq.org/attachment.cgi?id=70437 No theme (correct) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 --- Comment #2 from Guilherme S. <oguilherme(a)protonmail.com> --- Created attachment 70438 --> https://bugs.winehq.org/attachment.cgi?id=70438 Light blue theme (incorrect) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zzhang(a)codeweavers.com Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Confirmed with wine-staging git bdb9f49. The related patch is comctl32-version_6. When the application detects that the comctl32 version is 6, it uses theming drawing, which eventually calls an unimplemented function DrawThemeIcon(). With wine having version 5 in comctl32, the application disables theming for its buttons. I will look into implementing DrawThemeIcon() later if no one else takes this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |zzhang(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 --- Comment #4 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 70469 --> https://bugs.winehq.org/attachment.cgi?id=70469 Implement DrawThemeIcon -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70469|0 |1 is obsolete| | --- Comment #5 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Created attachment 70470 --> https://bugs.winehq.org/attachment.cgi?id=70470 Implement DrawThemeIcon v2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #6 from winetest(a)luukku.com --- wasn't this fixed recently upstream? https://source.winehq.org/patches/data/212376 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Zhiyi Zhang <zzhang(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |ea430bf2b751c7a43328adf5daf | |e22ac1c971fa6 --- Comment #7 from Zhiyi Zhang <zzhang(a)codeweavers.com> --- Fixed by ea430bf2b751c7a43328adf5dafe22ac1c971fa6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |uxtheme Product|Wine-staging |Wine --- Comment #8 from Zebediah Figura <z.figura12(a)gmail.com> --- I'm going to call this a bug in wine exposed by a wine-staging patch, and change the product accordingly. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=51589 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.0-rc2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla