[Bug 44408] New: Tetris for Windows has wrong colors for the game pieces and the score box
https://bugs.winehq.org/show_bug.cgi?id=44408 Bug ID: 44408 Summary: Tetris for Windows has wrong colors for the game pieces and the score box Product: Wine Version: 3.0 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: mikeonthecomputer(a)gmail.com Distribution: --- Created attachment 60331 --> https://bugs.winehq.org/attachment.cgi?id=60331 Tetris with wrong colors This game is the 16-bit EXE from the Windows Entertainment Pack, dated 1991. While playing, the pieces look like they might have inverted colors, very distracting. Wine 3.0 is exhibiting this issue while Wine 2.0 played the game correctly. Both cases, running on 64-bit Arch Linux with a 64-bit wine prefix. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de --- Comment #1 from Fabian Maurer <dark.shadow4(a)web.de> --- Can you provide a download? Also, if it used to work, can you do a regression test? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 --- Comment #2 from Mike Swanson <mikeonthecomputer(a)gmail.com> --- Can't provide one legally, but it's honestly not hard to find online. I did attempt to do a git-bisect, but there seems to have been various points in Wine 2.x development that 16-bit programs wouldn't load at all, plus a FreeType compatibility change. It has proven to be difficult. I'll let you know if I can pinpoint where it went wrong. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW URL| |https://archive.org/details | |/TETRIS_201612 Ever confirmed|0 |1 Keywords| |download, regression --- Comment #3 from Fabian Maurer <dark.shadow4(a)web.de> --- Found it on archive.org, that should be fine. I can confirm the issue, it works on wine-1.9.20, while it's broken on latest wine. I'll add a more detailed regression test later. Sidenote, I'm also on Arch and for regression testing I use "freetype2 2.7.1-2" and "lib32-freetype2 2.7.1-2", so the freetype compatibility change doesn't affect my tests. But as I said, I can do it later, just give me a few hours. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Mike Swanson <mikeonthecomputer(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 --- Comment #4 from Mike Swanson <mikeonthecomputer(a)gmail.com> --- I ended up installing Debian Stretch in a VirtualBox VM, since it's able to build and run Wine from 2.0 to current. I've found the commit that introduced the problem with the graphics, it is commit a60144ee74e1db170f04edeb8cfd3a5a17d36d46 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |huw(a)codeweavers.com Regression SHA1| |a60144ee74e1db170f04edeb8cf | |d3a5a17d36d46 --- Comment #5 from Zebediah Figura <z.figura12(a)gmail.com> --- Recording commit details here and CC'ing Huw: commit a60144ee74e1db170f04edeb8cfd3a5a17d36d46 Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Jan 26 09:30:20 2017 +0000 user32: Disable cached DCs once they are released. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- The app is calling GetDeviceCaps(NUMCOLORS) on a released DC: 0031:Call USER.66: GETDC(0000) ret=11cf:1f42 ds=11d6 0031:Ret USER.66: GETDC() retval=000a0048 ret=11cf:1f42 ds=11d6 0031:Call GDI.80: GETDEVICECAPS(0048,0068) ret=11cf:1f4f ds=11d6 0031:Ret GDI.80: GETDEVICECAPS() retval=00000000 ret=11cf:1f4f ds=11d6 0031:Call GDI.80: GETDEVICECAPS(0048,0026) ret=11cf:1f5f ds=11d6 0031:Ret GDI.80: GETDEVICECAPS() retval=0000be99 ret=11cf:1f5f ds=11d6 0031:Call USER.68: RELEASEDC(0000,0048) ret=11cf:1f7e ds=11d6 0031:Ret USER.68: RELEASEDC() retval=00000001 ret=11cf:1f7e ds=11d6 0031:Call GDI.80: GETDEVICECAPS(0048,0018) ret=11cf:1f9b ds=11d6 0031:Ret GDI.80: GETDEVICECAPS() retval=00000000 ret=11cf:1f9b ds=11d6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Omega Software <development(a)winomega.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |development(a)winomega.com --- Comment #7 from Omega Software <development(a)winomega.com> --- Hi Not sure if it could be related, but see bug 44713. It was introduced by the same commit, and later fixed in commit 9ea33ed00a242392a7c19dbb51afb54c0770d178: Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Aug 22 12:42:34 2017 +0100 gdi32: Cache the device caps from the reference dc, since the dc may become invalid. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #8 from joaopa <jeremielapuree(a)yahoo.fr> --- Is still a bug in current wine(3.20)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Omega Software <development(a)winomega.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|development(a)winomega.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 --- Comment #9 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 62808 --> https://bugs.winehq.org/attachment.cgi?id=62808 screenshot xp Yes, still present as of wine-3.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 --- Comment #10 from Fabian Maurer <dark.shadow4(a)web.de> --- Created attachment 62809 --> https://bugs.winehq.org/attachment.cgi?id=62809 screenshot wine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Gijs Vermeulen <gijsvrm(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |0778945e34968c66ccbe8a8be1f | |9749b8383f55e Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #11 from Gijs Vermeulen <gijsvrm(a)gmail.com> --- I tested <https://source.winehq.org/git/wine.git/commit/0778945e34968c66ccbe8a8be1f9749b8383f55e> and can confirm that it fixes this issue. Marking FIXED. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #12 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.0-rc6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |4.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|4.0.x |--- --- Comment #13 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 4.0.x milestone from bug fixes included in 4.0.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=44408 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|user32 |user16 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla