[Bug 57215] New: cnc-ddraw OpenGL renderer is broken again in 9.18
https://bugs.winehq.org/show_bug.cgi?id=57215 Bug ID: 57215 Summary: cnc-ddraw OpenGL renderer is broken again in 9.18 Product: Wine Version: 9.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winex11.drv Assignee: wine-bugs(a)winehq.org Reporter: i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com CC: rbernon(a)codeweavers.com Regression SHA1: 0a17c3b86fd4eb917367e36261fa276c6753d3b3 Distribution: --- Hello again. Rémi, sorry, quirky cnc-ddraw OpenGL has broken again in 9.18. But in contrast with previous performance regression from Bug 57070, now it is really broken: RA2 menu hangs and doesn't work completely. I bisected to the offending commit: 0a17c3b86fd4eb917367e36261fa276c6753d3b3 is the first bad commit commit 0a17c3b86fd4eb917367e36261fa276c6753d3b3 Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Wed Sep 18 10:29:38 2024 +0200 winex11: Also resize or re-create the GL drawable with XComposite child windows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57200 dlls/winex11.drv/opengl.c | 1 + 1 file changed, 1 insertion(+) I see it fixes a bug for another game, that's unfortunate. I don't know what else we can do here. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #1 from Rémi Bernon <rbernon(a)codeweavers.com> --- No worries, thanks for reporting the issue. These are sensitive parts of the code, and I'm making large architectural changes so I'm kind of expecting breakages. As long as it's easy to reproduce it should not be too difficult to fix. I'll have a look. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #2 from Rémi Bernon <rbernon(a)codeweavers.com> --- I couldn't reproduce it though, would you mind attaching your ddraw.ini config? Also, a WINEDEBUG=+pid,+tid,+timestamp,+loaddll,+win,+wgl,+x11drv,+event log might be helpful. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #3 from Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> --- Oof, isn't it too cumbersome for you? cnc-ddraw does actually have a workaround for that. Setting 'fixchilds=3' helps same as the last time. The menu becames a bit glitchy, but it works. Anyway, I will post the info. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #4 from Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> --- Created attachment 77136 --> https://bugs.winehq.org/attachment.cgi?id=77136 Wine debug log Here is a debug log. It actually hangs along with the game at the line 17295. Then continues when I killed the game process. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #5 from Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> --- Created attachment 77137 --> https://bugs.winehq.org/attachment.cgi?id=77137 ddraw.ini Here is ddraw.ini. It is effectively same as default. The only noticable difference is 'renderer=opengl'. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #6 from Rémi Bernon <rbernon(a)codeweavers.com> --- Created attachment 77138 --> https://bugs.winehq.org/attachment.cgi?id=77138 Possible fix I see, I think it hangs for me as well but only occasionally after several clicks on the menu. Does the attached patch help for you too? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #7 from Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> --- Yes, it works. Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |430eec64822c18d1005866f2bee | |d811c97f53b73 Status|UNCONFIRMED |RESOLVED --- Comment #8 from Rémi Bernon <rbernon(a)codeweavers.com> --- Should be fixed with 430eec64822c18d1005866f2beed811c97f53b73, sorry for breaking it again -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 --- Comment #9 from Hanabishi <i.r.e.c.c.a.k.u.n+bugs.winehq.org(a)gmail.com> --- Don't worry. For the last few releases, I intentionally search for regressions across all apps I have. In fact, after seeing winex11/OpenGL-related stuff in the changelog, I predicted that it would affect something and immediately went testing RA2. And it actually did. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57215 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.19. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla