[Bug 10386] New: Internet Explorer 1 fails to start
http://bugs.winehq.org/show_bug.cgi?id=10386 Summary: Internet Explorer 1 fails to start Product: Wine Version: 0.9.35. Platform: PC URL: http://appdb.winehq.org/objectManager.php?sClass=version &iId=5289&iTestingId=13192 OS/Version: Linux Status: NEW Keywords: download, regression Severity: enhancement Priority: P2 Component: wine-misc AssignedTo: wine-bugs(a)winehq.org ReportedBy: alex(a)thehandofagony.com Starting with Wine 0.9.35, Internet Explorer 1 does not start. It only displays the following messages on the console fixme:shell:SHRegisterDragDrop (0x1002a,0x1628b4):stub. err:ole:RegisterDragDrop COM not initialized fixme:shell:SHRevokeDragDrop (0x1002a):stub. The shell fixmes appear in 0.9.34 too, but not the ole error. Regression test to follow. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rob(a)codeweavers.com Severity|enhancement |normal --- Comment #1 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-11-10 11:02:08 --- Regression caused by following commit, adding author to CC list commit 2d8ae2cf8320df853070c31b6737db3789a4a411 Author: Rob Shearman <rob(a)codeweavers.com> Date: Thu Apr 5 11:32:32 2007 +0100 ole32: Check for COM not being initialised and an invalid window handle being input to RegisterDragDrop. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|wine-misc |wine-ole -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 --- Comment #2 from Rob Shearman <rob(a)codeweavers.com> 2007-11-10 11:15:28 --- As you can see by the commit, it's fully tested and the commit fixes tests. Something in shell32 has to call OleInitialize, probably SHRegisterDragDrop. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|wine-ole |wine-shell32 --- Comment #3 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-11-10 11:34:38 --- Yes I can see that. :) But it made me realize the component should be shell32. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 --- Comment #4 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2007-12-11 03:37:53 --- Created an attachment (id=9596) --> (http://bugs.winehq.org/attachment.cgi?id=9596) proposed patch The following patch fixes IE 1, but is it correct? It initializes OLE on SHRegisterDragDrop() and uninitalizes it on SHRevoeDragDrop(), but can we be sure that these calls will be balanced like they are in iE1? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 --- Comment #5 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-03-01 13:31:07 --- Created an attachment (id=11065) --> (http://bugs.winehq.org/attachment.cgi?id=11065) patch I've done some tests what different Windows flavors do and Windows 98 does OleInitialize in SHRegisterDragDrop so I think we can do it too. Could you test this patch? I'd be surprised if there were a OleUninitialize in SHRevokeDragDrop. I think it's more probably to have another OleInitialize but we should also check what Windows 98 does. BTW this call got removed from Windows Vista. Does MSIE 1.0 work there? (but I'd expect that they check if the GetProcAddress returns NULL). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 --- Comment #6 from Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> 2008-03-03 13:46:22 --- Your patch allows Internet Explorer 1.0 to start in Wine. :) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 --- Comment #7 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-03-08 15:46:46 --- Created an attachment (id=11236) --> (http://bugs.winehq.org/attachment.cgi?id=11236) test program The patch got accepted into Git and is available in Wine 0.9.57. The behaviour of these functions depends on Windows versions so I didn't include a testcase in the patch but I will attach some test code I used to this bug in case someone would need to check it/improve it. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikolaj.zalewski(a)gmail.com Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-03-08 15:47:15 --- Resolving fixed -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=10386 Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2008-03-08 15:47:37 --- Closing -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org