[Bug 47124] New: Wine+eventfd_synchronization patches build fails
https://bugs.winehq.org/show_bug.cgi?id=47124 Bug ID: 47124 Summary: Wine+eventfd_synchronization patches build fails Product: Wine-staging Version: 4.7 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: shtetldik(a)gmail.com CC: leslie_alistair(a)hotmail.com, z.figura12(a)gmail.com Distribution: --- I tried building Wine + eventfd_synchronization patches from staging (applying only them using ./patchinstall.sh DESTDIR="$wine_src" eventfd_synchronization The build is failing like this (both on Wine master and Wine b47938273): gcc -m64 -c -o trace.o /home/user/build/wine-git/source/server/trace.c -I. \ -I/home/user/build/wine-git/source/server -I../include \ -I/home/user/build/wine-git/source/include -D__WINESRC__ -Wall -pipe -fno-strict-aliasing \ -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wno-packed-not-aligned \ -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla \ -Wwrite-strings -Wpointer-arith -Wlogical-op -O3 -march=znver1 /home/user/build/wine-git/source/server/sock.c: In function ‘req_socket_cleanup’: /home/user/build/wine-git/source/server/sock.c:1345:20: error: too many arguments to function ‘enumerate_handles’ while ((sock = enumerate_handles(current->process, &sock_ops, &index, NULL))) ^~~~~~~~~~~~~~~~~ In file included from /home/user/build/wine-git/source/server/sock.c:64: /home/user/build/wine-git/source/server/handle.h:51:21: note: declared here extern obj_handle_t enumerate_handles( struct process *process, const struct object_ops *ops, ^~~~~~~~~~~~~~~~~ make[1]: *** [Makefile:1368: sock.o] Error 1 Probably dependency patch is not listed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #1 from Zebediah Figura <z.figura12(a)gmail.com> --- This should hopefully be fixed by <https://github.com/wine-staging/wine-staging/commit/b1997e35c9964fe5d3406620029c3586dd744277>; please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #2 from Shmerl <shtetldik(a)gmail.com> --- Somehow that didn't help. I also see some circular dependency there, since server-Desktop_Refcount depends on eventfd_synchronization. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #3 from Shmerl <shtetldik(a)gmail.com> --- This passed further: ./patchinstall.sh DESTDIR="$wine_src" eventfd_synchronization server-Desktop_Refcount But it's still failing later like this: ../../tools/winegcc/winegcc -o ntdll.dll.so -B../../tools/winebuild -m64 -fPIC -fasynchronous-unwind-tables \ -shared /home/user/build/wine-git/source/dlls/ntdll/ntdll.spec -nodefaultlibs \ -Wl,--image-base,0x7bc00000 actctx.o atom.o cdrom.o critsection.o debugbuffer.o debugtools.o \ directory.o env.o error.o esync.o exception.o file.o handletable.o heap.o large_int.o loader.o \ loadorder.o misc.o nt.o om.o path.o printf.o process.o reg.o relay.o resource.o rtl.o rtlbitmap.o \ rtlstr.o sec.o serial.o server.o signal_arm.o signal_arm64.o signal_i386.o signal_powerpc.o \ signal_x86_64.o string.o sync.o tape.o thread.o threadpool.o time.o version.o virtual.o wcstring.o \ version.res ../../dlls/winecrt0/libwinecrt0.a ../../libs/port/libwine_port.a -lrt -lpthread \ /usr/bin/ld: thread.o: in function `RtlCreateUserThread': thread.c:(.text+0x1688): undefined reference to `__syscall_NtCreateThread' /usr/bin/ld: thread.c:(.text+0x181c): undefined reference to `__syscall_NtCreateThreadEx' collect2: error: ld returned 1 exit status winegcc: gcc failed make[1]: *** [Makefile:1626: ntdll.dll.so] Error 2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #4 from Shmerl <shtetldik(a)gmail.com> --- I just built stock Wine master to make sure it's not my environment that's messed up, and it builds fine. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #5 from Zebediah Figura <z.figura12(a)gmail.com> --- Yes, that fix was badly done. It should be actually fixed now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 --- Comment #6 from Shmerl <shtetldik(a)gmail.com> --- Perfect, it works now. Thanks! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 Shmerl <shtetldik(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Shmerl <shtetldik(a)gmail.com> --- Fixed on wine-staging master. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |90ef849e7be63da7cb01ab9af9f | |1c71946386ec4 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=47124 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Closing Fixed Staging issue. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org