[Bug 54927] New: grepwinNP3 (part of Notepad3) crashes inside uxtheme
https://bugs.winehq.org/show_bug.cgi?id=54927 Bug ID: 54927 Summary: grepwinNP3 (part of Notepad3) crashes inside uxtheme Product: Wine Version: 8.7 Hardware: x86-64 URL: https://github.com/rizonesoft/Notepad3/releases/downlo ad/RELEASE_6.23.203.2/Notepad3_6.23.203.2_x64_Setup.ex e OS: Linux Status: NEW Keywords: download, source Severity: normal Priority: P2 Component: uxtheme Assignee: wine-bugs(a)winehq.org Reporter: xerox.xerox2000x(a)gmail.com Distribution: --- This is a kind of "grep with GUI": Unhandled exception: page fault on read access to 0x0000000000000004 in 64-bit code (0x0000006d5089f5). =>0 0x0000006d5089f5 DrawThemeTextEx+0x45(hTheme=000000000025CA20, hdc=0000000001410094, iPartId=0x2, iStateId=0, pszText=L"Regex search", iCharCount=0xffffffff, flags=0x2450, rect=00000000001FC400, options=0000000000000000) [/home/louis/sda2/wine64-build/../wine/dlls/uxtheme/draw.c:1790] in uxtheme (0x000000001fc400) Apparently crashes in next line because "options" pointer is NULL: if (options->dwFlags & ~(DTT_TEXTCOLOR | DTT_FONTPROP)) FIXME("unsupported flags 0x%08lx\n", options->dwFlags); -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54927 Mohamad Al-Jaf <mowinebugs(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mowinebugs(a)mail.com --- Comment #1 from Mohamad Al-Jaf <mowinebugs(a)mail.com> --- Created attachment 74456 --> https://bugs.winehq.org/attachment.cgi?id=74456 uxtheme: Add a NULL check for options parameter in DrawThemeTextEx(). Does this patch help? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54927 --- Comment #2 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Mohamad Al-Jaf from comment #1)
Created attachment 74456 [details] uxtheme: Add a NULL check for options parameter in DrawThemeTextEx().
Does this patch help?
Hi Mohammed, Yes it fixes the crash and allows the application to start. Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54927 Sagawa <sagawa.aki+winebugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagawa.aki+winebugs(a)gmail.c | |om --- Comment #3 from Sagawa <sagawa.aki+winebugs(a)gmail.com> --- For your reference, the code which calls DrawThemeTextEx with nullptr is no longer used. See the commit which imports a latest release from grepWin, https://github.com/rizonesoft/Notepad3/commit/9c148389142d6e45da4930bbdd824d... . -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54927 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #4 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- Still prsent in wine-10.17 (in the program release from the downloadlink) @Mohamad: Have you ever submitted the patch for review? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54927 --- Comment #5 from Mohamad Al-Jaf <mowinebugs(a)mail.com> --- (In reply to Louis Lenders from comment #4)
Still prsent in wine-10.17 (in the program release from the downloadlink)
@Mohamad: Have you ever submitted the patch for review?
Hi Louis, I haven't submitted it before as I didn't write a test for it. Made an MR now - https://gitlab.winehq.org/wine/wine/-/merge_requests/9287 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54927 --- Comment #6 from Mohamad Al-Jaf <mowinebugs(a)mail.com> --- Fixed in commit cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7 https://gitlab.winehq.org/wine/wine/-/commit/cdc4af0c266ce3f001f51edbaf2c6e3... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54927 Louis Lenders <xerox.xerox2000x(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED Fixed by SHA1| |cdc4af0c266ce3f001f51edbaf2 | |c6e3af2029ee7 --- Comment #7 from Louis Lenders <xerox.xerox2000x(a)gmail.com> --- (In reply to Mohamad Al-Jaf from comment #6)
Fixed in commit cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7
https://gitlab.winehq.org/wine/wine/-/commit/ cdc4af0c266ce3f001f51edbaf2c6e3af2029ee7
Yes, I can confirm that. Thanks Mohamad! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54927 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #8 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.20. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla