[Bug 33424] New: Armored Fist 3 crashes on start
http://bugs.winehq.org/show_bug.cgi?id=33424 Bug #: 33424 Summary: Armored Fist 3 crashes on start Product: Wine Version: 1.5.28 Platform: x86 URL: http://www.fileplanet.com/29182/20000/fileinfo/Armored -Fist-3-Demo OS/Version: Linux Status: NEW Keywords: download, regression Severity: normal Priority: P2 Component: gdi32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: gyebro69(a)gmail.com CC: sagawa.aki+winebugs(a)gmail.com Classification: Unclassified Regression SHA1: 3a9689106145c8585e917ae6f4f22226d87872ab Created attachment 44226 --> http://bugs.winehq.org/attachment.cgi?id=44226 terminal output The game crashes after the splash screen. This is a regression from 1.5.28: 3a9689106145c8585e917ae6f4f22226d87872ab is the first bad commit commit 3a9689106145c8585e917ae6f4f22226d87872ab Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Thu Mar 14 20:08:14 2013 +0900 gdi32: Improve outline text metrics calculation, especially if unitsPerEm is not power of 2. :040000 040000 a3ca6ac99d4a911065ccb15b7eace0973970ffa7 3db1753ec6890caf5fbba16f127da8c32b777129 M dlls Reverting the patch on the current git version fixes the problem. Fedora 18 freetype-2.4.10-4.fc18.i686 freetype-freeworld-2.4.10-3.fc18.i686 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #1 from Sagawa <sagawa.aki+winebugs(a)gmail.com> 2013-04-21 01:39:08 CDT --- Hello GyB, I'm afraid I can't reproduce the issue. Could you try to run with WINEDEBUG=font and attach the output? I'm guessing some of your system fonts had bad value at that time. But I can't find out which face was used then. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #2 from GyB <gyebro69(a)gmail.com> 2013-04-21 02:16:40 CDT --- Created attachment 44234 --> http://bugs.winehq.org/attachment.cgi?id=44234 +font debug log -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #3 from GyB <gyebro69(a)gmail.com> 2013-04-21 02:47:15 CDT --- 'winetricks corefonts tahoma' does not help, however, compiling Wine without optimization (CFLAGS=-O0 instead of -O2) makes the crash go away. gcc version 4.7.2 20121109 (Red Hat 4.7.2-8) (GCC) is installed here. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #4 from Sagawa <sagawa.aki+winebugs(a)gmail.com> 2013-05-04 11:20:01 CDT --- Created attachment 44369 --> http://bugs.winehq.org/attachment.cgi?id=44369 proposal patch Hi GyB, I made the proposal patch for this issue. Could try this? I can confirm the issue on Fedora 18. My change triggers wine crash when tmHeight has too big value, like -2147483648. I've not figured out yet where the value comes from. Maybe the application has an issue... Anyway, this patch truncates the ppem value when it exceeds 65,535. So the tmHeight value is always positive and never zero. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #5 from GyB <gyebro69(a)gmail.com> 2013-05-04 22:20:51 CDT --- (In reply to comment #4)
Created attachment 44369 [details] proposal patch
Hi GyB,
I made the proposal patch for this issue. Could try this?
I can confirm the issue on Fedora 18. My change triggers wine crash when tmHeight has too big value, like -2147483648. I've not figured out yet where the value comes from. Maybe the application has an issue...
Anyway, this patch truncates the ppem value when it exceeds 65,535. So the tmHeight value is always positive and never zero.
Hi Sagawa, The patch didn't make it any better, the game still crashes on launch. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 Sagawa <sagawa.aki+winebugs(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44369|0 |1 is obsolete| | --- Comment #6 from Sagawa <sagawa.aki+winebugs(a)gmail.com> 2013-05-06 09:59:55 CDT --- Created attachment 44383 --> http://bugs.winehq.org/attachment.cgi?id=44383 adds font height limit. (take 2) Hi, I've updated the patch. How about this? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #7 from GyB <gyebro69(a)gmail.com> 2013-05-06 10:21:00 CDT --- (In reply to comment #6)
Created attachment 44383 [details] adds font height limit. (take 2)
Hi, I've updated the patch. How about this?
This one works, thanks. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 --- Comment #8 from Sagawa <sagawa.aki+winebugs(a)gmail.com> 2013-05-08 06:55:36 CDT --- Thank you for testing. I'll sent the patch to wine-patches. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |8f8363ede62c74aa3369fa4c1e5 | |f9da7eafb18a7 Status|NEW |RESOLVED Resolution| |FIXED --- Comment #9 from Bruno Jesus <00cpxxx(a)gmail.com> 2013-05-08 16:09:53 CDT --- Patch commited: http://source.winehq.org/git/wine.git/?a=commit;h=8f8363ede62c74aa3369fa4c1e... Resolving fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=33424 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Alexandre Julliard <julliard(a)winehq.org> 2013-05-10 13:42:13 CDT --- Closing bugs fixed in 1.5.30. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org