[Bug 48480] New: dlls/krnl386.exe16 - thunk.c argument logic incorrect for CallProcEx32W16
https://bugs.winehq.org/show_bug.cgi?id=48480 Bug ID: 48480 Summary: dlls/krnl386.exe16 - thunk.c argument logic incorrect for CallProcEx32W16 Product: Wine Version: 5.0-rc6 Hardware: x86 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: dirk.niggemann(a)gmail.com CallProcEx32W16 takes a 'nrofargs' argument which may have the hight bit set by the caller (CPEX_DEST_CDECL). Internally the function processes nrofargs in a for loop but does not clear the high bit before looping. This line (2475): for (i=0;i<nrofargs;i++) This needs to be changed to support correct argument counting to: for (i=0;i<(nrofargs & ~CPEX_DEST_CDECL);i++) Otherwise this routine crashes when called with CPEX_DEST_CDECL set. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 --- Comment #1 from Alexandre Julliard <julliard(a)winehq.org> --- Do you have an application that uses this? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 --- Comment #2 from Dirk Niggemann <dirk.niggemann(a)gmail.com> --- Yes, trying to run Hp/Agilent Chemstation G1701BA MSCONFIG.EXE (configuration program). This is a now-ancient program to control GC/MS systems via GPIB (released 2000). Can't use any later versions as HP discontinued support for GPIB-based hardware after this version. Was planning on building a HP SICL to linux GPIB dll at some point to make this program fully work under wine. As it is the packages install OK and the data analysis program works (ish) but you have to copy the config (still uses win.ini!) from a working systems. As it is MSCONFIG.EXE crashes during startup with an unhandled exception. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 --- Comment #3 from Dirk Niggemann <dirk.niggemann(a)gmail.com> --- Yes, trying to run Hp/Agilent Chemstation G1701BA MSCONFIG.EXE (configuration program). This is a now-ancient program to control GC/MS systems via GPIB (released 2000). Can't use any later versions as HP discontinued support for GPIB-based hardware after this version. Was planning on building a HP SICL to linux GPIB dll at some point to make this program fully work under wine. As it is the packages install OK and the data analysis program works (ish) but you have to copy the config (still uses win.ini!) from a working systems. As it is MSCONFIG.EXE crashes during startup with an unhandled exception. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |win16 Component|-unknown |kernel32 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, Dirk. Thanks for the patch. Could we mark this report fixed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |c57483ba4d77d04a7af120a6e01 | |6b53c5596fe81 --- Comment #5 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by https://source.winehq.org/git/wine.git/?a=commit;h=c57483ba4d77d04a7af120a6e... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #6 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=48480 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #7 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla