[Bug 14293] New: winhelp: Vertical scroll bar is missing in some cases
http://bugs.winehq.org/show_bug.cgi?id=14293 Summary: winhelp: Vertical scroll bar is missing in some cases Product: Wine Version: 1.1.0 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: programs AssignedTo: wine-bugs(a)winehq.org ReportedBy: markk(a)clara.co.uk Sometimes the vertical scroll bar is incorrectly omitted, when there is text past the bottom of the window. To demonstrate, download chess.hlp from http://bugs.winehq.org/attachment.cgi?id=14571 Start Wine winhlp32, and without resizing its window, open chess.hlp. Click on "Article: What is GNU Chess". The bottom line is not shown but there is no vertical scroll bar. If you resize the window (e.g. reduce its width to make it narrower) the scroll bar may appear, but sometimes it does not, depending on the exact width you resize to. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 --- Comment #1 from Andrew Nguyen <arethusa26(a)gmail.com> 2008-12-22 01:56:44 --- I can't reproduce the problem in 1.1.11, so this seems to be fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 --- Comment #2 from Andrew Nguyen <arethusa26(a)gmail.com> 2008-12-22 02:07:48 --- This is actually still present. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 Jörg Höhle <hoehle(a)users.sourceforge.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.ah.smith(a)gmail.com, | |hoehle(a)users.sourceforge.net --- Comment #3 from Jörg Höhle <hoehle(a)users.sourceforge.net> 2009-03-07 11:44:09 --- The following commit made the scrollbars disappear between wine-1.1.6 and 1.1.7: commit c70f6a3933bc19b009f42f04164f4bbe0f6531b3 Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Sun Oct 19 04:43:17 2008 -0400 richedit: Use the DefWindowProc to implement WM_SETREDRAW. NB: The entry page typically shows scrollbars. You must navigate to another page to observe the effect, or return to the first page. I don't know why this bug was initially reported against 1.1.0. I also thought there was a problem earlier, but could not verify it any more. Somebody please change component to richedit -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-23 09:07:53 --- (In reply to comment #3)
Somebody please change component to richedit
Testing with native richedit actually shows the same bug, so this is a problem in winhlp32. It must have just depended on previously buggy behaviour in Wine's richedit control. The winhlp32 bug I can confirm. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-23 09:41:49 --- The problem was only that the scrollbars weren't invalidated, so they weren't being redrawn. Instead of using InvalidateRect to invalidate all of the client area, I used RedrawWindow to also invalidate the non-client area that includes the scrollbar. I sent my patch fixing the bug to wine-patches. winhlp32: Invalidate scrollbar when changing pages. (Bug 14293) http://www.winehq.org/pipermail/wine-patches/2009-March/070961.html -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 --- Comment #6 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-24 21:06:46 --- (In reply to comment #5)
winhlp32: Invalidate scrollbar when changing pages. (Bug 14293) http://www.winehq.org/pipermail/wine-patches/2009-March/070961.html
In git as commit 2592fea305c9876686c2e17711abbb8b2d90c2aa. Could you retest to confirm that it is fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 --- Comment #7 from Jörg Höhle <hoehle(a)users.sourceforge.net> 2009-03-26 05:46:45 --- I can commit that the patch works fine with the half dozen .hlp files I tried. However I'm not the OP nor do I have Bugzilla privileges, so I cannot mark this issue as fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 Dylan Smith <dylan.ah.smith(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #8 from Dylan Smith <dylan.ah.smith(a)gmail.com> 2009-03-26 07:02:31 --- Thanks for testing, I can report it fixed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=14293 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #9 from Alexandre Julliard <julliard(a)winehq.org> 2009-03-27 13:52:56 --- Closing bugs fixed in 1.1.18. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org