[Bug 20695] New: Cannot scroll documents being compared in winmerge
http://bugs.winehq.org/show_bug.cgi?id=20695 Summary: Cannot scroll documents being compared in winmerge Product: Wine Version: 1.1.32 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: joao.eiras(a)gmail.com 1. Get Winmerge http://winmerge.org/downloads/ (I'm using 2.12.4) 2. Install MFC71U.DLL and MSVCP71.dll (winetricks is good) 3. Open WinMerge and compare two documents Notice how the double document view cannot be scrolled horizontally using the scrollbar. IT works though if you select text and drag the mouse. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead(a)gmail.com, | |wylda(a)volny.cz --- Comment #1 from Wylda <wylda(a)volny.cz> 2009-11-14 19:18:58 --- No need for winetricks to bisect this bug report... 1. Confirming, please consider UNCONFIRMED->NEW and KEYWORDS: +REGRESSION 2. Did a regression test between 1.1.16 and 1.1.17: 032356ec379fbac733d4009381338e882672126e is first bad commit commit 032356ec379fbac733d4009381338e882672126e Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Wed Mar 4 17:38:41 2009 -0500 user32: Disable scroll bar control window when both buttons disabled. :040000 040000 71bf079bf85ee2f7bb34fca71a7d348c943f1716 3b1f435b113e3cef7ea46c6b926fe9a7f3bf8f85 M dlls 3. No other bug report suffers from this commit. 4. Revert of this patch on top of wine-1.1.17 makes that problem goes away. 5. Adding author of this patch to CC. --private keyword: bisected -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |user32 --- Comment #2 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-14 20:12:01 --- 2Wylda: Could you please manually revert patch part from user32/scroll.c to see that it helps on current 1.1.33? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #3 from Wylda <wylda(a)volny.cz> 2009-11-14 20:41:06 --- (In reply to comment #2)
Could you please manually revert patch part from user32/scroll.c to see that it helps on current 1.1.33?
Hi Nikolay, yes reverting commit 032356ec379fbac733d4009381338e882672126e on top of 1.1.33 helps, i.e. horizontal scrolling works again after revert. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://winmerge.org/downloa | |ds/ -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> 2009-11-25 03:12:57 --- I can confirm this. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #5 from Wylda <wylda(a)volny.cz> 2010-02-27 18:00:25 --- This bisected regression is still not fixed in wine-1.1.39-163-g583f0f0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #6 from Wylda <wylda(a)volny.cz> 2010-04-17 15:15:16 --- This regression (bisected) is still present in wine-1.1.43. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #7 from Wylda <wylda(a)volny.cz> 2010-05-10 15:05:38 --- This regression (bisected) is still present in wine-1.1.44-72-g658209b. Nikolay, don't you want me to test some of your patch for this issue? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #8 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-10 15:11:20 --- (In reply to comment #7)
This regression (bisected) is still present in wine-1.1.44-72-g658209b.
Nikolay, don't you want me to test some of your patch for this issue?
No, but I'm going to fix it. Well, try at least. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #9 from Wylda <wylda(a)volny.cz> 2010-06-20 11:52:06 --- This regression (bisected) is still present in wine-1.2-rc4. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #10 from Wylda <wylda(a)volny.cz> 2010-08-22 04:07:22 --- This regression (bisected) is still present in wine-1.3.1. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 André H. <nerv(a)dawncrow.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |source CC| |nerv(a)dawncrow.de --- Comment #11 from André H. <nerv(a)dawncrow.de> 2011-07-22 13:51:26 CDT --- This regression (bisected) is still present in wine-1.3.25. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Henri Verbeet <hverbeet(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |032356ec379fbac733d40093813 | |38e882672126e -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 A Wine user <RandomAccountName(a)mail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |RandomAccountName(a)mail.com -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #12 from Wylda <wylda(a)volny.cz> 2011-12-10 05:40:47 CST --- This regression (bisected) is still present in wine-1.3.34-202-gb0f704d. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 Andrew Eikum <aeikum(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aeikum(a)codeweavers.com --- Comment #13 from Andrew Eikum <aeikum(a)codeweavers.com> 2012-02-09 14:21:12 CST --- The problem here is SetScrollInfo can set the scrollbar's flags, but doesn't En/Disable the scrollbar itself. So the flags and actual window state are not in sync and we end up with this sequence: EnableScrollBar(ESB_DISABLE_BOTH) infoPtr->flags = ESB_DISABLE_BOTH EnableWindow(FALSE) SetScrollInfo(...) ... infoPtr->flags = ESB_ENABLE_BOTH EnableScrollBar(ESB_ENABLE_BOTH) infoPtr->flags == ESB_ENABLE_BOTH => return So some possible fixes: *) SetScrollInfo() is setting the flags incorrectly, or *) EnableScrollBar() should use some other method to determine if EnableWindow() needs to be called, or *) SetScrollInfo() should En/Disable the window to keep the flags in sync I'll keep looking, but thought maybe something would be obvious to Nikolay. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #14 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-02-10 01:41:02 CST --- (In reply to comment #13)
So some possible fixes: *) SetScrollInfo() is setting the flags incorrectly, or *) EnableScrollBar() should use some other method to determine if EnableWindow() needs to be called, or *) SetScrollInfo() should En/Disable the window to keep the flags in sync
I'll keep looking, but thought maybe something would be obvious to Nikolay.
Interesting, second case seems to work fine, we even have some tests for that, probably incomplete. I feel like last part is most likely a case, needs some testing to be done. I can do it this weekend but if you have time today (Friday) please do. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #15 from Wylda <wylda(a)volny.cz> 2012-05-19 09:42:10 CDT --- This regression (bisected) is still present in wine-1.5.4-185-g6c51c1b. Which one of these three choices in comment #13 won? ;) -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #16 from Nikolay Sivov <bunglehead(a)gmail.com> 2012-05-19 09:47:01 CDT --- (In reply to comment #15)
Which one of these three choices in comment #13 won? ;)
I had no chance to spend more time and fix that, I think Andrew is right about desynchronized flags and style. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #17 from Austin English <austinenglish(a)gmail.com> 2013-08-07 18:49:41 CDT --- http://sourceforge.net/projects/winmerge/files/stable/2.12.4/WinMerge-2.12.4... Still in 1.7.0. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Luke <lukebenes(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lukebenes(a)hotmail.com --- Comment #18 from Luke <lukebenes(a)hotmail.com> --- This regression is still present in wine-1.7.24. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Saulius K. <saulius2(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saulius2(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #19 from Nikolay Sivov <bunglehead(a)gmail.com> --- Hi, Andrew. I looked a bit at this today, and I'm unable to catch this sequence that you described in comment 13 - which is ESB_ENABLE_BOTH when flags are already enabled while window itself is not. I'm attaching patch that traces this condition, and it doesn't trigger for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #20 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 52764 --> https://bugs.winehq.org/attachment.cgi?id=52764 trace patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #21 from Wylda <wylda(a)volny.cz> --- (In reply to Nikolay Sivov from comment #19)
...condition, and it doesn't trigger for me.
Hi Nikolay, i applied your patch to wine-1.7.13 and it triggers for me. When i click on OK in open dialog, i immediately get following two lines: err:scroll:EnableScrollBar flag mismatch err:scroll:EnableScrollBar flag mismatch PS: WinMerge 2.12.4 + I tested this on "older" wine, because i had this version prepared from other testing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #22 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Wylda from comment #21)
(In reply to Nikolay Sivov from comment #19)
...condition, and it doesn't trigger for me.
Hi Nikolay, i applied your patch to wine-1.7.13 and it triggers for me. When i click on OK in open dialog, i immediately get following two lines:
err:scroll:EnableScrollBar flag mismatch err:scroll:EnableScrollBar flag mismatch
PS: WinMerge 2.12.4 + I tested this on "older" wine, because i had this version prepared from other testing.
Right, I can see it know, not sure why I missed that first time. Regarding directions from comment 13, I'm leaning towards second option - already have a fix locally, but it has to wait until after 1.8 is out, because this regression affects only one application so far that we're aware of, and changes to this area are potentially destabilizing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 --- Comment #23 from Luke <lukebenes(a)hotmail.com> --- Nikolay, Now that Wine 1.9 is here, could we please test your fix? WinMerge is fully Open Source.[1] Would the scrollbar code provide any hints as to what's going on here? [1] http://winmerge.org/downloads/source-code.php -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |9d91fce444fab9dc408f1e3834b | |2b0738843ec41 Status|NEW |RESOLVED --- Comment #24 from Nikolay Sivov <bunglehead(a)gmail.com> --- Fixed with http://source.winehq.org/git/wine.git/commit/9d91fce444fab9dc408f1e3834b2b07.... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #25 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.9.7. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani(a)redhat.com Target Milestone|--- |1.8.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=20695 Michael Stefaniuc <mstefani(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |--- --- Comment #26 from Michael Stefaniuc <mstefani(a)redhat.com> --- Removing 1.8.x milestone from bugs included in 1.8.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org