[Bug 42038] New: Cannot scroll documents being compared in winmerge ( Followup to bug 20695)
https://bugs.winehq.org/show_bug.cgi?id=42038 Bug ID: 42038 Summary: Cannot scroll documents being compared in winmerge (Followup to bug 20695) Product: Wine Version: 2.0-rc2 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: user32 Assignee: wine-bugs(a)winehq.org Reporter: bernhardu(a)mailbox.org Distribution: --- Bug #20695 got closed with wine-1.9.7. It really fixes the problem when opening two existing files. (e.g. by menu File - Open) But if one opens just a new empty file comparison and pastes the two file contents there the scrollbars do not work. (e.g. by menu File - New) (Even without pasting the scrollbars should be moveable a little bit.) This started like the original bug between 1.1.16-pol and 1.1.17-pol Version 1.9.7-pol shows also the problem as does 2.0-rc2-winehq. Can this someone confirm? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://winmerge.org/downloa | |ds/ -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression, | |source Distribution|--- |Debian -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- So can you confirm it's the same commit 032356ec379fbac733d4009381338e882672126e causing regression? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #2 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- I did not yet a git bisect on it, so I cannot say it is exactly the same commit. I will try to build at given commit and one before to get an answer, but this will take me some time ... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Bernhard Übelacker <bernhardu(a)mailbox.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |032356ec379fbac733d40093813 | |38e882672126e --- Comment #3 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- I did now a git bisect with a lenny chroot between wine-1.1.16 and wine-1.1.17. Did just check if scrollbars are enabled/reacting. It led me really to the same commit: 032356ec379fbac733d4009381338e882672126e is the first bad commit commit 032356ec379fbac733d4009381338e882672126e Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Wed Mar 4 17:38:41 2009 -0500 user32: Disable scroll bar control window when both buttons disabled. :040000 040000 71bf079bf85ee2f7bb34fca71a7d348c943f1716 3b1f435b113e3cef7ea46c6b926fe9a7f3bf8f85 M dlls For completeness: I am using native vb6run (probably just needed for one of the plugins) and native vcrun2008. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #4 from joaopa <jeremielapuree(a)yahoo.fr> --- Is still a bug in current wine(3.20)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4(a)web.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #5 from Fabian Maurer <dark.shadow4(a)web.de> --- Yes, still relevant as of wine-3.21. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #6 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Just updated, still visible with wine-5.0-rc2 and WinMerge-2.16.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #7 from Nikolay Sivov <bunglehead(a)gmail.com> --- Created attachment 66202 --> https://bugs.winehq.org/attachment.cgi?id=66202 patch I made some progress on this. Apparently it very much depends on window visibility state, and that's why tests didn't give results. One remaining issue with attached patch is potentially unrelated to scrollbar handling. The problem is that IsWindowVisible() test fails when compare views are displayed initially. That happens because Afx:xxxx window up parent chain does not have WS_VISIBLE style. While it does on Windows. Full chain ScrollBar -> AfxMDIFrame -> AfxFrameOrView -> AfxMDIFrame -> Afx:xxxxx:xxxx... All windows up to the top one on this list are "WS_VISIBLE"-visible. Anyway, with this patch it's enough to type on char to make scrollbars responsive. Please test and report if you see other problems with it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs(a)winehq.org |bunglehead(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #8 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Thank you very much taking care of this issue. I tested with your patch on top of wine-5.0-rc4-57-g2100353861 with WinMerge-2.16.4-Setup.exe. The scrollbars get activated as the first character is entered into the new compare. That far the bug could be closed then for me, if that patch would be committed. However, there seems to be still a difference to running inside native windows: there the scrollbars are enabled just when the new compare got opened. Wine with your patch needs to have additionally a character entered. But at least for WinMerge this is no issue as an empty compare serves no purpose. But this difference could be related to the visibility issue you found, I guess? With comparing files I could not find a difference between Wine with your patch and native. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #9 from Nikolay Sivov <bunglehead(a)gmail.com> --- Yes, exactly. That's the remaining problem I described in comment 7. Removing IsWindowVisible() test will enable scrollbar right away, same as on Windows. But it's a wrong thing to do, as tests show. I'll open another bug for it once original issue is improved. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead(a)gmail.com |wine-bugs(a)winehq.org --- Comment #10 from Nikolay Sivov <bunglehead(a)gmail.com> --- Scrollbar fix was committed, 92d336263cf320241e004d48e22becff387850c3. Remaining issue mentioned in comment 7 is separate problem I think. Please retest. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #11 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed per comment 8. Commit 92d336263cf320241e004d48e22becff387850c3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |92d336263cf320241e004d48e22 | |becff387850c3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 --- Comment #12 from Bernhard Übelacker <bernhardu(a)mailbox.org> --- Sorry for the late reply. I retested with wine-5.2-264-g0e7392040c and scroll bars are perfectly usable in new compare windows with pasted in content. Thanks for your work. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #13 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 5.3. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |5.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bunglehead(a)gmail.com | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42038 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|5.0.x |--- --- Comment #14 from Michael Stefaniuc <mstefani(a)winehq.org> --- Removing the 5.0.x milestone from bug fixes included in 5.0.1. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla