[Bug 57160] New: 16-bit color no longer works when using Xephyr, regression caused by 05d727a93 Jul 11, 2024
https://bugs.winehq.org/show_bug.cgi?id=57160 Bug ID: 57160 Summary: 16-bit color no longer works when using Xephyr, regression caused by 05d727a93 Jul 11, 2024 Product: Wine Version: 9.13 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: win32u Assignee: wine-bugs(a)winehq.org Reporter: boxedwine(a)danoon.net Distribution: --- commit 05d727a935b9009f188cc74ca77e14afc44aef30 on July 11 for 9.13 caused a regression where 16-bit color no longer displays correctly. On the lastest git master, notepad will just display black. That checkin has 3 chunks of code, if I comment out the larger chunk as seen below, git master will display notepad correctly when using 16-bit color // this is the new code that caused the regression if (new_surface && !is_layered) { DWORD lwa_flags = 0; COLORREF key; BYTE alpha; if (!NtUserGetLayeredWindowAttributes( hwnd, &key, &alpha, &lwa_flags )) lwa_flags = 0; if (!(lwa_flags & LWA_ALPHA)) alpha = 255; if (!(lwa_flags & LWA_COLORKEY)) key = CLR_INVALID; window_surface_set_layered( new_surface, key, alpha << 24, 0 ); } command line used when testing: Xephyr :1 -ac -screen 640x480x16 & DISPLAY=:1 wine-git/wine notepad Tested On: 1) Debian 11 32-bit inside VMWare 2) Ubuntu 24 64-bit on Intel(R) Core(TM) i7-6700K -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57160 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, regression, | |source Summary|16-bit color no longer |16-bit color no longer |works when using Xephyr, |works when using Xephyr |regression caused by | |05d727a93 Jul 11, 2024 | CC| |rbernon(a)codeweavers.com Regression SHA1| |05d727a935b9009f188cc74ca77 | |e14afc44aef30 --- Comment #1 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- commit 05d727a935b9009f188cc74ca77e14afc44aef30 Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Sat Jun 15 21:09:37 2024 +0200 win32u: Update the layered surface attributes in apply_window_pos. And after layered window creation in NtUserUpdateLayeredWindow. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57160 --- Comment #2 from Rémi Bernon <rbernon(a)codeweavers.com> --- Thanks for the report and bisection, https://gitlab.winehq.org/wine/wine/-/merge_requests/6482 should fix this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57160 Rémi Bernon <rbernon(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |e7e58dd375c4bcbe4f8cb9dfbe3 | |c4f6e6295ec27 --- Comment #3 from Rémi Bernon <rbernon(a)codeweavers.com> --- Should be fixed with e7e58dd375c4bcbe4f8cb9dfbe3c4f6e6295ec27 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57160 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 9.18. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57160 --- Comment #5 from James Bryant <boxedwine(a)danoon.net> --- I tested the fix in Wine 9.18 and it works correctly now. Thanks, -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla