[Bug 57456] New: Wine wayland scaled window is positioned on the left, not centered
https://bugs.winehq.org/show_bug.cgi?id=57456 Bug ID: 57456 Summary: Wine wayland scaled window is positioned on the left, not centered Product: Wine Version: 9.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winewayland Assignee: wine-bugs(a)winehq.org Reporter: shtetldik(a)gmail.com Distribution: --- Created attachment 77451 --> https://bugs.winehq.org/attachment.cgi?id=77451 Vampire: The Masquerade - Redemption intro video scaled When fullscreen resolution is set to something low and different from aspect ratio of the monitor, winewayland scales it up, but positions it on the left, rather than in the middle of the screen and leaves the mismatching area transparent. This happened for example in the intro video of Vampire: The Masquerade - Redemption. The video is 640x346 and my screen is 2560x1440. See attached screenshot for how it looks. It would be better if the scaled window was positioned in the middle, with some black bands for areas that are caused by mismatch in aspect ratio. Even better if this behavior could be configurable, i.e. where to position, what to use for bands, like transparent, solid color / what color, etc. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 alexandros.frantzis(a)collabora.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandros.frantzis(a)collabo | |ra.com --- Comment #1 from alexandros.frantzis(a)collabora.com --- (In reply to Shmerl from comment #0)
Created attachment 77451 [details] Vampire: The Masquerade - Redemption intro video scaled
When fullscreen resolution is set to something low and different from aspect ratio of the monitor, winewayland scales it up, but positions it on the left, rather than in the middle of the screen and leaves the mismatching area transparent.
This happened for example in the intro video of Vampire: The Masquerade - Redemption. The video is 640x346 and my screen is 2560x1440.
See attached screenshot for how it looks.
It would be better if the scaled window was positioned in the middle, with some black bands for areas that are caused by mismatch in aspect ratio.
Even better if this behavior could be configurable, i.e. where to position, what to use for bands, like transparent, solid color / what color, etc.
In such cases winewayland currently marks the window as fullscreen and relies on the compositor to properly place it on screen, add black background etc. This behavior is mandated by the specification but some compositors don't implement it yet. If this is on KDE Plasma then see https://bugs.kde.org/show_bug.cgi?id=461063. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #2 from Shmerl <shtetldik(a)gmail.com> --- Thanks for the pointer, added a reference to this bug there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #3 from Shmerl <shtetldik(a)gmail.com> --- Pinged KWin developers, they said this is planned but will take a long time to implement due to complexity of the spec. Wine can do this itself too. Quoting:
do it like other Wayland client that scales things in fullscreen - black 1x1 subsurface for the background + viewporter to scale the window(s) themselves
If it's too complex for Wine as well, I guess KWin users will have this broken until later. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #4 from Shmerl <shtetldik(a)gmail.com> --- I re-tested it with VtM Redemption which has low resolution video intros, and somehow it works better now with scaling things. Not sure if winewayland improved it or KWin did? Wine: 10.3 KWin: 6.3.2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #5 from alexandros.frantzis(a)collabora.com ---
Not sure if winewayland improved it or KWin did?
I did a (Wine) bisection and it turns out that enabling EGL_EXT_present_opaque is what triggers the behavioral change in KWin. I also tried explicitly setting the wl_surface opaque region (while EGL_EXT_present_opaque was disabled) and got the same behavior (surface centered + black background). So KWin seems to be treating fully-opaque surfaces differently from non-opaque for fullscreen purposes (I don't know if such behavior was introduced recently or has been there for some time). I guess all this is in line with protocol changes the KDE folks are proposing (e.g., https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/37...). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #6 from Shmerl <shtetldik(a)gmail.com> --- Btw, just for the reference, it's better in general but there is a brief flickering transparency moment when it just starts. I guess it depends on when exactly the scaling or positioning happens. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 daniel <daniel.penalized(a)proton.me> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.penalized(a)proton.me --- Comment #7 from daniel <daniel.penalized(a)proton.me> --- This issue also occurs with me in labwc/sway (https://gitlab.winehq.org/wine/wine/-/merge_requests/5057#note_96854) and apparently also in GNOME (https://www.reddit.com/r/linux_gaming/comments/1jsbrag/wine_under_wayland/). Maybe https://bugs.winehq.org/show_bug.cgi?id=57925 is a duplicate of this bug? Both bugs don't happen with this MR (https://gitlab.winehq.org/wine/wine/-/merge_requests/5057). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #8 from daniel <daniel.penalized(a)proton.me> --- I've been testing for the past few hours and have some additional information, I hope it's useful! Firstly, there is a workaround for this issue in labwc/wlroots, which is: take the window out of fullscreen, toggle the window's maximized state, and then put the window back in fullscreen. In labwc/openbox terms: ToggleFullscreen > ToggleMaximize > ToggleFullscreen. This workaround worked in the four games I tested: Splinter Cell 1, Splinter Cell 2, SWAT 4 and SWAT 4: The Stetchkov Syndicate (SWAT 4 expansion), with some issues: In Splinter Cell 2, at first the game does not fill in to your monitor's resolution, you need to press a key or make some movement with the cursor to fill it (yeah, I couldn't find an effective way to apply this workaround). Even when the game fills to your monitor's resolution, it becomes completely frozen, making it impossible to play. In SWAT 4 and SWAT 4: The Stetchkov Syndicate, in both games the cursor doubles, showing the system and game cursor, which is easily fixed by pressing any key on your keyboard. Otherwise, in SWAT 4 this workaround works perfectly, however, in SWAT 4: The Stetchkov Syndicate, the window resets completely when entering any loading screen, which makes you need to redo the workaround at those times. Secondly, besides this issue (the lack of window centering and a black background), I believe that the resolution scaling is also not working. I mean, even when I apply this workaround, the games internal resolution doesn't seem to change, so the game remains at a lower resolution. This is easily visible in Splinter Cell 1, with this workaround, the graphics are visibly lower compared to the graphics when I change the game's resolution in the settings. This could be another issue, which probably needs to be opened as a bug report, but neither of these two issues happen with this MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/5057, which makes me assume that the two things are correlated. I have logs of some tests. I was even going to attach them, but it seems that Bugzilla does not support sending multiple files in a single comment, so I decided to omit them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #9 from daniel <daniel.penalized(a)proton.me> --- The lack of centering of the window and the black borders is something that labwc doesn't really implement. However, a labwc developer has become aware of this, so it's probably something that will be fixed eventually! https://github.com/labwc/labwc/issues/2779 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #10 from daniel <daniel.penalized(a)proton.me> ---
Secondly, besides this issue (the lack of window centering and a black background), I believe that the resolution scaling is also not working. I mean, even when I apply this workaround, the games internal resolution doesn't seem to change, so the game remains at a lower resolution. This is easily visible in Splinter Cell 1, with this workaround, the graphics are visibly lower compared to the graphics when I change the game's resolution in the settings. This could be another issue, which probably needs to be opened as a bug report, but neither of these two issues happen with this MR: https://gitlab.winehq.org/wine/wine/-/merge_requests/5057, which makes me assume that the two things are correlated.
And that's a mistake on my part. Not even in winex11.drv is the game's internal resolution increased (and, consequently, the graphics improved). However, even when labwc implements window centering and black borders, it still won't be like it is in X11. In X11, old games are filled to my monitor's resolution, so there's no black border. This MR (https://gitlab.winehq.org/wine/wine/-/merge_requests/5057) for winewayland.drv works perfectly the same way on X11: the game is scaled to my monitor's resolution, without any black borders! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=57456 --- Comment #11 from Shmerl <shtetldik(a)gmail.com> --- (In reply to Shmerl from comment #6)
Btw, just for the reference, it's better in general but there is a brief flickering transparency moment when it just starts. I guess it depends on when exactly the scaling or positioning happens.
In KDE it's now back to not having any black bands and showing transparency in the missing part. Centering is also still broken kwin is still missing that feature. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla