[Bug 16181] New: istool: toolbar spacing way too wide
http://bugs.winehq.org/show_bug.cgi?id=16181 Summary: istool: toolbar spacing way too wide Product: Wine Version: 1.1.9 Platform: PC URL: http://sourceforge.net/project/showfiles.php?group_id=20 6943&package_id=247619&release_id=547026 OS/Version: Linux Status: NEW Keywords: download, source Severity: minor Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: austinenglish(a)gmail.com Created an attachment (id=17421) --> (http://bugs.winehq.org/attachment.cgi?id=17421) screenshot in 1.1.9 Screenshot says all. Terminal is filled with: err:toolbar:TOOLBAR_GetImageListForDrawing bitmap for ID 0, index 0 is not valid, number of bitmaps in imagelist: 0 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16181 Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mikolaj.zalewski(a)gmail.com URL|http://sourceforge.net/proje|http://sourceforge.net/proje |ct/showfiles.php?group_id=20|ct/showfiles.php?group_id=20 |6943&package_id=247619&relea|6943&package_id=247619&relea |se_id=547026 |se_id=547026 --- Comment #1 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2009-01-10 11:18:33 --- This is caused by buttons #14 and #15 having strings ("Options" and "Settings"). Other buttons don't use BTNS_AUTOSIZE, so they are given the same width as the longer of these strings. I don't know what causes Windows' comctl32 to behave differently. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16181 --- Comment #2 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2009-01-24 12:32:08 --- Created an attachment (id=18960) --> (http://bugs.winehq.org/attachment.cgi?id=18960) Patches for the problem The problem is that none of TB_SETBUTTONINFO nor TB_SETEXTENDEDSTYLE (with the style the application uses) should recalc the toolbar - the toolbar should use the cached button size from before the strings were added. I have attached patches to fix this. However, once when I fixed a similar bug, it activated a bug in a different area. Do you have some applications with toolbar where you could check that it doesn't introduce some regressions? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16181 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch --- Comment #3 from Austin English <austinenglish(a)gmail.com> 2009-01-24 15:58:50 --- (In reply to comment #2)
Created an attachment (id=18960) --> (http://bugs.winehq.org/attachment.cgi?id=18960) [details] Patches for the problem
The problem is that none of TB_SETBUTTONINFO nor TB_SETEXTENDEDSTYLE (with the style the application uses) should recalc the toolbar - the toolbar should use the cached button size from before the strings were added. I have attached patches to fix this. However, once when I fixed a similar bug, it activated a bug in a different area. Do you have some applications with toolbar where you could check that it doesn't introduce some regressions?
I don't, sorry. Could ask on -devel? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16181 Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Mikolaj Zalewski <mikolaj.zalewski(a)gmail.com> 2009-02-02 15:04:59 --- I've checked some toolbars in some application and none looked strange, so I've sent the patches. They got accepted into Wine Git and will be available in Wine development releases starting from Wine 1.1.15. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=16181 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> 2009-02-13 11:11:25 --- Closing bugs fixed in 1.1.15. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org