[Bug 54066] New: SysLink control shouldn't delete the HFONT it didn't create
https://bugs.winehq.org/show_bug.cgi?id=54066 Bug ID: 54066 Summary: SysLink control shouldn't delete the HFONT it didn't create Product: Wine Version: 7.22 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs(a)winehq.org Reporter: vz-wine(a)zeitlins.org Distribution: --- I believe there is a bug in `dlls/comctl32/syslink.c` where `WM_DESTROY` handler calls `DeleteObject(infoPtr->Font)`, although this font is not owned by the control -- it is (or can be) given to it via `WM_SETFONT` and doing this means that a system font can be destroyed prematurely, resulting in plenty of other problems later on in the program. Amazingly, it looks like this code was there since a1f3756daab (Free allocated font handles when control is destroyed., 2004-12-08) and I don't really understand how could it not be noticed until now, but apparently somehow it wasn't. The following trivial patch: ``` diff --git a/dlls/comctl32/syslink.c b/dlls/comctl32/syslink.c index 8130bf19641..efc3467838b 100644 --- a/dlls/comctl32/syslink.c +++ b/dlls/comctl32/syslink.c @@ -1709,7 +1709,6 @@ static LRESULT WINAPI SysLinkWindowProc(HWND hwnd, UINT message, case WM_DESTROY: TRACE("SysLink Ctrl destruction, hwnd=%p\n", hwnd); SYSLINK_ClearDoc(infoPtr); - if(infoPtr->Font != 0) DeleteObject(infoPtr->Font); if(infoPtr->LinkFont != 0) DeleteObject(infoPtr->LinkFont); SetWindowLongPtrW(hwnd, 0, 0); Free (infoPtr); ``` is enough to fix the problem for me. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54066 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Fixed by SHA1| |480598680ceb86661bd269b7a64 | |bd90e38a40f98 Resolution|--- |FIXED --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- This is fixed with 480598680ceb86661bd269b7a64bd90e38a40f98. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54066 --- Comment #2 from VZ <vz-wine(a)zeitlins.org> --- Thanks, this commit should indeed fix it, as it's exactly the same patch I proposed 2+ years ago. Out of curiosity, what is the best way to contribute to Wine? I've tried submitting patches using the recommended procedure (never got any feedback back), tried including patches into the bug reports (like here, with similar result), what am I doing wrong? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54066 --- Comment #3 from Nikolay Sivov <bunglehead(a)gmail.com> --- The procedure is described here https://gitlab.winehq.org/wine/wine/-/wikis/Git-Wine-Tutorial. Sometimes when people are too busy submitted fixes could be left without a comment, that does happen unfortunately. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54066 --- Comment #4 from VZ <vz-wine(a)zeitlins.org> --- Thanks, I didn't realize that this has changed since the last patch I had submitted (this was in 2019 and I have vague recollections of using a Wine-specific patch submission queue), so I'll try to resurrect any still relevant patches and open PRs for them. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54066 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.4. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=54066 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winebugs(a)jn-games.de --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- *** Bug 29758 has been marked as a duplicate of this bug. *** -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla