[Bug 53893] New: ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows
https://bugs.winehq.org/show_bug.cgi?id=53893 Bug ID: 53893 Summary: ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows Product: Wine Version: unspecified Hardware: x86-64 OS: Windows Status: NEW Severity: normal Priority: P2 Component: winsock Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com ws2_32:sock - test_WSASocket() gets an unexpected raw protocol name in French on Windows: sock.c:2952: Test failed: got szProtocol L"TCP/IP MSAFD [RAW/IP]". See: https://test.winehq.org/data/patterns.html#ws2_32:sock The test only gets this protocol name when running in a French local which means it may actually be translated (though it's not obvious looking at it). Could this mean that the "Some Win7 machines" case is also because of translations? This failure started with the commit below: commit 4c67e0fb7917025646725d2b6133e0778802afe1 Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Jul 5 11:33:51 2022 -0500 ws2_32: Add ipv4 raw socket protocol info. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression, source, | |testcase CC| |pgofman(a)codeweavers.com Regression SHA1| |4c67e0fb7917025646725d2b613 | |3e0778802afe1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 Zeb Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com --- Comment #1 from Zeb Figura <z.figura12(a)gmail.com> --- Yeah, the English name is "MSAFD Tcpip [RAW/IP]". I guess it was necessary to make that a postpositive adjective?? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- The "MSAFD-Tcpip [RAW/IP]" value is not related to Windows 7. w10pro64-de has the same. It's just the German translation. So we have: de: MSAFD-Tcpip [RAW/IP] fr: TCP/IP MSAFD [RAW/IP] All others: MSAFD Tcpip [RAW/IP] -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 --- Comment #3 from Paul Gofman <pgofman(a)codeweavers.com> --- When adding this test I had no idea that those protocol names are localized. I don't think we want to test these localized strings or support their localization until something depends on that. I sent MR 1287 which just removes the test and drops a comment instead. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |2d5de1d911bb847ec8d5dfad456 | |9454e152ae834 Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from François Gouget <fgouget(a)codeweavers.com> --- This is fixed. Thanks Paul! commit 2d5de1d911bb847ec8d5dfad4569454e152ae834 Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Mon Nov 7 21:01:26 2022 -0600 ws2_32/tests: Don't test protocol name in test_WSASocket(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53893 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53893 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #5 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.21. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla