[Bug 34850] New: Improve commctl32 TaskDialogIndirect stub to show "content" part in task dialog box (more detailed error messages for various apps/games)
http://bugs.winehq.org/show_bug.cgi?id=34850 Bug #: 34850 Summary: Improve commctl32 TaskDialogIndirect stub to show "content" part in task dialog box (more detailed error messages for various apps/games) Product: Wine Version: 1.7.5 Platform: x86 OS/Version: Linux Status: NEW Severity: minor Priority: P2 Component: comctl32 AssignedTo: wine-bugs(a)winehq.org ReportedBy: focht(a)gmx.net Classification: Unclassified Hello folks, this is a bug split off from bug 34008 ("Bioshock Infinite won't start (needs D3D11CreateDevice implementation to support at least D3D_FEATURE_LEVEL_10_0)") The bug reporter complains that the reason for the error can't be seen in message box Wine creates (as substitute for task dialog): --- quote --- Bioshock Infinite shows an empty message box on launch and closes after pressing OK button. Nothing else is shown. After making a dirty hack in commctrl.c (replaced pTaskConfig->pszMainInstruction with pTaskConfig->pszContent) I can see the messagebox saying that I should have DX10/11 compatible hardware and DX11 runtime: http://i.imgur.com/OxHDoKI.png --- quote --- This is actually true and I've also seen this for other apps that make use of TaskDialogIndirect. Wine currently only uses "pTaskConfig->pszMainInstruction" for display which might not contain the essential information. Various apps put the real info in "pTaskConfig->pszContent". MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/bb760544%28v=vs.85%2... Article showing use of various parameters/options with screenshots: http://www.codeproject.com/Articles/16806/Vista-Goodies-in-C-Using-TaskDialo... Regards -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34850 Frédéric Delanoy <frederic.delanoy(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy(a)gmail.com --- Comment #1 from Frédéric Delanoy <frederic.delanoy(a)gmail.com> 2013-11-08 02:29:12 CST --- Note http://source.winehq.org/patches/data/100273 was submitted by Austin English but didn't get committed. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=34850 Adam Bolte <abolte(a)systemsaviour.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abolte(a)systemsaviour.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |austinenglish(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 --- Comment #2 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, revisiting, still present. https://source.winehq.org/git/wine.git/blob/HEAD:/dlls/comctl32/commctrl.c#l... $ wine --version wine-1.7.45-117-gfed7dda Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 super_man(a)post.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man(a)post.com --- Comment #3 from super_man(a)post.com --- No change since it still applies against git patching file dlls/comctl32/commctrl.c Hunk #1 succeeded at 1629 (offset 1 line). wine-1.7.55-73-g39f2ed3 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 winetest(a)luukku.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest(a)luukku.com --- Comment #4 from winetest(a)luukku.com --- Bug 40613 might have a depency on this. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 Gijs Vermeulen <acescopezz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acescopezz(a)gmail.com --- Comment #5 from Gijs Vermeulen <acescopezz(a)gmail.com> --- Should be fixed by: https://source.winehq.org/git/wine.git/commit/8967e87c8a890aed7a81051c2d372f... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Fixed by SHA1| |8967e87c8a890aed7a81051c2d3 | |72f065e825bb2 Status|NEW |RESOLVED --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed, 8967e87c8a890aed7a81051c2d372f065e825bb2. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=34850 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs@winehq.org