[Bug 53670] New: vbscript can not compile if expressions with reversed gte, lte, (=>, =<)
https://bugs.winehq.org/show_bug.cgi?id=53670 Bug ID: 53670 Summary: vbscript can not compile if expressions with reversed gte, lte, (=>, =<) Product: Wine Version: 7.16 Hardware: x86-64 OS: Mac OS X Status: UNCONFIRMED Severity: normal Priority: P2 Component: vbscript Assignee: wine-bugs(a)winehq.org Reporter: jsm174(a)gmail.com While working on leveraging the vbscript engine of Wine for a macos port of Visual Pinball, I've been testing several user made scripts. I've found several scripts that use if expressions with gte and lte in reversed order, ie => and =<, which fail to compile. vbscript does seem to allow for these to be reversed: Set g_objWSH = Wscript.CreateObject("Wscript.Shell") dim x dim y x = 6 y = 6 If x => y Then Wscript.Echo "This works 1" End If If x >= y Then Wscript.Echo "This works 2" End If If x <= y Then Wscript.Echo "This works 3" End If If x =< y Then Wscript.Echo "This works 4" End If -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Jason Millard <jsm174(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsm174(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC| |sloper42(a)yahoo.com --- Comment #1 from Robert Wilhelm <sloper42(a)yahoo.com> --- confirming. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 --- Comment #2 from Robert Wilhelm <sloper42(a)yahoo.com> --- Created attachment 73088 --> https://bugs.winehq.org/attachment.cgi?id=73088 support reversed gte and lte in lexer. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Robert Wilhelm <sloper42(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 --- Comment #3 from Jason Millard <jsm174(a)gmail.com> --- I just tried this and it's working! Thanks again! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 --- Comment #4 from Nikolay Sivov <bunglehead(a)gmail.com> --- (In reply to Robert Wilhelm from comment #2)
Created attachment 73088 [details] support reversed gte and lte in lexer.
This looks good to me. Robert, do you have time to submit this, with some tests? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 --- Comment #5 from Robert Wilhelm <sloper42(a)yahoo.com> ---
This looks good to me. Robert, do you have time to submit this, with some tests?
Yes, I plan to submit this real soon now. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |3a578022891714a83d5a981693b | |945cc0a16b63d Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Nikolay Sivov <bunglehead(a)gmail.com> --- Marking fixed, 3a578022891714a83d5a981693b945cc0a16b63d. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 7.22. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |7.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=53670 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|7.0.x |--- --- Comment #8 from Michael Stefaniuc <mstefani(a)winehq.org> --- Drop 7.0.x target milestone from bugs that didn't make it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla