[Bug 42033] New: Fallout 3: Radio music not playing
https://bugs.winehq.org/show_bug.cgi?id=42033 Bug ID: 42033 Summary: Fallout 3: Radio music not playing Product: Wine Version: 2.0-rc1 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: aaronbpaden(a)gmail.com Distribution: --- Created attachment 56507 --> https://bugs.winehq.org/attachment.cgi?id=56507 log When listening to the radio in Fallout 3, the DJ's voice works, but the songs don't. Sometimes you'll hear the song start for a second, but then it stops and the DJ's voice starts up again. This happens both on GNR and the enclave station. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |o.dierick(a)piezo-forte.be --- Comment #1 from Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> --- Does using native quartz makes any difference? (winetricks -q quartz) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #2 from Aaron Paden <aaronbpaden(a)gmail.com> --- Created attachment 56516 --> https://bugs.winehq.org/attachment.cgi?id=56516 native quartz log Issue persists with native quartz. Gstreamer still shows up a lot in the logs. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 tokktokk <fdsfgs(a)krutt.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs(a)krutt.org -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #3 from joaopa <jeremielapuree(a)yahoo.fr> --- Does the bug still occur with wine-5.16? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 m1m1k4tz <m1m1k4tz(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m1m1k4tz(a)protonmail.com --- Comment #4 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- I tested this out on the new experimental wow64 mode and the old one and the radio works so this is probably fixed it also works on proton -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 zlice <zlice(a)crtdrift.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zlice(a)crtdrift.us --- Comment #5 from zlice <zlice(a)crtdrift.us> --- i know this is an old issue, but it's also been a long standing issue on and off for fallout 3 had a dupe-ish issue here https://bugs.winehq.org/show_bug.cgi?id=57632 for wine10-rc tldr - does wine10 make fallout3 radio work for anyone? if not, do connor's patches fix it? https://bugs.winehq.org/attachment.cgi?id=77809&action=diff -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 mata <sutupud(a)yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sutupud(a)yahoo.com --- Comment #6 from mata <sutupud(a)yahoo.com> --- (In reply to zlice from comment #5)
i know this is an old issue, but it's also been a long standing issue on and off for fallout 3
had a dupe-ish issue here https://bugs.winehq.org/show_bug.cgi?id=57632 for wine10-rc
tldr - does wine10 make fallout3 radio work for anyone? if not, do connor's patches fix it? https://bugs.winehq.org/attachment.cgi?id=77809&action=diff
It sometimes works for me. A song might start playing, but then when switching to the next it doesn't play. When standing next to the jukebox in my megaton house, I can hear the song start playing. Switching between stations on the pip boy a few times can get it to start playing. Doing so I see some events in the log: 0144:err:quartz:BaseMemAllocator_Decommit Waiting: 1 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #7 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- I think the caveat is you need to correct gstreamer plugins installed for the radio to work properly -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #8 from zlice <zlice(a)crtdrift.us> --- gstreamer is certainly part of it, in the past i've had to manually extract and change bitrate on some songs, then load them as "loose files" the in world radios are different than pipboy (i think there may be 2 different versions. as some will break with pipboy but most play) mata - was your issue with or without the patches i linked? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #9 from mata <sutupud(a)yahoo.com> --- (In reply to zlice from comment #8)
mata - was your issue with or without the patches i linked?
No, it was without them, only vanilla wine 10.0-rc5 - since I din't really have the time to try it until now. But I tried to apply them now, and I can say that it seems to fix it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #10 from m1m1k4tz <m1m1k4tz(a)protonmail.com> --- Actually, after testing this I get this issue the announcers talk just fine but the songs are static. If it really is caused by a security update in gstreamer like you say though then it might be hard to find the commit in a reverse regression test. The easiest way to test for this btw is to just open the launcher and listen for the music. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #11 from zlice <zlice(a)crtdrift.us> --- i have a save in the other issue i linked right outside of 101 where the radio is about to change songs. though there could be something else that causes static -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #12 from zlice <zlice(a)crtdrift.us> --- well, looks like the patch from the other issue no longer works in 10.2 as something was removed that this line touches - "graph->got_ec_complete = 0;" no radio half the time, but there's other issues i'm seeing (at least with wow64) too -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #13 from zlice <zlice(a)crtdrift.us> --- Created attachment 78128 --> https://bugs.winehq.org/attachment.cgi?id=78128 winedbg-radio-10.2 loaded my save (in the other issue) and got a radio song, then exit to main menu, reload save, no radio song playing -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #14 from zlice <zlice(a)crtdrift.us> --- still present in 10.3. load save, radio works, main menu, reload, radio song is silent -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 Connor McAdams <cmcadams(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmcadams(a)codeweavers.com --- Comment #15 from Connor McAdams <cmcadams(a)codeweavers.com> --- This bug is caused by the game starting a new MP3 audio stream, then seeking to an offset that is both not aligned on MP3 frame boundaries and often times past the first MP3 frame. Once it changes state from pause to run, this results in negative PTS values being passed into gstreamer, which it can't properly interpret because gstreamer PTS values are supposed to be unsigned. Then there's another issue, which is if the audio stream is paused, e.g by hitting the escape button and pausing the game, the samples passed to dsound all have negative timestamps upon resume (AFAICT this is because they were submitted prior to the pause) and this further causes issues. I've got some hacks for both of these locally, but they need some extra work before opening an MR. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #16 from zlice <zlice(a)crtdrift.us> --- i had a PR a while back when something with the audio system changed. but i don't know a lot about audio of how wine handles quartz and the like. the changed were denied as regressions. and i dont think the change applies anymore. but the offsets and rewinds being wrong sounds like what i saw. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #17 from Connor McAdams <cmcadams(a)codeweavers.com> --- This should be fixed now by 501de3f02cf6e899a0b555876bcb9a286397c7c8, it's worth retesting. That fix gets audio playing but technically we're still not exactly matching native's behavior, although at this point I'm not sure how much that matters since the audio plays regardless. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #18 from zlice <zlice(a)crtdrift.us> --- it looks like just that commit isn't enough? for example WG_SAMPLE_FLAG_PRESERVE_TIMESTAMPS isn't defined or set? know what all commits are related? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #19 from Connor McAdams <cmcadams(a)codeweavers.com> --- (In reply to zlice from comment #18)
it looks like just that commit isn't enough? for example WG_SAMPLE_FLAG_PRESERVE_TIMESTAMPS isn't defined or set?
know what all commits are related?
You'd need all the commits from MR !7623, so all commits starting from 753a3333b387d477eef67dfba388146160177fff and ending with 501de3f02cf6e899a0b555876bcb9a286397c7c8. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #20 from zlice <zlice(a)crtdrift.us> --- i had to weed out some 'todo' lines in tests/mf/transforms.c (?) but i still get nothing on the radio if i load that save i put in the other issue, quit to main menu, load the same save again -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #21 from Connor McAdams <cmcadams(a)codeweavers.com> --- (In reply to zlice from comment #20)
i had to weed out some 'todo' lines in tests/mf/transforms.c (?) but i still get nothing on the radio if i load that save i put in the other issue, quit to main menu, load the same save again
What happens if you pause/unpause the game after loading the same save? There's a game bug where loading a save doesn't clear the radio state, and pausing/unpausing the game resets it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #22 from zlice <zlice(a)crtdrift.us> --- (In reply to Connor McAdams from comment #21)
What happens if you pause/unpause the game after loading the same save? There's a game bug where loading a save doesn't clear the radio state, and pausing/unpausing the game resets it.
pressing 'escape' for pause while 3 dog is talking before the song doesn't seem to do anything. gnr station doesn't play and neither does enclave station -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #23 from Connor McAdams <cmcadams(a)codeweavers.com> --- Could you attach a log with `+quartz`? Also, what version of wine are you applying these patches on top of? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #24 from zlice <zlice(a)crtdrift.us> --- Created attachment 78638 --> http://bugs.winehq.org/attachment.cgi?id=78638 fo3-quartzdbg putting on top of 10.8 right now (note: have some more patches for x11 fullscreen/window-mapping bugs, but nothing else audio) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #25 from zlice <zlice(a)crtdrift.us> --- probably not news but this still happens in 10.9 which has the mentioned patches -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #26 from zlice <zlice(a)crtdrift.us> ---
What happens if you pause/unpause the game after loading the same save? There's a game bug where loading a save doesn't clear the radio state, and pausing/unpausing the game resets it.
on 10.10 and it looks like this is behaving 'as expected' (aka a buggy bethesda mess lol) with the pause/unpause after main menu working! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #27 from zlice <zlice(a)crtdrift.us> --- oh btw, on wow64 build. havent tested 32-bit yet but assume it should be fine -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #28 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Just to confirm: is this fixed in Wine 10.10 (without additional patches needed)? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 --- Comment #29 from zlice <zlice(a)crtdrift.us> --- (In reply to Ken Sharp from comment #28)
Just to confirm: is this fixed in Wine 10.10 (without additional patches needed)?
yes, tested on 32bit as well. not sure what the difference was between 10.9 and 10.10 but thanks connor -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #30 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Fixed. Thanks for testing. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=42033 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #31 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 10.11. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla