[Bug 42873] New: Need for Speed: The Run crashes when getting a d3d context
https://bugs.winehq.org/show_bug.cgi?id=42873 Bug ID: 42873 Summary: Need for Speed: The Run crashes when getting a d3d context Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: directx-d3d Assignee: wine-bugs(a)winehq.org Reporter: leslie_alistair(a)hotmail.com Distribution: --- Created attachment 57989 --> https://bugs.winehq.org/attachment.cgi?id=57989 possible solution When running "Need for Speed: The Run", it crash on an invalid context. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 --- Comment #1 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 57990 --> https://bugs.winehq.org/attachment.cgi?id=57990 Log file -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia(a)gmail.com --- Comment #2 from Józef Kucia <joseph.kucia(a)gmail.com> --- (In reply to Alistair Leslie-Hughes from comment #0)
Created attachment 57989 [details] possible solution
The condition in the patch should be "if (!context || ...".
When running "Need for Speed: The Run", it crash on an invalid context.
It happens because the context which was used to issue the query is destroyed with the associated swapchain. I think it's fine to do a NULL check in context_reacquire(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57989|0 |1 is obsolete| | --- Comment #3 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Created attachment 58001 --> https://bugs.winehq.org/attachment.cgi?id=58001 Update Patch -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 --- Comment #4 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Is there an example test I could use/copy to reproduce this behaviour? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 --- Comment #5 from Józef Kucia <joseph.kucia(a)gmail.com> --- Created attachment 58004 --> https://bugs.winehq.org/attachment.cgi?id=58004 Test case (In reply to Alistair Leslie-Hughes from comment #4)
Is there an example test I could use/copy to reproduce this behaviour?
The attached test reproduced this crash. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Staged patchset| |https://github.com/wine-com | |pholio/wine-staging/tree/ma | |ster/patches/wined3d-contex | |t_reacquire Status|NEW |STAGED CC| |dmitry(a)baikal.ru, | |erich.e.hoover(a)wine-staging | |.com, michael(a)fds-team.de, | |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |c9ea06e7a8fef557bd781c2b56c | |d81a3629ec839 Resolution|--- |FIXED Status|STAGED |RESOLVED --- Comment #6 from Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> --- Fixed by http://source.winehq.org/git/wine.git/?a=commit;h=c9ea06e7a8fef557bd781c2b56... -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Józef Kucia <joseph.kucia(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Need for Speed: The Run |Need for Speed: The Run |crashes when getting a d3d |crashes when reacquiring |context |query context -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=42873 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #7 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 2.9. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org