[Bug 17807] New: Electronics Workbench 5.12: measurement units aren't shown
http://bugs.winehq.org/show_bug.cgi?id=17807 Summary: Electronics Workbench 5.12: measurement units aren't shown Product: Wine Version: 1.1.17 Platform: PC URL: http://appdb.winehq.org/objectManager.php?sClass=version &iId=402 OS/Version: Linux Status: UNCONFIRMED Severity: minor Priority: P2 Component: -unknown AssignedTo: wine-bugs(a)winehq.org ReportedBy: nick(a)vyalceva.net Created an attachment (id=20039) --> (http://bugs.winehq.org/attachment.cgi?id=20039) the oscilloscope window When trying to set measurement unit for a parameter in the "Component Properties" window, or in the oscilloscope, measurement units are not shown in the selection box. But I can view it by copying from the box and pasting in a text editor, e.g. "0.50 s/div ". Old wine version 0.9.52 shows units in the oscilloscope window, but doesn't do it in the component properties (http://appdb.winehq.org/screenshots.php?iAppId=267&iVersionId=402). Also I get the following error message on exit: "access violation on (FFF4EFFF), reading C4". Running from terminal shows me the only line "fixme:font:WineEngRemoveFontResourceEx :stub". -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Nikolay <nick(a)vyalceva.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Component|-unknown |user32 --- Comment #1 from Nikolay <nick(a)vyalceva.net> 2009-03-28 14:17:00 --- This bug is located in wine Edit control. I changed one line in the following file: /dlls/user32/edit.c line 3875: from EDIT_PaintLine(es,dc,0,rev); to direct call TextOutW(dc,1,1,es->text,strlenW(es->text)); and the units shows normally. But this change breaks some behaviour of the Edit control. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Rein Klazes <wijn(a)online.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #2 from Rein Klazes <wijn(a)online.nl> 2009-03-28 14:44:22 --- An fix that has better chance to be correct: --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -1809,7 +1809,7 @@ static void EDIT_EM_ScrollCaret(EDITSTATE *es) if(dx || dy || (es->y_offset && (es->line_count - es->y_offset < vlc))) EDIT_EM_LineScroll_internal(es, dx, dy); } - } else { + } else if( es->style & ES_AUTOHSCROLL) { INT x; INT goal; INT format_width; I need some more time to work out the proper tests. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Vitaliy Margolen <vitaliy(a)kievinfo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #3 from Vitaliy Margolen <vitaliy(a)kievinfo.com> 2009-03-28 16:00:55 --- http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity: Minor For minor loss of functionality, or other problem where an easy workaround is present If anything this is trivial at best (UI glitch that doesn't affect running of a program). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #4 from Nikolay <nick(a)vyalceva.net> 2009-03-28 16:07:10 --- My fix that cuts off extra blanks if the control is in readonly mode:
From af2e4b71f5b83e7385eede4a559e704fedcd8893 Mon Sep 17 00:00:00 2001 From: Nikolay <nick(a)vyalceva.net> Date: Sat, 28 Mar 2009 23:49:12 +0300 Subject: This patch fixes an error in EWB 5.12 (# 17807).
--- dlls/user32/edit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) mode change 100644 => 100755 dlls/user32/edit.c diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c old mode 100644 new mode 100755 index eadcc3d..279a2f9 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -1001,7 +1001,7 @@ static LRESULT EDIT_EM_PosFromChar(EDITSTATE *es, INT index, BOOL after_wrap) HFONT old_font = 0; SIZE size; LINEDEF *line_def; - + while((es->text[len-1]==0x20) && (es->style & ES_READONLY)) --len; index = min(index, len); dc = GetDC(es->hwndSelf); if (es->font) -- 1.5.6.3 -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #5 from Nikolay <nick(a)vyalceva.net> 2009-03-28 17:05:11 --- There is an bug that causes an error if the string consists of spaces only. Also, this fix is only for single-line controls. This is more correctly: while((len) && (es->text[len-1]==0x20) && (es->style & ES_READONLY) && !(es->style & ES_MULTILINE)) --len; -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #6 from Nikolay <nick(a)vyalceva.net> 2009-03-30 15:03:28 --- Created an attachment (id=20205) --> (http://bugs.winehq.org/attachment.cgi?id=20205) Sample program that creates Edit control without ES_AUTOHSCROLL style. This simple program creates a window with an Edit control without ES_AUTOHSCROLL style and sets a big text string in it (the text does not fit in control). -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Nikolay <nick(a)vyalceva.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20205|Sample program that creates |Sample program that creates description|Edit control without |Edit control without |ES_AUTOHSCROLL style. |ES_AUTOHSCROLL style. | |Under Windows and Wine with | |patch proposed by Rein (#2) | |the control doesn't scroll | |when user presses Left and | |Right keys. | |Under Wine without patch the | |control scrolls. --- Comment #7 from Nikolay <nick(a)vyalceva.net> 2009-03-30 15:13:27 --- (From update of attachment 20205) So my supposition about cutting off spaces was not correct; this bug is linked with handling ES_AUTOHSCROLL style. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download --- Comment #8 from Austin English <austinenglish(a)gmail.com> 2009-10-01 15:01:14 --- Is this still an issue in current (1.1.30 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #9 from Austin English <austinenglish(a)gmail.com> 2009-10-01 15:09:50 --- Is this still an issue in current (1.1.30 or newer) wine? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #10 from Rein Klazes <wijn(a)online.nl> 2009-10-02 02:41:18 --- Bug still exists in current git. Patch in comment #2 is still working. Because it changes a subroutine called from more then a dozen places, I feel this should be tested for more cases then just this application. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #11 from Nikolay <nick(a)vyalceva.net> 2009-10-13 13:42:51 --- Created an attachment (id=24097) --> (http://bugs.winehq.org/attachment.cgi?id=24097) testcase -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #12 from Nikolay <nick(a)vyalceva.net> 2009-10-13 13:54:58 --- Created an attachment (id=24098) --> (http://bugs.winehq.org/attachment.cgi?id=24098) screenshots from windows and wine -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #13 from Ed Sternin <ed.sternin(a)brocku.ca> 2010-02-01 10:30:36 --- Created an attachment (id=26002) --> (http://bugs.winehq.org/attachment.cgi?id=26002) Correctly rendered oscilloscope, from Windo$e -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #14 from Ed Sternin <ed.sternin(a)brocku.ca> 2010-02-01 10:31:25 --- Created an attachment (id=26003) --> (http://bugs.winehq.org/attachment.cgi?id=26003) horizontally compressed rendering of "1 V/Div" -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #15 from Ed Sternin <ed.sternin(a)brocku.ca> 2010-02-01 10:32:01 --- Created an attachment (id=26004) --> (http://bugs.winehq.org/attachment.cgi?id=26004) missing characters from "500 mV/Div" -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #16 from Ed Sternin <ed.sternin(a)brocku.ca> 2010-02-01 10:33:06 --- Created an attachment (id=26005) --> (http://bugs.winehq.org/attachment.cgi?id=26005) EWB font file -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Ed Sternin <ed.sternin(a)brocku.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ed.sternin(a)brocku.ca --- Comment #17 from Ed Sternin <ed.sternin(a)brocku.ca> 2010-02-01 10:35:43 --- I'd like to add my $0.02. Running under wine-1.1.26/SUSE 11.1/kernel 2.6.27.42-0.1-pae First of all I disagree with the designation of "minor". This "UI issue" is so severe that it makes the program unusable: it affects all of the control and measurement devices in the program. So giving the program a "Gold" rating despite that seems not right. The strings are set and modified correctly (by pressing up/down arrow I can change from "1 V/Div" to "500 mV/Div", as revealed by the copy-and-paste trick). They are not rendered correctly. I attach three images for reference: a correctly rendered instrument from a Windows box; and two incorrectly rendered ones, for "1 V/Div" and "500 mV/Div". While "1 V/Div" is sort of legible, the first characters are not just compressed horizontally, they appear to be missing. I wonder if "--len" in the fix is responsible for that. The strings are variable in length, so if edit.c is only called during the creation of the window, does it still use the right string length later, when the string is modified? Due to the age of the program, it uses its own .FON file. I wonder if an incorrect font metric format is responsible for the string rendering problems, rather than anything in the edit.c. I attach the .FON file for reference; I am not sure how to run Nicolay's test against this font, perhaps someone can? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 Bruno Jesus <00cpxxx(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |00cpxxx(a)gmail.com --- Comment #18 from Bruno Jesus <00cpxxx(a)gmail.com> 2012-07-30 23:10:26 CDT --- Still in wine 1.5.9. Patch from comment 2 still fixes this bug. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #19 from Ed Sternin <ed.sternin(a)brocku.ca> 2012-07-31 10:15:58 CDT --- Actually, matters are slightly worse in 1.5.9. Both the editable text fields and now the fixed-text ones (buttons) appear totally blank. This is more than THREE YEARS after a solution has been proposed, and nobody seems to give a damn. Mr.Bugs, this is not nice. -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Abandoned?, testcase --- Comment #20 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Is this still an issue in Wine 1.7.45 or later? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #21 from Ed Sternin <ed.sternin(a)brocku.ca> --- Ken Sharp: yes, never was resolved -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 --- Comment #22 from Bruno Jesus <00cpxxx(a)gmail.com> --- Created attachment 54757 --> https://bugs.winehq.org/attachment.cgi?id=54757 Compiled source example This problem is still present in 1.9.12, I compiled the example provided in comment for easier testing. It is very easy to reproduce. Just open the example, click in the edit field and use the right arrow key several times. There is much more text in the field than fits in the screen so Wine will horizontal scroll the edit field. But Windows won't. As soon as the caret hits the right border of the window it will stop and NOT perform any scroll. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 joaopa <jeremielapuree(a)yahoo.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremielapuree(a)yahoo.fr --- Comment #23 from joaopa <jeremielapuree(a)yahoo.fr> --- Download link here https://archive.org/details/ElectronicWorkbenchEwb5.12 Compiled test-case does not work still with wine-5.6. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |focht(a)gmx.net Keywords|Abandoned? | URL|http://appdb.winehq.org/obj |https://archive.org/details |ectManager.php?sClass=versi |/ElectronicWorkbenchEwb5.12 |on&iId=402 | -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=17807 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, source CC| |fgouget(a)codeweavers.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (2)
-
wine-bugs＠winehq.org -
WineHQ Bugzilla