[Bug 38769] New: Additional AES algorithms in schannel break wine build
https://bugs.winehq.org/show_bug.cgi?id=38769 Bug ID: 38769 Summary: Additional AES algorithms in schannel break wine build Product: Wine Version: 1.7.45 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: secur32 Assignee: wine-bugs(a)winehq.org Reporter: wylda(a)volny.cz Distribution: --- Hi Jacek, I finally found some time for wine and your todays patch broke my wine building machine (no offence ;c) commit 3617e2b2a9f028347702c87da97e6a74f854027e Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jun 16 13:46:32 2015 +0200 secur32: Added support for a few more algorithms in schannel_get_cipher_algid. wine-1.7.45-88-g1342254 builds fine, but wine-1.7.45-89-g3617e2b fails with: make[1]: Entering directory '/build/wine_git_build_32/dlls/secur32' gcc -m32 -c -o schannel_gnutls.o ../../../wine_git_build/dlls/secur32/schannel_gnutls.c -I. \ -I../../../wine_git_build/dlls/secur32 -I../../include -I../../../wine_git_build/include \ -I/usr/include/p11-kit-1 -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing \ -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers -Wstrict-prototypes -Wtype-limits \ -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 \ -gstrict-dwarf -fno-omit-frame-pointer -g -O0 ../../../wine_git_build/dlls/secur32/schannel_gnutls.c: In function ‘schannel_get_cipher_algid’: ../../../wine_git_build/dlls/secur32/schannel_gnutls.c:302:10: error: ‘GNUTLS_CIPHER_AES_128_GCM’ undeclared (first use in this function) case GNUTLS_CIPHER_AES_128_GCM: return CALG_AES_128; ^ ../../../wine_git_build/dlls/secur32/schannel_gnutls.c:302:10: note: each undeclared identifier is reported only once for each function it appears in ../../../wine_git_build/dlls/secur32/schannel_gnutls.c:304:10: error: ‘GNUTLS_CIPHER_AES_256_GCM’ undeclared (first use in this function) case GNUTLS_CIPHER_AES_256_GCM: ^ Makefile:339: recipe for target 'schannel_gnutls.o' failed make[1]: *** [schannel_gnutls.o] Error 1 make[1]: Leaving directory '/build/wine_git_build_32/dlls/secur32' Makefile:13239: recipe for target 'dlls/secur32' failed make: *** [dlls/secur32] Error 2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression CC| |jacek(a)codeweavers.com Regression SHA1| |3617e2b2a9f028347702c87da97 | |e6a74f854027e --- Comment #1 from Wylda <wylda(a)volny.cz> --- Filling some more fields. Distro: Debian Jessie. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Wylda <wylda(a)volny.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Distribution|--- |Debian -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #2 from Henri Verbeet <hverbeet(a)gmail.com> --- (In reply to Wylda from comment #1)
Filling some more fields. Distro: Debian Jessie.
That's odd, it works for me on jessie. Do you have the correct gnutls development package installed? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #3 from Henri Verbeet <hverbeet(a)gmail.com> --- (i.e., not the gnutls26 one left over from a wheezy upgrade.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #4 from Wylda <wylda(a)volny.cz> --- (In reply to Henri Verbeet from comment #3)
(i.e., not the gnutls26 one left over from a wheezy upgrade.)
Thanks for the hint, you were right. Updating libgnutls.so.26 -> libgnutls-deb0.so.28 fixed that. Unfortunately, current Debian Wheeze is out of game. I sporadically used that to be able to compile older wine version (lower than v1.7.5 I guess) for regression hunting. Jacek, feel free to close this as invalid, if this is not supposed to be fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source CC| |imwellcushtymelike(a)gmail.co | |m --- Comment #5 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Also affects Ubuntu Trusty. I'll let someone else decide if this is invalid (or upstream, etc.) -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #6 from Wylda <wylda(a)volny.cz> ---
Jacek, feel free to close this as invalid...
Or if the patch doesn't fix any bug, what about unpopular revert? -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Jay Hilliard <jaydhilliard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaydhilliard(a)gmail.com --- Comment #7 from Jay Hilliard <jaydhilliard(a)gmail.com> --- I had to revert it and dedbd1883611b1c72abeb05d9f93cd5ac8af2e90 to get wine to build on RHEL6 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Sebastian Lackner <sebastian(a)fds-team.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian(a)fds-team.de -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Hugh McMaster <hugh.mcmaster(a)outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hugh.mcmaster(a)outlook.com --- Comment #8 from Hugh McMaster <hugh.mcmaster(a)outlook.com> --- (In reply to Ken Sharp from comment #5)
Also affects Ubuntu Trusty.
And derivatives, such as Linux Mint 17. I'll let someone else decide if this is invalid
(or upstream, etc.)
Well, it has to be fixed, either with temporary defines or a revert. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #9 from Jacek Caban <jacek(a)codeweavers.com> --- Thanks for the report. Patch sent, please test. http://source.winehq.org/patches/data/112128 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Ken Sharp <imwellcushtymelike(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Severity|normal |critical --- Comment #10 from Ken Sharp <imwellcushtymelike(a)gmail.com> --- Compiles on Trusty with the patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Jacek Caban <jacek(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |72747526b1242f436db9e68d319 | |c37484ce02109 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #11 from Jacek Caban <jacek(a)codeweavers.com> --- Fixed in Git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #12 from Wylda <wylda(a)volny.cz> --- Fixed in Wheezy too. Thank you for quick fix, Jacek. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #13 from Jay Hilliard <jaydhilliard(a)gmail.com> --- Still failing on RHEL6 (fully updated) gcc -c -o schannel_gnutls.o schannel_gnutls.c -I. -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe \ -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wstrict-prototypes -Wtype-limits -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith \ -gdwarf-2 -gstrict-dwarf -g -O2 schannel_gnutls.c:52: error: ‘gnutls_cipher_get_block_size’ undeclared here (not in a function) schannel_gnutls.c:52: warning: type defaults to ‘int’ in declaration of ‘pgnutls_cipher_get_block_size’ schannel_gnutls.c: In function ‘schannel_get_cipher_algid’: schannel_gnutls.c:276: error: ‘GNUTLS_CIPHER_AES_192_CBC’ undeclared (first use in this function) schannel_gnutls.c:276: error: (Each undeclared identifier is reported only once schannel_gnutls.c:276: error: for each function it appears in.) schannel_gnutls.c: In function ‘schan_imp_get_session_cipher_block_size’: schannel_gnutls.c:319: error: called object ‘pgnutls_cipher_get_block_size’ is not a function schannel_gnutls.c: In function ‘schan_imp_send’: schannel_gnutls.c:386: warning: format ‘%d’ expects type ‘int’, but argument 5 has type ‘ssize_t’ schannel_gnutls.c:386: warning: format ‘%d’ expects type ‘int’, but argument 6 has type ‘ssize_t’ make[1]: *** [schannel_gnutls.o] Error 1 make[1]: Leaving directory `/disk1/scratch/wine-git/dlls/secur32' make: *** [dlls/secur32] Error 2 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #14 from Jacek Caban <jacek(a)codeweavers.com> --- This should help: http://source.winehq.org/git/wine.git/commitdiff/cae3f98c6938663aab248f6551e... Please retest with current Git. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 --- Comment #15 from Jay Hilliard <jaydhilliard(a)gmail.com> --- I did and it solved the problem on RHEL6 Thank you! -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=38769 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #16 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 1.7.46. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
wine-bugs＠winehq.org