[Bug 54691] New: reg.exe:copy, reg.exe:delete, reg.exe:export, reg.exe:import & reg.exe:query - The 64-bit tests fail due to ERROR_ACCESS_DENIED errors in Wine
https://bugs.winehq.org/show_bug.cgi?id=54691 Bug ID: 54691 Summary: reg.exe:copy, reg.exe:delete, reg.exe:export, reg.exe:import & reg.exe:query - The 64-bit tests fail due to ERROR_ACCESS_DENIED errors in Wine Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: registry Assignee: wine-bugs(a)winehq.org Reporter: fgouget(a)codeweavers.com Distribution: --- Many reg.exe 64-bit tests fail due to ERROR_ACCESS_DENIED errors in Wine. reg.exe:copy: copy.c:678: Test failed: Failed to delete registry key, got error 5 copy.c:678: Test failed: Failed to delete registry key, got error 5 copy.c:679: Test failed: Failed to delete registry key, got error 5 copy.c:679: Test failed: Failed to delete registry key, got error 5 copy.c:683: Test failed: registry key 'Software\Wine\reg_copy' shouldn't exist; got 0, expected 2 copy.c:684: Test failed: registry key 'Software\Wine\reg_test' shouldn't exist; got 0, expected 2 copy.c:694: Test failed: got exit code 0, expected 1 reg.exe:delete: delete.c:256: Test failed: Failed to delete registry key, got error 5 delete.c:256: Test failed: Failed to delete registry key, got error 5 reg.exe:export: export.c:537: Test failed: Failed to delete registry key, got error 5 export.c:537: Test failed: Failed to delete registry key, got error 5 export.c:542: Test failed: registry key 'Software\Wine\reg_test' shouldn't exist; got 0, expected 2 export.c:549: Test failed: got exit code 0, expected 1 reg.exe:import: import.c:3730: Test failed: Failed to delete registry key, got error 5 import.c:3730: Test failed: Failed to delete registry key, got error 5 import.c:3755: Test failed: Failed to delete registry key, got error 5 import.c:3755: Test failed: Failed to delete registry key, got error 5 import.c:3777: Test failed: registry key 'Software\Wine\reg_test' shouldn't exist; got 0, expected 2 reg.exe:query: query.c:411: Test failed: Failed to delete registry key, got error 5 query.c:411: Test failed: Failed to delete registry key, got error 5 query.c:418: Test failed: query output does not match expected output query.c:422: Test failed: query output does not match expected output query.c:428: Test failed: Failed to delete registry key, got error 5 query.c:428: Test failed: Failed to delete registry key, got error 5 See https://test.winehq.org/data/patterns.html#reg.exe:copy https://test.winehq.org/data/patterns.html#reg.exe:delete https://test.winehq.org/data/patterns.html#reg.exe:export https://test.winehq.org/data/patterns.html#reg.exe:import https://test.winehq.org/data/patterns.html#reg.exe:query Note that these failures only happen in the wow64 case in Wine. All the tests fail when run on their own in a clean wineprefix except reg.exe:delete. That test's failures are actually caused by reg.exe:add. So to reproduce the reg.exe:delete failures run the following couple of commands in the same wineprefix: ./wine64 programs/reg/tests/x86_64-windows/reg.exe_test.exe add ./wine64 programs/reg/tests/x86_64-windows/reg.exe_test.exe delete A bisect shows that all these failures started with the commit below: commit 0da843f082217289d89b3eb9562c351ca9cb721e Author: Sven Baars <sbaars(a)codeweavers.com> Date: Wed Nov 30 11:42:39 2022 +0100 kernelbase: Restructure the open_key() loop. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |0da843f082217289d89b3eb9562 | |c351ca9cb721e Keywords| |regression, source, | |testcase -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sven.wine(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|reg.exe:copy, |reg.exe:copy, |reg.exe:delete, |reg.exe:delete, |reg.exe:export, |reg.exe:export, |reg.exe:import & |reg.exe:import & |reg.exe:query - The 64-bit |reg.exe:query (+32-bit |tests fail due to |reg.exe:add) - The 64-bit |ERROR_ACCESS_DENIED errors |tests fail due to |in Wine |ERROR_ACCESS_DENIED errors | |in Wine --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- This also causes the 32-bit reg.exe:add test to fail WHEN it is run in the same wineprefix after reg.exe:copy: add.c:1051: Test failed: RegDeleteKeyExA failed: got error 5 add.c:1064: Test failed: registry key 'Software\Wine\reg_test' shouldn't exist; got 0, expected 2 See https://test.winehq.org/data/patterns.html#reg.exe:add My development box is the only case where I run both the full 64-bit WineTest suite the 32-bit one in the same wineprefix (and in that order). This is why this failure only happens on fg-deb64-wow32. That makes sense: reg.exe:copy (and the ones that follow) fail to clean up after themselves which trips up this RegDeleteKeyExA() call in the 32-bit reg.exe:add. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 --- Comment #2 from Sven Baars <sven.wine(a)gmail.com> --- Thanks for the report. These failures were fixed by 88fa3459b928c6d27f56c67778c0e5d45ebbaa5b -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |88fa3459b928c6d27f56c67778c | |0e5d45ebbaa5b Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from François Gouget <fgouget(a)codeweavers.com> --- Yes, this is fixed. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
https://bugs.winehq.org/show_bug.cgi?id=54691 Alexandre Julliard <julliard(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #4 from Alexandre Julliard <julliard(a)winehq.org> --- Closing bugs fixed in 8.5. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.
participants (1)
-
WineHQ Bugzilla